[Qemu-commits] [qemu/qemu] edcbea: hw/display/edid: Add missing 'qdev-pr

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] edcbea: hw/display/edid: Add missing 'qdev-pr

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] edcbea: hw/display/edid: Add missing 'qdev-properties.h' h...
Date:	Fri, 29 May 2020 03:30:29 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: edcbea008d7943633911c2d385fd0c94bb84403c
      
https://github.com/qemu/qemu/commit/edcbea008d7943633911c2d385fd0c94bb84403c
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M include/hw/display/edid.h

  Log Message:
  -----------
  hw/display/edid: Add missing 'qdev-properties.h' header

When trying to consume the DEFINE_EDID_PROPERTIES() macro
by including "hw/display/edid.h", we get this build failure:

  include/hw/display/edid.h:24:5: error: implicit declaration of
  function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration]
     24 |     DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0),    \
        |     ^~~~~~~~~~~~~~~~~~

Headers should be self-contained, and one shouldn't have to
dig to find the missing headers.
In this case "hw/qdev-properties.h" is missing. Add it.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-2-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 85664cf0a4bf91764fb55154feed5797be32a30a
      
https://github.com/qemu/qemu/commit/85664cf0a4bf91764fb55154feed5797be32a30a
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/cg3.c
    M hw/display/trace-events

  Log Message:
  -----------
  hw/display/cg3: Convert debug printf()s to trace events

Convert DPRINTF() to trace events and remove ifdef'ry.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-3-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: bee61ca2b9a9e6f9445bf37f6474f704c5fd07cd
      
https://github.com/qemu/qemu/commit/bee61ca2b9a9e6f9445bf37f6474f704c5fd07cd
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/cirrus_vga.c
    M hw/display/trace-events

  Log Message:
  -----------
  hw/display/cirrus_vga: Convert debug printf() to trace event

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-4-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: bb6e9e940769d18ca1de24a729fddba611bbd751
      
https://github.com/qemu/qemu/commit/bb6e9e940769d18ca1de24a729fddba611bbd751
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/cirrus_vga.c

  Log Message:
  -----------
  hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf

Replace some debug printf() calls by qemu_log_mask(LOG_UNIMP),
and add a new one in cirrus_linear_bitblt_read().

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-5-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 2b55f4d3504a9f347380599358a9a171ecbb6869
      
https://github.com/qemu/qemu/commit/2b55f4d3504a9f347380599358a9a171ecbb6869
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/cirrus_vga.c

  Log Message:
  -----------
  hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf

Replace some debug printf() calls by qemu_log_mask(LOG_GUEST_ERROR).

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-6-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 615277217490317193882101b5270d9147a6d465
      
https://github.com/qemu/qemu/commit/615277217490317193882101b5270d9147a6d465
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/cirrus_vga.c
    M hw/display/trace-events

  Log Message:
  -----------
  hw/display/cirrus_vga: Convert debug printf() to trace event

Convert the final bit of DEBUG_BITBLT to a tracepoint.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-7-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 91e7fd3ae5a6fcd270f8d38fd5771033a806abce
      
https://github.com/qemu/qemu/commit/91e7fd3ae5a6fcd270f8d38fd5771033a806abce
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/dpcd.c

  Log Message:
  -----------
  hw/display/dpcd: Fix memory region size

The memory region size is 512K.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-8-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: eeb1168032a1f6dfc7eb5897c3bf4e53fdc28b98
      
https://github.com/qemu/qemu/commit/eeb1168032a1f6dfc7eb5897c3bf4e53fdc28b98
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/dpcd.c
    M hw/display/trace-events

  Log Message:
  -----------
  hw/display/dpcd: Convert debug printf()s to trace events

Convert DPRINTF() to trace events and remove ifdef'ry.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-9-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 7bbdf0f8922ab0fc6f805851f6bb1a9d271414f4
      
https://github.com/qemu/qemu/commit/7bbdf0f8922ab0fc6f805851f6bb1a9d271414f4
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/xlnx_dp.c

  Log Message:
  -----------
  hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report()

DPRINTF() calls are disabled by default, so when unexpected
data is used, the whole process abort without information.

Display a bit of information with error_report() before crashing.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-10-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: aa0fd16d00efd56acdf7def10f769615038e2375
      
https://github.com/qemu/qemu/commit/aa0fd16d00efd56acdf7def10f769615038e2375
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/vmware_vga.c

  Log Message:
  -----------
  hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR)

Avoid flooding stdio by converting printf() calls to
qemu_log_mask(GUEST_ERROR), which are disabled by default.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-11-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: becce5e90ace3f4d16ff31f12835bf416ba702a7
      
https://github.com/qemu/qemu/commit/becce5e90ace3f4d16ff31f12835bf416ba702a7
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/vmware_vga.c

  Log Message:
  -----------
  hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion

To avoid the orphan I/O memory region being added in the /unattached
QOM container, register the PCI device as its owner.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20200526062252.19852-12-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: b3caeaf2c863bbf0e57c789d2ee6923f7d3bfe4f
      
https://github.com/qemu/qemu/commit/b3caeaf2c863bbf0e57c789d2ee6923f7d3bfe4f
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/exynos4210_fimd.c

  Log Message:
  -----------
  hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR)

Replace DPRINT_ERROR() by qemu_log_mask(GUEST_ERROR).

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-13-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 00a946a3cb2568033f8f5c1a7769c5239a429c94
      
https://github.com/qemu/qemu/commit/00a946a3cb2568033f8f5c1a7769c5239a429c94
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/omap_dss.c

  Log Message:
  -----------
  hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP)

Replace fprintf() call by qemu_log_mask(LOG_UNIMP), which is
disabled by default. This avoid flooding the terminal when
fuzzing the device.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-14-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: b3a7e2416fb867d047723da251b8960228dcc9f4
      
https://github.com/qemu/qemu/commit/b3a7e2416fb867d047723da251b8960228dcc9f4
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/pxa2xx_lcd.c

  Log Message:
  -----------
  hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask()

Replace printf() calls by qemu_log_mask(UNIMP), which is
disabled by default. This avoid flooding the terminal when
fuzzing the device.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-15-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: e29da77e5fddf6480e3a0e80b63d703edaec751b
      
https://github.com/qemu/qemu/commit/e29da77e5fddf6480e3a0e80b63d703edaec751b
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/sm501.c

  Log Message:
  -----------
  sm501: Convert printf + abort to qemu_log_mask

Some places already use qemu_log_mask() to log unimplemented features
or errors but some others have printf() then abort(). Convert these to
qemu_log_mask() and avoid aborting to prevent guests to easily cause
denial of service.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 
305af87f59d81e92f2aaff09eb8a3603b8baa322.1590089984.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6f8183b5dc5b309378687830a25e85ea8fb860ea
      
https://github.com/qemu/qemu/commit/6f8183b5dc5b309378687830a25e85ea8fb860ea
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/sm501.c

  Log Message:
  -----------
  sm501: Shorten long variable names in sm501_2d_operation

This increases readability and cleans up some confusing naming.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-id: 
b9b67b94c46e945252a73c77dfd117132c63c4fb.1590089984.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 2824809b7f8f03ddc6e2b7e33e78c06022424298
      
https://github.com/qemu/qemu/commit/2824809b7f8f03ddc6e2b7e33e78c06022424298
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/sm501.c

  Log Message:
  -----------
  sm501: Use BIT(x) macro to shorten constant

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 
124bf5de8d7cf503b32b377d0445029a76bfbd49.1590089984.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 3d0b096298b5579a7fa0753ad90968b27bc65372
      
https://github.com/qemu/qemu/commit/3d0b096298b5579a7fa0753ad90968b27bc65372
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/sm501.c

  Log Message:
  -----------
  sm501: Clean up local variables in sm501_2d_operation

Make variables local to the block they are used in to make it clearer
which operation they are needed for.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 
ae59f8138afe7f6a5a4a82539d0f61496a906b06.1590089984.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: b15a22bbcbe6a78dc3d88fe3134985e4cdd87de4
      
https://github.com/qemu/qemu/commit/b15a22bbcbe6a78dc3d88fe3134985e4cdd87de4
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/sm501.c

  Log Message:
  -----------
  sm501: Replace hand written implementation with pixman where possible

Besides being faster this should also prevent malicious guests to
abuse 2D engine to overwrite data or cause a crash.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-id: 
58666389b6cae256e4e972a32c05cf8aa51bffc0.1590089984.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: fa70c2871f011f1ca6763a21a291f2ced1f121d2
      
https://github.com/qemu/qemu/commit/fa70c2871f011f1ca6763a21a291f2ced1f121d2
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/sm501.c

  Log Message:
  -----------
  sm501: Optimize small overlapping blits

AmigaOS tends to do a lot of small blits (even 1 pixel). Avoid malloc
overhead by keeping around a buffer for this and only alloc when
blitting larger areas.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-id: 
7946852258d528497e85f465327fc90b5c3b59fb.1590089984.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: fa0013a1bc5f6011a1017e0e655740403e5555d9
      
https://github.com/qemu/qemu/commit/fa0013a1bc5f6011a1017e0e655740403e5555d9
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/sm501.c

  Log Message:
  -----------
  sm501: Remove obsolete changelog and todo comment

Also update copyright year for latest changes

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 
1392cad2ad1315a5a50409970e0af061821462e6.1590089984.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: b8bee16e94df0fcd03bdad9969c30894418b0e6e
      
https://github.com/qemu/qemu/commit/b8bee16e94df0fcd03bdad9969c30894418b0e6e
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M hw/display/cg3.c
    M hw/display/cirrus_vga.c
    M hw/display/dpcd.c
    M hw/display/exynos4210_fimd.c
    M hw/display/omap_dss.c
    M hw/display/pxa2xx_lcd.c
    M hw/display/sm501.c
    M hw/display/trace-events
    M hw/display/vmware_vga.c
    M hw/display/xlnx_dp.c
    M include/hw/display/edid.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200528-pull-request' 
into staging

hw/dispaly/sm501: bugfixes, add sanity checks.
hw/display: use tracepoints, misc cleanups.

# gpg: Signature made Thu 28 May 2020 13:35:32 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/vga-20200528-pull-request: (21 commits)
  sm501: Remove obsolete changelog and todo comment
  sm501: Optimize small overlapping blits
  sm501: Replace hand written implementation with pixman where possible
  sm501: Clean up local variables in sm501_2d_operation
  sm501: Use BIT(x) macro to shorten constant
  sm501: Shorten long variable names in sm501_2d_operation
  sm501: Convert printf + abort to qemu_log_mask
  hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask()
  hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP)
  hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR)
  hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion
  hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR)
  hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report()
  hw/display/dpcd: Convert debug printf()s to trace events
  hw/display/dpcd: Fix memory region size
  hw/display/cirrus_vga: Convert debug printf() to trace event
  hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf
  hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf
  hw/display/cirrus_vga: Convert debug printf() to trace event
  hw/display/cg3: Convert debug printf()s to trace events
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/a20ab81d2230...b8bee16e94df
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] edcbea: hw/display/edid: Add missing 'qdev-properties.h' h..., Peter Maydell <=
Prev by Date: [Qemu-commits] [qemu/qemu] a932ee: linux-user: limit check to HOST_LONG_BITS < TARGET...
Next by Date: [Qemu-commits] [qemu/qemu] 3df437: configure: add alternate binary for genisoimage
Previous by thread: [Qemu-commits] [qemu/qemu] a932ee: linux-user: limit check to HOST_LONG_BITS < TARGET...
Next by thread: [Qemu-commits] [qemu/qemu] 3df437: configure: add alternate binary for genisoimage
Index(es):
- Date
- Thread