[Qemu-commits] [qemu/qemu] a932ee: linux-user: limit check to HOST_LONG_BITS < TARGET...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a932eec49d9ec106c7952314ad1adc28f0986076
      
https://github.com/qemu/qemu/commit/a932eec49d9ec106c7952314ad1adc28f0986076
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS

Newer clangs rightly spot that you can never exceed the full address
space of 64 bit hosts with:

  linux-user/elfload.c:2076:41: error: result of comparison 'unsigned
  long' > 18446744073709551615 is always false
  [-Werror,-Wtautological-type-limit-compare]
  4685         if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) {
  4686             ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~
  4687 1 error generated.

So lets limit the check to 32 bit hosts only.

Fixes: ee94743034bf
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200525131823.715-8-thuth@redhat.com>
[thuth: Use HOST_LONG_BITS < TARGET_ABI_BITS instead of HOST_LONG_BITS == 32]
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: d1d3ba2b23c06aab2f7e0511f08f450a3b96ca61
      
https://github.com/qemu/qemu/commit/d1d3ba2b23c06aab2f7e0511f08f450a3b96ca61
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add Philippe, Alex and Wainer to the Gitlab-CI section

Initially, I was the only one who was using Gitlab while most developers
had their git trees still on other systems, but that has changed nowadays.
There is now much more interest in the Gitlab-CI today, so it would be
good to have more than only one maintainer / reviewer for the gitlab-ci.yml
file. Alex, Wainer and Philippe kindly offered their help here, so let's
add them to the corresponding section in the MAINTAINERS file now.

Message-Id: <20200210155115.9371-1-thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f3ea07c70debad6b8f6c084ad0e0c9ff27b3e73c
      
https://github.com/qemu/qemu/commit/f3ea07c70debad6b8f6c084ad0e0c9ff27b3e73c
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Remove flex/bison packages

QEMU does not use flex/bison packages.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200515163029.12917-4-philmd@redhat.com>
Message-Id: <20200525131823.715-3-thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 65ea4e65df15682f058b3ef61c8d8fc278ddc0d3
      
https://github.com/qemu/qemu/commit/65ea4e65df15682f058b3ef61c8d8fc278ddc0d3
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  GitLab CI: avoid calling before_scripts on unintended jobs

At this point it seems that all jobs depend on those steps, with
maybe the EDK2 jobs as exceptions.

The jobs that will be added later will not want those scripts to be
run, so let's move these steps to the appropriate jobs, while
still trying to avoid repetition.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20200525131823.715-4-thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
[thuth: Rebased to current master branch, use separate template]
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 922febe2af0a636636d3b0fd4309f26072cfd2cc
      
https://github.com/qemu/qemu/commit/922febe2af0a636636d3b0fd4309f26072cfd2cc
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    R .gitlab-ci-edk2.yml
    R .gitlab-ci-opensbi.yml
    A .gitlab-ci.d/edk2.yml
    A .gitlab-ci.d/opensbi.yml
    M .gitlab-ci.yml
    M MAINTAINERS

  Log Message:
  -----------
  gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder

We have a dedicated folder for the gitlab-ci - so there is no need
to clutter the top directory with these .yml files.

Message-Id: <20200525131823.715-5-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b5d621ff4a7d86e82a58104d5706bda2b4238626
      
https://github.com/qemu/qemu/commit/b5d621ff4a7d86e82a58104d5706bda2b4238626
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Do not use the standard container images from gitlab

Currently all pipelines of the gitlab CI are failing, except for the
"build-user" pipeline. There is an issue with the default container
image (likely Debian stable) where they imported something bad in one
of the system headers:

 /usr/include/linux/swab.h: In function '__swab':
 /builds/huth/qemu/include/qemu/bitops.h:20:34: error: "sizeof" is not
  defined, evaluates to 0 [-Werror=undef]
 #define BITS_PER_LONG           (sizeof (unsigned long) * BITS_PER_BYTE)

We could maybe work-around this issue or wait for the default containers
to get fixed, but considering that we use Ubuntu (and thus Debian-style)
CI in Travis already to a very large extent, we should consider to use
some RPM-based distros in our gitlab CI instead. Thus let's change the
failing pipelines to use Fedora and CentOS (and also one Ubuntu 19.10,
since 20.04 is broken, too) now.

Message-Id: <20200525131823.715-6-thuth@redhat.com>
Acked-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0016afa250d251a1b3fbc90c6d618e7f00e02f14
      
https://github.com/qemu/qemu/commit/0016afa250d251a1b3fbc90c6d618e7f00e02f14
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Determine the number of jobs dynamically

Some people might want to run the gitlab CI pipelines in an environment
where multiple CPUs are available to the runners, so let's rather get
the number for "-j" from the "nproc" program (increased by 1 to compensate
for jobs that wait for I/O) instead of hard-coding it.

Message-Id: <20200525131823.715-7-thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: a20ab81d22300cca80325c284f21eefee99aa740
      
https://github.com/qemu/qemu/commit/a20ab81d22300cca80325c284f21eefee99aa740
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    R .gitlab-ci-edk2.yml
    R .gitlab-ci-opensbi.yml
    A .gitlab-ci.d/edk2.yml
    A .gitlab-ci.d/opensbi.yml
    M .gitlab-ci.yml
    M MAINTAINERS
    M linux-user/elfload.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2020-05-28' into staging

Fixes and improvements for the gitlab-CI:
- Build with other images instead of the broken Debian containers
- Fix building with the latest version of Clang (at least wrt. to
  the gitlab-CI pipeline)
- Add Philippe, Alex and Wainer to the Gitlab-CI section in MAINTAINERS

# gpg: Signature made Thu 28 May 2020 10:16:15 BST
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2020-05-28:
  gitlab-ci: Determine the number of jobs dynamically
  gitlab-ci: Do not use the standard container images from gitlab
  gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder
  GitLab CI: avoid calling before_scripts on unintended jobs
  gitlab-ci: Remove flex/bison packages
  MAINTAINERS: Add Philippe, Alex and Wainer to the Gitlab-CI section
  linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/87023dcc2589...a20ab81d2230