[Qemu-commits] [qemu/qemu] a1dcdd: tests/fuzz/Makefile: Do not link code using unavai...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a1dcdda8275e15ab919bcec012e9e662283b6a7d
      
https://github.com/qemu/qemu/commit/a1dcdda8275e15ab919bcec012e9e662283b6a7d
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M tests/qtest/fuzz/Makefile.include

  Log Message:
  -----------
  tests/fuzz/Makefile: Do not link code using unavailable devices

Some devices availability depends on CONFIG options.
Use these options to only link tests when requested device
is available.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 763815a83744fe7b9c5d88bd54370f25742fd10c
      
https://github.com/qemu/qemu/commit/763815a83744fe7b9c5d88bd54370f25742fd10c
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  Makefile: List fuzz targets in 'make help'

List softmmu fuzz targets in 'make help' output:

  $ make help
  ...
  Architecture specific targets:
  aarch64-softmmu/all            - Build for aarch64-softmmu
  aarch64-softmmu/fuzz           - Build fuzzer for aarch64-softmmu
  alpha-softmmu/all              - Build for alpha-softmmu
  alpha-softmmu/fuzz             - Build fuzzer for alpha-softmmu
  arm-softmmu/all                - Build for arm-softmmu
  arm-softmmu/fuzz               - Build fuzzer for arm-softmmu
  ...

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 73ee6da45d22c82275042f7e84426e647246a56d
      
https://github.com/qemu/qemu/commit/73ee6da45d22c82275042f7e84426e647246a56d
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M tests/qtest/fuzz/i440fx_fuzz.c

  Log Message:
  -----------
  tests/fuzz: Add missing space in test description

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 79e18a60ab456764eaa974b67b9c54281a5156db
      
https://github.com/qemu/qemu/commit/79e18a60ab456764eaa974b67b9c54281a5156db
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M tests/qtest/fuzz/i440fx_fuzz.c

  Log Message:
  -----------
  tests/fuzz: Remove unuseful/unused typedefs

These typedefs are not used. Use a simple structure,
remote the typedefs.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 84cb0a6d20c94abab6bc868e0e92044fcebdb1d7
      
https://github.com/qemu/qemu/commit/84cb0a6d20c94abab6bc868e0e92044fcebdb1d7
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M tests/qtest/fuzz/i440fx_fuzz.c

  Log Message:
  -----------
  tests/fuzz: Extract pciconfig_fuzz_qos() method

Extract the generic pciconfig_fuzz_qos() method from
i440fx_fuzz_qos(). This will help to write tests not
specific to the i440FX controller.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 6fb5f0842aab0f744eebfabefb447b3a3a1af7cc
      
https://github.com/qemu/qemu/commit/6fb5f0842aab0f744eebfabefb447b3a3a1af7cc
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M tests/qtest/fuzz/i440fx_fuzz.c

  Log Message:
  -----------
  tests/fuzz: Extract ioport_fuzz_qtest() method

Extract generic ioport_fuzz_qtest() method from
i440fx_fuzz_qtest(). This will help to write tests
not specific to the i440FX controller.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: de137e44f75d9868f5b548638081850f6ac771f2
      
https://github.com/qemu/qemu/commit/de137e44f75d9868f5b548638081850f6ac771f2
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2020-05-18 (Mon, 18 May 2020)

  Changed paths:
    M util/aio-posix.c
    M util/fdmon-io_uring.c

  Log Message:
  -----------
  aio-posix: don't duplicate fd handler deletion in fdmon_io_uring_destroy()

The io_uring file descriptor monitoring implementation has an internal
list of fd handlers that are pending submission to io_uring.
fdmon_io_uring_destroy() deletes all fd handlers on the list.

Don't delete fd handlers directly in fdmon_io_uring_destroy() for two
reasons:
1. This duplicates the aio-posix.c AioHandler deletion code and could
   become outdated if the struct changes.
2. Only handlers with the FDMON_IO_URING_REMOVE flag set are safe to
   remove. If the flag is not set then something still has a pointer to
   the fd handler. Let aio-posix.c and its user worry about that. In
   practice this isn't an issue because fdmon_io_uring_destroy() is only
   called when shutting down so all users have removed their fd
   handlers, but the next patch will need this!

Signed-off-by: Stefan Hajnoczi <address@hidden>
Tested-by: Oleksandr Natalenko <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: ba607ca8bff4d2c2062902f8355657c865ac7c29
      
https://github.com/qemu/qemu/commit/ba607ca8bff4d2c2062902f8355657c865ac7c29
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2020-05-18 (Mon, 18 May 2020)

  Changed paths:
    M include/block/aio.h
    M util/aio-posix.c
    M util/aio-win32.c
    M util/async.c

  Log Message:
  -----------
  aio-posix: disable fdmon-io_uring when GSource is used

The glib event loop does not call fdmon_io_uring_wait() so fd handlers
waiting to be submitted build up in the list. There is no benefit is
using io_uring when the glib GSource is being used, so disable it
instead of implementing a more complex fix.

This fixes a memory leak where AioHandlers would build up and increasing
amounts of CPU time were spent iterating them in aio_pending(). The
symptom is that guests become slow when QEMU is built with io_uring
support.

Buglink: https://bugs.launchpad.net/qemu/+bug/1877716
Fixes: 73fd282e7b6dd4e4ea1c3bbb3d302c8db51e4ccf ("aio-posix: add io_uring fd 
monitoring implementation")
Signed-off-by: Stefan Hajnoczi <address@hidden>
Tested-by: Oleksandr Natalenko <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: f2465433b43fb87766d79f42191607dac4aed5b4
      
https://github.com/qemu/qemu/commit/f2465433b43fb87766d79f42191607dac4aed5b4
  Author: Peter Maydell <address@hidden>
  Date:   2020-05-19 (Tue, 19 May 2020)

  Changed paths:
    M Makefile
    M include/block/aio.h
    M tests/qtest/fuzz/Makefile.include
    M tests/qtest/fuzz/i440fx_fuzz.c
    M util/aio-posix.c
    M util/aio-win32.c
    M util/async.c
    M util/fdmon-io_uring.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

Pull request

# gpg: Signature made Tue 19 May 2020 09:00:32 BST
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>" [full]
# gpg:                 aka "Stefan Hajnoczi <address@hidden>" [full]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/block-pull-request:
  aio-posix: disable fdmon-io_uring when GSource is used
  aio-posix: don't duplicate fd handler deletion in fdmon_io_uring_destroy()
  tests/fuzz: Extract ioport_fuzz_qtest() method
  tests/fuzz: Extract pciconfig_fuzz_qos() method
  tests/fuzz: Remove unuseful/unused typedefs
  tests/fuzz: Add missing space in test description
  Makefile: List fuzz targets in 'make help'
  tests/fuzz/Makefile: Do not link code using unavailable devices

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/bffe88d139ad...f2465433b43f