qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 233982: MAINTAINERS: Upgrade myself as 9pfs c


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 233982: MAINTAINERS: Upgrade myself as 9pfs co-maintainer
Date: Thu, 14 May 2020 04:00:29 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 233982af53915bd9fbfa604e3b566b50af6fe5a7
      
https://github.com/qemu/qemu/commit/233982af53915bd9fbfa604e3b566b50af6fe5a7
  Author: Christian Schoenebeck <address@hidden>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Upgrade myself as 9pfs co-maintainer

As suggested by Greg, let's upgrade myself as co-maintainer of 9pfs.

Signed-off-by: Christian Schoenebeck <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>


  Commit: 65abaa01ee5781f525e1b9a0d6e6e5a3d8696d5f
      
https://github.com/qemu/qemu/commit/65abaa01ee5781f525e1b9a0d6e6e5a3d8696d5f
  Author: Christian Schoenebeck <address@hidden>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  qemu-options.hx: 9p: clarify -virtfs vs. -fsdev

The docs are ambiguous about the difference (or actually their
equality) between options '-virtfs' vs. '-fsdev'. So clarify that
'-virtfs' is actually just a convenience shortcut for its
generalized form '-fsdev' in conjunction with '-device virtio-9p-pci'.

And as we're at it, also be a bit more descriptive what 9pfs is
actually used for.

Signed-off-by: Christian Schoenebeck <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>


  Commit: a5804fcf7b22fc7d1f9ec794dd284c7d504bd16b
      
https://github.com/qemu/qemu/commit/a5804fcf7b22fc7d1f9ec794dd284c7d504bd16b
  Author: Omar Sandoval <address@hidden>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  9pfs: local: ignore O_NOATIME if we don't have permissions

QEMU's local 9pfs server passes through O_NOATIME from the client. If
the QEMU process doesn't have permissions to use O_NOATIME (namely, it
does not own the file nor have the CAP_FOWNER capability), the open will
fail. This causes issues when from the client's point of view, it
believes it has permissions to use O_NOATIME (e.g., a process running as
root in the virtual machine). Additionally, overlayfs on Linux opens
files on the lower layer using O_NOATIME, so in this case a 9pfs mount
can't be used as a lower layer for overlayfs (cf.
https://github.com/osandov/drgn/blob/dabfe1971951701da13863dbe6d8a1d172ad9650/vmtest/onoatimehack.c
and https://github.com/NixOS/nixpkgs/issues/54509).

Luckily, O_NOATIME is effectively a hint, and is often ignored by, e.g.,
network filesystems. open(2) notes that O_NOATIME "may not be effective
on all filesystems. One example is NFS, where the server maintains the
access time." This means that we can honor it when possible but fall
back to ignoring it.

Acked-by: Christian Schoenebeck <address@hidden>
Signed-off-by: Omar Sandoval <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>


  Commit: 9bbb7e0fe081efff2e41f8517c256b72a284fe9b
      
https://github.com/qemu/qemu/commit/9bbb7e0fe081efff2e41f8517c256b72a284fe9b
  Author: Christian Schoenebeck <address@hidden>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M hw/9pfs/xen-9p-backend.c

  Log Message:
  -----------
  xen-9pfs: Fix log messages of reply errors

If delivery of some 9pfs response fails for some reason, log the
error message by mentioning the 9P protocol reply type, not by
client's request type. The latter could be misleading that the
error occurred already when handling the request input.

Signed-off-by: Christian Schoenebeck <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>


  Commit: 035b448b84f3557206abc44d786c5d3db2638f7d
      
https://github.com/qemu/qemu/commit/035b448b84f3557206abc44d786c5d3db2638f7d
  Author: Peter Maydell <address@hidden>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M MAINTAINERS
    M hw/9pfs/9p-util.h
    M hw/9pfs/xen-9p-backend.c
    M qemu-options.hx

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-14' into 
staging

Changes:
- Christian Schoenebeck is now co-maintainer for 9pfs
- relax checks for O_NOATIME
- minor documentation updates

# gpg: Signature made Thu 14 May 2020 08:14:37 BST
# gpg:                using RSA key B4828BAF943140CEF2A3491071D4D5E5822F73D6
# gpg: Good signature from "Greg Kurz <address@hidden>" [full]
# gpg:                 aka "Gregory Kurz <address@hidden>" [full]
# gpg:                 aka "[jpeg image of size 3330]" [full]
# Primary key fingerprint: B482 8BAF 9431 40CE F2A3  4910 71D4 D5E5 822F 73D6

* remotes/gkurz/tags/9p-next-2020-05-14:
  xen-9pfs: Fix log messages of reply errors
  9pfs: local: ignore O_NOATIME if we don't have permissions
  qemu-options.hx: 9p: clarify -virtfs vs. -fsdev
  MAINTAINERS: Upgrade myself as 9pfs co-maintainer

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d8f9d57dbd0c...035b448b84f3



reply via email to

[Prev in Thread] Current Thread [Next in Thread]