qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a4e570: tcg/mips: mips sync* encode error


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] a4e570: tcg/mips: mips sync* encode error
Date: Mon, 13 Apr 2020 05:15:25 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a4e57084c16d5b0eff3651693fba04f26b30b551
      
https://github.com/qemu/qemu/commit/a4e57084c16d5b0eff3651693fba04f26b30b551
  Author: lixinyu <address@hidden>
  Date:   2020-04-12 (Sun, 12 Apr 2020)

  Changed paths:
    M tcg/mips/tcg-target.inc.c

  Log Message:
  -----------
  tcg/mips: mips sync* encode error

OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and
OPC_SYNC_RMB have wrong encode. According to the mips manual,
their encode should be 'OPC_SYNC | 0x?? << 6' rather than
'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction
errors. These instructions often appear with multi-threaded
simulation.

Fixes: 6f0b99104a3 ("tcg/mips: Add support for fence")
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: lixinyu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 792cb70eb062c75dbbb2f2fcdec1f939287d44ef
      
https://github.com/qemu/qemu/commit/792cb70eb062c75dbbb2f2fcdec1f939287d44ef
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-13 (Mon, 13 Apr 2020)

  Changed paths:
    M tcg/mips/tcg-target.inc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20200412' into staging

Fix tcg/mips barrier encoding

# gpg: Signature made Sun 12 Apr 2020 22:08:22 BST
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Richard Henderson <address@hidden>" [full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-tcg-20200412:
  tcg/mips: mips sync* encode error

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/17e1e4981409...792cb70eb062



reply via email to

[Prev in Thread] Current Thread [Next in Thread]