[Qemu-commits] [qemu/qemu] 20a4f1: .github: Enable repo-lockdown bot to refuse GitHub...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 20a4f14f6e6f543100bfdd93705cbdebb549d250
      
https://github.com/qemu/qemu/commit/20a4f14f6e6f543100bfdd93705cbdebb549d250
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    A .github/lockdown.yml
    M MAINTAINERS

  Log Message:
  -----------
  .github: Enable repo-lockdown bot to refuse GitHub pull requests

Some GitHub users try to open pull requests against the GitHub
mirror. Unfortunate these get ignored until eventually someone
notices and closes the request.

Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
to pull requests with a friendly comment, close the request, and
then lock it to prevent further comments.

[*] https://github.com/dessant/repo-lockdown

Suggested-by: Daniel P. Berrangé <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-Id: <address@hidden>
[AJB: s/fill/file/ and point at canonical qemu.org/contribute]
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 040425f849b959ed903610cc028e0996d921f9ca
      
https://github.com/qemu/qemu/commit/040425f849b959ed903610cc028e0996d921f9ca
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M include/hw/elf_ops.h

  Log Message:
  -----------
  elf-ops: bail out if we have no function symbols

It's perfectly possible to have no function symbols in your elf file
and if we do the undefined behaviour sanitizer rightly complains about
us passing NULL to qsort. Check nsyms before we go ahead.

While we are at it lets drop the unchecked return value and cleanup
the fail leg by use of g_autoptr.

Another fix was proposed 101 weeks ago in:
Message-Id: address@hidden

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: bbf5f2a1aa39fcab01000a0f3b566f1e6b788a23
      
https://github.com/qemu/qemu/commit/bbf5f2a1aa39fcab01000a0f3b566f1e6b788a23
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: protect fcntl64 with an #ifdef

Checking TARGET_ABI_BITS is sketchy - we should check for the presence
of the define to be sure. Also clean up the white space while we are
there.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: af7fc47f2c28fe0183ce98aa070e1b899cd08199
      
https://github.com/qemu/qemu/commit/af7fc47f2c28fe0183ce98aa070e1b899cd08199
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M tests/tcg/x86_64/system/boot.S

  Log Message:
  -----------
  tests/tcg: remove extraneous pasting macros

We are not using them and they just get in the way.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: b859040dc44b271e9ad29f729cac71d2389b05fd
      
https://github.com/qemu/qemu/commit/b859040dc44b271e9ad29f729cac71d2389b05fd
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: more debug for init_guest_space

Searching for memory space can cause problems so lets extend the
CPU_LOG_PAGE output so you can watch init_guest_space fail to
allocate memory. A more involved fix is actually required to make this
function play nicely with the large guard pages the sanitiser likes to
use.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 1f089c6705fdb0da1b6def842ecf323b07a4460f
      
https://github.com/qemu/qemu/commit/1f089c6705fdb0da1b6def842ecf323b07a4460f
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M target/xtensa/translate.c

  Log Message:
  -----------
  target/xtensa: add FIXME for translation memory leak

Dynamically allocating a new structure within the DisasContext can
potentially leak as we can longjmp out of the translation loop (see
test_phys_mem). The proper fix would be to use static allocation
within the DisasContext but as the Xtensa translator imports it's code
from elsewhere I leave that as an exercise for the maintainer.

Signed-off-by: Alex Bennée <address@hidden>
Acked-by: Max Filippov <address@hidden>
Message-Id: <address@hidden>


  Commit: 076b2fadb582e4734a879f843885dad38cf91526
      
https://github.com/qemu/qemu/commit/076b2fadb582e4734a879f843885dad38cf91526
  Author: Denis Plotnikov <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M gdbstub.c

  Log Message:
  -----------
  gdbstub: fix compiler complaining

    ./gdbstub.c: In function ‘handle_query_thread_extra’:
        /usr/include/glib-2.0/glib/glib-autocleanups.h:28:10:
    error: ‘cpu_name’ may be used uninitialized in this function
    [-Werror=maybe-uninitialized]
        g_free (*pp);
               ^
    ./gdbstub.c:2063:26: note: ‘cpu_name’ was declared here
        g_autofree char *cpu_name;
                         ^
    cc1: all warnings being treated as errors

Signed-off-by: Denis Plotnikov <address@hidden>
Message-Id: <address@hidden>
Reported-by: Euler Robot <address@hidden>
Reported-by: Chen Qun <address@hidden>
Reviewed-by: Miroslav Rezanina <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: 2f311075b7a74124098effc72290767b02869561
      
https://github.com/qemu/qemu/commit/2f311075b7a74124098effc72290767b02869561
  Author: Richard Henderson <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  -----------
  softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

All other calls to normalize*Subnormal detect zero input before
the call -- this is the only outlier.  This case can happen with
+0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of
the correct sign.

Reported-by: Coverity (CID 1421991)
Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>


  Commit: 01ef6b9e4e4e84b106b7f934354eada8fe36674f
      
https://github.com/qemu/qemu/commit/01ef6b9e4e4e84b106b7f934354eada8fe36674f
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    A include/qemu/selfmap.h
    M linux-user/syscall.c
    M util/Makefile.objs
    A util/selfmap.c

  Log Message:
  -----------
  linux-user: factor out reading of /proc/self/maps

Unfortunately reading /proc/self/maps is still considered the gold
standard for a process finding out about it's own memory layout. As we
will want this data in other contexts soon factor out the code to read
and parse the data. Rather than just blindly copying the existing
sscanf based code we use a more modern glib version of the parsing
code to make a more general purpose map structure.

Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>


  Commit: bb55173cfb7bd69b79c4092bf524a32b0fdeddbb
      
https://github.com/qemu/qemu/commit/bb55173cfb7bd69b79c4092bf524a32b0fdeddbb
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: clean-up padding on /proc/self/maps

Don't use magic spaces, calculate the justification for the file
field like the kernel does with seq_pad.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: 58d5e749d6663701f90931764f8bee6c76b0b1f1
      
https://github.com/qemu/qemu/commit/58d5e749d6663701f90931764f8bee6c76b0b1f1
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M hw/core/loader.c

  Log Message:
  -----------
  hw/core: properly terminate loading .hex on EOF record

The https://makecode.microbit.org/#editor generates slightly weird
.hex files which work fine on a real microbit but causes QEMU to
choke. The reason is extraneous data after the EOF record which causes
the loader to attempt to write a bigger file than it should to the
"rom". According to the HEX file spec an EOF really should be the last
thing we process so lets do that.

Reported-by: Ursula Bennée <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: eca7a8e6c08f80129ae0bab7d060da568ed90f20
      
https://github.com/qemu/qemu/commit/eca7a8e6c08f80129ae0bab7d060da568ed90f20
  Author: Richard Henderson <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Add -Werror to PIE probe

Without -Werror, the probe may succeed, but then compilation fails
later when -Werror is added for other reasons.  Shows up on windows,
where the compiler complains about -fPIC.

Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>


  Commit: cce743abbf398a324879039cd582349b36da0ea6
      
https://github.com/qemu/qemu/commit/cce743abbf398a324879039cd582349b36da0ea6
  Author: Richard Henderson <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M tcg/i386/tcg-target.inc.c

  Log Message:
  -----------
  tcg/i386: Fix %r12 guest_base initialization

When %gs cannot be used, we use register offset addressing.
This path is almost never used, so it was clearly not tested.

Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: e715f7b77ee12588b37ef25701373977d1fb02b9
      
https://github.com/qemu/qemu/commit/e715f7b77ee12588b37ef25701373977d1fb02b9
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    A .github/lockdown.yml
    M MAINTAINERS
    M configure
    M fpu/softfloat.c
    M gdbstub.c
    M hw/core/loader.c
    M include/hw/elf_ops.h
    A include/qemu/selfmap.h
    M linux-user/elfload.c
    M linux-user/syscall.c
    M target/xtensa/translate.c
    M tcg/i386/tcg-target.inc.c
    M tests/tcg/x86_64/system/boot.S
    M util/Makefile.objs
    A util/selfmap.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stsquad/tags/pull-misc-fixes-070420-1' 
into staging

Various fixes:

  - add .github repo lockdown config
  - better handle missing symbols in elf-ops
  - protect fcntl64 with #ifdef
  - remove unused macros from test
  - fix handling of /proc/self/maps
  - avoid BAD_SHIFT in x80 softfloat
  - properly terminate on .hex EOF
  - fix configure probe on windows cross build
  - fix %r12 guest_base initialization

# gpg: Signature made Tue 07 Apr 2020 16:31:14 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) <address@hidden>" 
[full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-misc-fixes-070420-1:
  tcg/i386: Fix %r12 guest_base initialization
  configure: Add -Werror to PIE probe
  hw/core: properly terminate loading .hex on EOF record
  linux-user: clean-up padding on /proc/self/maps
  linux-user: factor out reading of /proc/self/maps
  softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal
  gdbstub: fix compiler complaining
  target/xtensa: add FIXME for translation memory leak
  linux-user: more debug for init_guest_space
  tests/tcg: remove extraneous pasting macros
  linux-user: protect fcntl64 with an #ifdef
  elf-ops: bail out if we have no function symbols
  .github: Enable repo-lockdown bot to refuse GitHub pull requests

Signed-off-by: Peter Maydell <address@hidden>


  Commit: f3bac27cc1e303e1860cc55b9b6889ba39dee587
      
https://github.com/qemu/qemu/commit/f3bac27cc1e303e1860cc55b9b6889ba39dee587
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M VERSION

  Log Message:
  -----------
  Update version for v5.0.0-rc2 release

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/3f1082e5b856...f3bac27cc1e3