qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 1394dc: json: Fix check for unbalanced right


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 1394dc: json: Fix check for unbalanced right curly brace
Date: Tue, 07 Apr 2020 09:45:15 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1394dc0690e7a1514bd6594322d5a2105e881769
      
https://github.com/qemu/qemu/commit/1394dc0690e7a1514bd6594322d5a2105e881769
  Author: Simran Singhal <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M qobject/json-streamer.c

  Log Message:
  -----------
  json: Fix check for unbalanced right curly brace

We immediately diagnose unbalanced right curly brace:

    $ qemu-kvm --nodefaults --nographic --qmp stdio
    {"QMP": {"version": {"qemu": {"micro": 91, "minor": 2, "major": 4},
    "package": "v5.0.0-rc1-1-gf6ce4a439a08"}, "capabilities": ["oob"]}}
    }
    {"error": {"class": "GenericError", "desc": "JSON parse error,
    expecting value"}}

except within square bracket:

    [}

The check for unbalanced braces has a typo.  Fix it.

Fixes: 8d3265b3d00db1071d1d3bf8433b4818088fdeb5
Signed-off-by: Simran Singhal <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <20200402182848.GA3023@simran-Inspiron-5558>
Reviewed-by: Markus Armbruster <address@hidden>
[Commit message rewritten to explain what's broken]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 3f0fb073792180ccb1646d662e2d13260f2dd984
      
https://github.com/qemu/qemu/commit/3f0fb073792180ccb1646d662e2d13260f2dd984
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M qobject/json-streamer.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-04-07' into 
staging

QAPI patches for 2020-04-07

# gpg: Signature made Tue 07 Apr 2020 12:43:38 BST
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Markus Armbruster <address@hidden>" [full]
# gpg:                 aka "Markus Armbruster <address@hidden>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-qapi-2020-04-07:
  json: Fix check for unbalanced right curly brace

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/8f0d25c464a1...3f0fb0737921



reply via email to

[Prev in Thread] Current Thread [Next in Thread]