[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] d1d3a9: scripts/coccinelle: add error-use-aft
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] d1d3a9: scripts/coccinelle: add error-use-after-free.cocci |
Date: |
Mon, 06 Apr 2020 04:45:12 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: d1d3a99795006d81f10c98927b0c2ad270bc78fd
https://github.com/qemu/qemu/commit/d1d3a99795006d81f10c98927b0c2ad270bc78fd
Author: Vladimir Sementsov-Ogievskiy <address@hidden>
Date: 2020-04-04 (Sat, 04 Apr 2020)
Changed paths:
M MAINTAINERS
A scripts/coccinelle/error-use-after-free.cocci
Log Message:
-----------
scripts/coccinelle: add error-use-after-free.cocci
Add script to find and fix trivial use-after-free of Error objects.
How to use:
spatch --sp-file scripts/coccinelle/error-use-after-free.cocci \
--macro-file scripts/cocci-macro-file.h --in-place \
--no-show-diff ( FILES... | --use-gitgrep . )
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Pastos in commit message and comment fixed, globbing in MAINTAINERS
expanded]
Signed-off-by: Markus Armbruster <address@hidden>
Commit: b0e709503cee6e30e62b35ef416a53531371c1a7
https://github.com/qemu/qemu/commit/b0e709503cee6e30e62b35ef416a53531371c1a7
Author: Vladimir Sementsov-Ogievskiy <address@hidden>
Date: 2020-04-04 (Sat, 04 Apr 2020)
Changed paths:
M dump/win_dump.c
Log Message:
-----------
dump/win_dump: fix use after free of err
It's possible that we'll try to set err twice (or more). It's bad, it
will crash.
Instead, use warn_report().
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Commit: 6a4a38530e70f3917a58d71d4d08e28bd8146015
https://github.com/qemu/qemu/commit/6a4a38530e70f3917a58d71d4d08e28bd8146015
Author: Vladimir Sementsov-Ogievskiy <address@hidden>
Date: 2020-04-04 (Sat, 04 Apr 2020)
Changed paths:
M qga/commands-posix.c
Log Message:
-----------
qga/commands-posix: fix use after free of local_err
local_err is used several times in guest_suspend(). Setting non-NULL
local_err will crash, so let's zero it after freeing. Also fix possible
leak of local_err in final if().
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Commit: 547522cd3d2b006d249457f4c06bd82c8c247d1f
https://github.com/qemu/qemu/commit/547522cd3d2b006d249457f4c06bd82c8c247d1f
Author: Peter Maydell <address@hidden>
Date: 2020-04-05 (Sun, 05 Apr 2020)
Changed paths:
M MAINTAINERS
M dump/win_dump.c
M qga/commands-posix.c
A scripts/coccinelle/error-use-after-free.cocci
Log Message:
-----------
Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-04-04' into
staging
Error reporting patches for 2020-04-04
# gpg: Signature made Sat 04 Apr 2020 13:19:40 BST
# gpg: using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg: issuer "address@hidden"
# gpg: Good signature from "Markus Armbruster <address@hidden>" [full]
# gpg: aka "Markus Armbruster <address@hidden>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867 4E5F 3870 B400 EB91 8653
* remotes/armbru/tags/pull-error-2020-04-04:
qga/commands-posix: fix use after free of local_err
dump/win_dump: fix use after free of err
scripts/coccinelle: add error-use-after-free.cocci
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/146aa0f104bb...547522cd3d2b
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] d1d3a9: scripts/coccinelle: add error-use-after-free.cocci,
Peter Maydell <=