qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ee5195: configure: Drop adjustment of textseg

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] ee5195: configure: Drop adjustment of textseg
Date: Tue, 31 Mar 2020 05:30:16 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ee5195ee0fc87858088313f2c6f327ac41f5912f
      
https://github.com/qemu/qemu/commit/ee5195ee0fc87858088313f2c6f327ac41f5912f
  Author: Richard Henderson <address@hidden>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M Makefile
    M configure

  Log Message:
  -----------
  configure: Drop adjustment of textseg

This adjustment was random and unnecessary.  The user mode
startup code in probe_guest_base() will choose a value for
guest_base that allows the host qemu binary to not conflict
with the guest binary.

With modern distributions, this isn't even used, as the default
is PIE, which does the same job in a more portable way.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
v2: Remove mention of config-host.ld from make distclean


  Commit: 64547a3bb6c92781372994e4e9b25a89f6c88074
      
https://github.com/qemu/qemu/commit/64547a3bb6c92781372994e4e9b25a89f6c88074
  Author: Richard Henderson <address@hidden>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M accel/tcg/translate-all.c

  Log Message:
  -----------
  tcg: Remove softmmu code_gen_buffer fixed address

The commentary talks about "in concert with the addresses
assigned in the relevant linker script", except there is no
linker script for softmmu, nor has there been for some time.

(Do not confuse the user-only linker script editing that was
removed in the previous patch, because user-only does not
use this code_gen_buffer allocation method.)

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: d2cd29e30736afd4a1e8cac3cf4da360bbc65978
      
https://github.com/qemu/qemu/commit/d2cd29e30736afd4a1e8cac3cf4da360bbc65978
  Author: Richard Henderson <address@hidden>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Do not force pie=no for non-x86

PIE is supported on many other hosts besides x86.

The default for non-x86 is now the same as x86: pie is used
if supported, and may be forced via --enable/--disable-pie.

The original commit (40d6444e91c) said:

  "Non-x86 are not changed, as they require TCG changes"

but I think that's wrong -- there's nothing about PIE that
affects TCG one way or another.

Tested on aarch64 (bionic) and ppc64le (centos 7) hosts.

Tested-by: Alex Bennée <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: b26341241bbfe9cc126479a0dbed5d40d547f242
      
https://github.com/qemu/qemu/commit/b26341241bbfe9cc126479a0dbed5d40d547f242
  Author: Richard Henderson <address@hidden>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Always detect -no-pie toolchain support

The CFLAGS_NOPIE and LDFLAGS_NOPIE variables are used
in pc-bios/optionrom/Makefile, which has nothing to do
with the PIE setting of the main qemu executables.

This overrides any operating system default to build
all executables as PIE, which is important for ROMs.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: e6cbd75158ea274ab98c13c9b73d2bc1d90aa50d
      
https://github.com/qemu/qemu/commit/e6cbd75158ea274ab98c13c9b73d2bc1d90aa50d
  Author: Richard Henderson <address@hidden>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Unnest detection of -z,relro and -z,now

There is nothing about these options that is related to PIE.
Use them unconditionally.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Fangrui Song <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
v2: Do not split into two tests.
v3: Update to QEMU_LDFLAGS.


  Commit: 2c674109c2da3f2e17b69f39e0b93b3f3d3dfa59
      
https://github.com/qemu/qemu/commit/2c674109c2da3f2e17b69f39e0b93b3f3d3dfa59
  Author: Richard Henderson <address@hidden>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Override the os default with --disable-pie

Some distributions, e.g. Ubuntu 19.10, enable PIE by default.
If for some reason one wishes to build a non-pie binary, we
must provide additional options to override.

At the same time, reorg the code to an elif chain.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
v3: Update for QEMU_LDFLAGS.


  Commit: 127814629b32d5e0de2873d742e08cb9bd412af7
      
https://github.com/qemu/qemu/commit/127814629b32d5e0de2873d742e08cb9bd412af7
  Author: Richard Henderson <address@hidden>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Support -static-pie if requested

Recent toolchains support static and pie at the same time.

As with normal dynamic builds, allow --static to default to PIE
if supported by the toolchain.  Allow --enable/--disable-pie to
override the default.

Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
v2: Fix --disable-pie --static
v3: Update for QEMU_LDFLAGS.


  Commit: 84878f4c00a7beca1d1460e2f77a6c833b8d0393
      
https://github.com/qemu/qemu/commit/84878f4c00a7beca1d1460e2f77a6c833b8d0393
  Author: Jiaxun Yang <address@hidden>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: Fix loongson multimedia condition instructions

Loongson multimedia condition instructions were previously implemented as
write 0 to rd due to lack of documentation. So I just confirmed with Loongson
about their encoding and implemented them correctly.

Signed-off-by: Jiaxun Yang <address@hidden>
Acked-by: Huacai Chen <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: e20cb81d9c5a3d0f9c08f3642728a210a1c162c9
      
https://github.com/qemu/qemu/commit/e20cb81d9c5a3d0f9c08f3642728a210a1c162c9
  Author: Richard Henderson <address@hidden>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    M tcg/i386/tcg-target.inc.c

  Log Message:
  -----------
  tcg/i386: Fix INDEX_op_dup2_vec

We were only constructing the 64-bit element, and not
replicating the 64-bit element across the rest of the vector.

Cc: address@hidden
Signed-off-by: Richard Henderson <address@hidden>


  Commit: b412378785c1bd95e3461c1373dd8938bc54fb4e
      
https://github.com/qemu/qemu/commit/b412378785c1bd95e3461c1373dd8938bc54fb4e
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    M scripts/decodetree.py

  Log Message:
  -----------
  decodetree: Use Python3 floor division operator

This script started using Python2, where the 'classic' division
operator returns the floor result. In commit 3d004a371 we started
to use Python3, where the division operator returns the float
result ('true division').
To keep the same behavior, use the 'floor division' operator "//"
which returns the floor result.

Fixes: 3d004a371
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 2a95551e8b1456aa53ce54fac573df18809340a6
      
https://github.com/qemu/qemu/commit/2a95551e8b1456aa53ce54fac573df18809340a6
  Author: Peter Maydell <address@hidden>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    M Makefile
    M accel/tcg/translate-all.c
    M configure
    M scripts/decodetree.py
    M target/mips/translate.c
    M tcg/i386/tcg-target.inc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20200330' into staging

Improve PIE and other linkage
Fix for decodetree vs Python3 floor division operator
Fix i386 INDEX_op_dup2_vec expansion
Fix loongson multimedia condition instructions

# gpg: Signature made Tue 31 Mar 2020 04:50:15 BST
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Richard Henderson <address@hidden>" [full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-tcg-20200330:
  decodetree: Use Python3 floor division operator
  tcg/i386: Fix INDEX_op_dup2_vec
  target/mips: Fix loongson multimedia condition instructions
  configure: Support -static-pie if requested
  configure: Override the os default with --disable-pie
  configure: Unnest detection of -z,relro and -z,now
  configure: Always detect -no-pie toolchain support
  configure: Do not force pie=no for non-x86
  tcg: Remove softmmu code_gen_buffer fixed address
  configure: Drop adjustment of textseg

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/83019e81d100...2a95551e8b14
reply via email to
[Prev in Thread] Current Thread [Next in Thread]