[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 112c37: ui/input-linux: Do not ignore ioctl()
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] 112c37: ui/input-linux: Do not ignore ioctl() return value |
Date: |
Thu, 26 Mar 2020 02:30:17 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 112c37a6a6e4e0b607fd4514dffe402c69506cf8
https://github.com/qemu/qemu/commit/112c37a6a6e4e0b607fd4514dffe402c69506cf8
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-25 (Wed, 25 Mar 2020)
Changed paths:
M ui/input-linux.c
Log Message:
-----------
ui/input-linux: Do not ignore ioctl() return value
Fix warnings reported by Clang static code analyzer:
CC ui/input-linux.o
ui/input-linux.c:343:9: warning: Value stored to 'rc' is never read
rc = ioctl(il->fd, EVIOCGBIT(EV_REL, sizeof(relmap)), &relmap);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ui/input-linux.c:351:9: warning: Value stored to 'rc' is never read
rc = ioctl(il->fd, EVIOCGBIT(EV_ABS, sizeof(absmap)), &absmap);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ui/input-linux.c:354:13: warning: Value stored to 'rc' is never read
rc = ioctl(il->fd, EVIOCGABS(ABS_X), &absinfo);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ui/input-linux.c:357:13: warning: Value stored to 'rc' is never read
rc = ioctl(il->fd, EVIOCGABS(ABS_Y), &absinfo);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ui/input-linux.c:365:9: warning: Value stored to 'rc' is never read
rc = ioctl(il->fd, EVIOCGBIT(EV_KEY, sizeof(keymap)), keymap);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ui/input-linux.c:366:9: warning: Value stored to 'rc' is never read
rc = ioctl(il->fd, EVIOCGKEY(sizeof(keystate)), keystate);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
Commit: 95fad99cb28e9970944b01fd7af452f6f9f37484
https://github.com/qemu/qemu/commit/95fad99cb28e9970944b01fd7af452f6f9f37484
Author: Volker Rümelin <address@hidden>
Date: 2020-03-25 (Wed, 25 Mar 2020)
Changed paths:
M hw/audio/fmopl.c
Log Message:
-----------
hw/audio/fmopl: fix segmentation fault
Current code allocates the memory for ENV_CURVE too late. Move
allocation to OPLOpenTable() and deallocation to OPLCloseTable().
To reproduce the bug start qemu with -soundhw adlib.
Fixes 2eea51bd01 "hw/audio/fmopl: Move ENV_CURVE to .heap to save
32KiB of .bss"
Signed-off-by: Volker Rümelin <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
Commit: 042abffc5e077a92ee0ca989d9007c23355a2d8e
https://github.com/qemu/qemu/commit/042abffc5e077a92ee0ca989d9007c23355a2d8e
Author: Peter Maydell <address@hidden>
Date: 2020-03-25 (Wed, 25 Mar 2020)
Changed paths:
M hw/audio/fmopl.c
M ui/input-linux.c
Log Message:
-----------
Merge remote-tracking branch
'remotes/kraxel/tags/fixes-20200325-pull-request' into staging
fixes: input error handling & audio segfault
# gpg: Signature made Wed 25 Mar 2020 10:58:26 GMT
# gpg: using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg: aka "Gerd Hoffmann <address@hidden>" [full]
# gpg: aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901 FE7D 4CB6 D8EE D3E8 7138
* remotes/kraxel/tags/fixes-20200325-pull-request:
hw/audio/fmopl: fix segmentation fault
ui/input-linux: Do not ignore ioctl() return value
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/736cf607e406...042abffc5e07
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 112c37: ui/input-linux: Do not ignore ioctl() return value,
Peter Maydell <=