[Qemu-commits] [qemu/qemu] bb1ce4: qga: Installer: Wait for installation to finish

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bb1ce44b15f159b67fafc5f4b285bbf20a1961e9
      
https://github.com/qemu/qemu/commit/bb1ce44b15f159b67fafc5f4b285bbf20a1961e9
  Author: Basil Salman <address@hidden>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M qga/installer/qemu-ga.wxs

  Log Message:
  -----------
  qga: Installer: Wait for installation to finish

Installation might fail if we don't wait for the provider
unregisteration process to finish.

Signed-off-by: Sameeh Jubran <address@hidden>
Signed-off-by: Basil Salman <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: b2413df83348acf371c03bced9a3845bba883ed5
      
https://github.com/qemu/qemu/commit/b2413df83348acf371c03bced9a3845bba883ed5
  Author: Sameeh Jubran <address@hidden>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M qga/vss-win32/install.cpp

  Log Message:
  -----------
  qga-win: Handle VSS_E_PROVIDER_ALREADY_REGISTERED error

This patch handles the case where VSS Provider is already registered,
where in such case qga uninstalls the provider and registers it again.

Signed-off-by: Sameeh Jubran <address@hidden>
Signed-off-by: Basil Salman <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 807e2b6fce022707418bc8f61c069d91c613b3d2
      
https://github.com/qemu/qemu/commit/807e2b6fce022707418bc8f61c069d91c613b3d2
  Author: Basil Salman <address@hidden>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M qga/commands-win32.c

  Log Message:
  -----------
  qga-win: prevent crash when executing guest-file-read with large count

guest-file-read command is currently implemented to read from a
file handle count number of bytes. when executed with a very large count number
qemu-ga crashes.
after some digging turns out that qemu-ga crashes after trying to allocate
a buffer large enough to save the data read in it, the buffer was allocated 
using
g_malloc0 which is not fail safe, and results a crash in case of failure.
g_malloc0 was replaced with g_try_malloc0() which returns NULL on failure,
A check was added for that case in order to prevent qemu-ga from crashing
and to send a response to the qemu-ga client accordingly.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1594054

Signed-off-by: Basil Salman <address@hidden>
Reported-by: Fakhri Zulkifli <address@hidden>
Cc: address@hidden
Signed-off-by: Michael Roth <address@hidden>


  Commit: a23f38a72921fa915536a981a4f8a9134512f120
      
https://github.com/qemu/qemu/commit/a23f38a72921fa915536a981a4f8a9134512f120
  Author: Eric Blake <address@hidden>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M qga/commands.c

  Log Message:
  -----------
  qga: Fix undefined C behavior

The QAPI struct GuestFileWhence has a comment about how we are
exploiting equivalent values between two different integer types
shared in a union. But C says behavior is undefined on assignments to
overlapping storage when the two types are not the same width, and
indeed, 'int64_t value' and 'enum QGASeek name' are very likely to be
different in width.  Utilize a temporary variable to fix things.

Reported-by: Peter Maydell <address@hidden>
Fixes: 0b4b49387
Fixes: Coverity CID 1421990
Signed-off-by: Eric Blake <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 7b46aadbbfb7b06cd45a3b113b1f7c003c68f603
      
https://github.com/qemu/qemu/commit/7b46aadbbfb7b06cd45a3b113b1f7c003c68f603
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M docs/interop/qemu-ga.rst
    M qga/main.c

  Log Message:
  -----------
  qemu-ga: document vsock-listen in the man page

Although qemu-ga has supported vsock since 2016 it was not documented on
the man page.

Also add the socket address representation to the qga --help output.

Fixes: 586ef5dee77180fc32e33bc08051600030630239
       ("qga: add vsock-listen method")
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 9c353b2fc9210e2a891442af98f476ee81901be8
      
https://github.com/qemu/qemu/commit/9c353b2fc9210e2a891442af98f476ee81901be8
  Author: Peter Maydell <address@hidden>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M docs/interop/qemu-ga.rst
    M qga/commands-win32.c
    M qga/commands.c
    M qga/installer/qemu-ga.wxs
    M qga/main.c
    M qga/vss-win32/install.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-03-24-tag0' 
into staging

qemu-ga patch queue for hard-freeze

* fix undefined C behavior with guest-file-* interfaces
* fix w32 installer issues
* fix crash for large file reads via guest-file-read on windows
* add missing man page documentation for virtio-vsock

# gpg: Signature made Tue 24 Mar 2020 16:45:24 GMT
# gpg:                using RSA key CEACC9E15534EBABB82D3FA03353C9CEF108B584
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Michael Roth <address@hidden>" [full]
# gpg:                 aka "Michael Roth <address@hidden>" [full]
# gpg:                 aka "Michael Roth <address@hidden>" [full]
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* remotes/mdroth/tags/qga-pull-2020-03-24-tag0:
  qemu-ga: document vsock-listen in the man page
  qga: Fix undefined C behavior
  qga-win: prevent crash when executing guest-file-read with large count
  qga-win: Handle VSS_E_PROVIDER_ALREADY_REGISTERED error
  qga: Installer: Wait for installation to finish

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/62a43e53faed...9c353b2fc921