qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ff807d: aio-posix: fix io_uring with external


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] ff807d: aio-posix: fix io_uring with external events
Date: Tue, 24 Mar 2020 03:00:23 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ff807d559205a434fd37d3343f01a0ab128bd190
      
https://github.com/qemu/qemu/commit/ff807d559205a434fd37d3343f01a0ab128bd190
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2020-03-23 (Mon, 23 Mar 2020)

  Changed paths:
    M util/fdmon-io_uring.c

  Log Message:
  -----------
  aio-posix: fix io_uring with external events

When external event sources are disabled fdmon-io_uring falls back to
fdmon-poll.  The ->need_wait() callback needs to watch for this so it
can return true when external event sources are disabled.

It is also necessary to call ->wait() when AioHandlers have changed
because io_uring is asynchronous and we must submit new sqes.

Both of these changes to ->need_wait() together fix tests/test-aio -p
/aio/external-client, which failed with:

  test-aio: tests/test-aio.c:404: test_aio_external_client: Assertion 
`aio_poll(ctx, false)' failed.

Reported-by: Julia Suvorova <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: f1e748d27996e0cd8269db837a32e453dd55930a
      
https://github.com/qemu/qemu/commit/f1e748d27996e0cd8269db837a32e453dd55930a
  Author: Peter Maydell <address@hidden>
  Date:   2020-03-23 (Mon, 23 Mar 2020)

  Changed paths:
    M util/fdmon-io_uring.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

Pull request

# gpg: Signature made Mon 23 Mar 2020 19:24:02 GMT
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>" [full]
# gpg:                 aka "Stefan Hajnoczi <address@hidden>" [full]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/block-pull-request:
  aio-posix: fix io_uring with external events

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c532b954d96f...f1e748d27996



reply via email to

[Prev in Thread] Current Thread [Next in Thread]