qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 9bda60: build: Silence clang warning on older

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 9bda60: build: Silence clang warning on older glib autoptr...
Date: Thu, 19 Mar 2020 11:00:17 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9bda600b0833821685e23068e50be5134dc0ab05
      
https://github.com/qemu/qemu/commit/9bda600b0833821685e23068e50be5134dc0ab05
  Author: Eric Blake <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  build: Silence clang warning on older glib autoptr usage

glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static
inline functions, often with some of them unused, but prior to 2.57.2
did not mark the functions as such.  As a result, clang (but not gcc)
fails to build with older glib unless -Wno-unused-function is enabled.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 6a150995d486013221361cddb5ae6189afb0cef5
      
https://github.com/qemu/qemu/commit/6a150995d486013221361cddb5ae6189afb0cef5
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M util/hbitmap.c

  Log Message:
  -----------
  hbitmap: assert that we don't create bitmap larger than INT64_MAX

We have APIs which returns signed int64_t, to be able to return error.
Therefore we can't handle bitmaps with absolute size larger than
(INT64_MAX+1). Still, keep maximum to be INT64_MAX which is a bit
safer.

Note, that bitmaps are used to represent disk images, which can't
exceed INT64_MAX anyway.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: be24c7140cf9212de2a00b855939d049d7cb7554
      
https://github.com/qemu/qemu/commit/be24c7140cf9212de2a00b855939d049d7cb7554
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M include/qemu/hbitmap.h
    M util/hbitmap.c

  Log Message:
  -----------
  hbitmap: move hbitmap_iter_next_word to hbitmap.c

The function is definitely internal (it's not used by third party and
it has complicated interface). Move it to .c file.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 30b8346cc3e1e9d73d55bb442e2b4a670dccd444
      
https://github.com/qemu/qemu/commit/30b8346cc3e1e9d73d55bb442e2b4a670dccd444
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M include/qemu/hbitmap.h
    M util/hbitmap.c

  Log Message:
  -----------
  hbitmap: unpublish hbitmap_iter_skip_words

Function is internal and even commented as internal. Drop its
definition from .h file.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 0c88f1970c769289fa49361bc3f00b5fba9d5d0e
      
https://github.com/qemu/qemu/commit/0c88f1970c769289fa49361bc3f00b5fba9d5d0e
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M include/qemu/hbitmap.h
    M tests/test-hbitmap.c
    M util/hbitmap.c

  Log Message:
  -----------
  hbitmap: drop meta bitmaps as they are unused

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 642700fda029ed6b4051db7eab8f704131217643
      
https://github.com/qemu/qemu/commit/642700fda029ed6b4051db7eab8f704131217643
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M block/dirty-bitmap.c
    M include/block/dirty-bitmap.h
    M include/qemu/hbitmap.h
    M nbd/server.c
    M tests/test-hbitmap.c
    M util/hbitmap.c

  Log Message:
  -----------
  block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t

We are going to introduce bdrv_dirty_bitmap_next_dirty so that same
variable may be used to store its return value and to be its parameter,
so it would int64_t.

Similarly, we are going to refactor hbitmap_next_dirty_area to use
hbitmap_next_dirty together with hbitmap_next_zero, therefore we want
hbitmap_next_zero parameter type to be int64_t too.

So, for convenience update all parameters of *_next_zero and
*_next_dirty_area to be int64_t.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 9399c54b7557a20bc78aaecf2d51983cfafbbf41
      
https://github.com/qemu/qemu/commit/9399c54b7557a20bc78aaecf2d51983cfafbbf41
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M block/dirty-bitmap.c
    M include/block/dirty-bitmap.h
    M include/qemu/hbitmap.h
    M tests/test-hbitmap.c
    M util/hbitmap.c

  Log Message:
  -----------
  block/dirty-bitmap: add _next_dirty API

We have bdrv_dirty_bitmap_next_zero, let's add corresponding
bdrv_dirty_bitmap_next_dirty, which is more comfortable to use than
bitmap iterators in some cases.

For test modify test_hbitmap_next_zero_check_range to check both
next_zero and next_dirty and add some new checks.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 299ea9ff01a8452dd14a042d700d8651370f5314
      
https://github.com/qemu/qemu/commit/299ea9ff01a8452dd14a042d700d8651370f5314
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M block/dirty-bitmap.c
    M include/block/dirty-bitmap.h
    M include/qemu/hbitmap.h
    M tests/test-hbitmap.c
    M util/hbitmap.c

  Log Message:
  -----------
  block/dirty-bitmap: improve _next_dirty_area API

Firstly, _next_dirty_area is for scenarios when we may contiguously
search for next dirty area inside some limited region, so it is more
comfortable to specify "end" which should not be recalculated on each
iteration.

Secondly, let's add a possibility to limit resulting area size, not
limiting searching area. This will be used in NBD code in further
commit. (Note that now bdrv_dirty_bitmap_next_dirty_area is unused)

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 89cbc7e30860fda2e1b86fca471ade33c9c68aa7
      
https://github.com/qemu/qemu/commit/89cbc7e30860fda2e1b86fca471ade33c9c68aa7
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd/server: introduce NBDExtentArray

Introduce NBDExtentArray class, to handle extents list creation in more
controlled way and with fewer OUT parameters in functions.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: dacbb6eb8acbd40d97c1c01cde5ccc55e56e7785
      
https://github.com/qemu/qemu/commit/dacbb6eb8acbd40d97c1c01cde5ccc55e56e7785
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M nbd/server.c

  Log Message:
  -----------
  nbd/server: use bdrv_dirty_bitmap_next_dirty_area

Use bdrv_dirty_bitmap_next_dirty_area for bitmap_to_extents. Since
bdrv_dirty_bitmap_next_dirty_area is very accurate in its interface,
we'll never exceed requested region with last chunk. So, we don't need
dont_fragment, and bitmap_to_extents() interface becomes clean enough
to not require any comment.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 2d00cbd8e222a4adc08f415c399e84590ee8ff9a
      
https://github.com/qemu/qemu/commit/2d00cbd8e222a4adc08f415c399e84590ee8ff9a
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M block/qcow2-bitmap.c

  Log Message:
  -----------
  block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty

store_bitmap_data() loop does bdrv_set_dirty_iter() on each iteration,
which means that we actually don't need iterator itself and we can use
simpler bitmap API.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: e6d567db23219fe9979f16d74e13f27145f07f84
      
https://github.com/qemu/qemu/commit/e6d567db23219fe9979f16d74e13f27145f07f84
  Author: Peter Maydell <address@hidden>
  Date:   2020-03-19 (Thu, 19 Mar 2020)

  Changed paths:
    M block/dirty-bitmap.c
    M block/qcow2-bitmap.c
    M configure
    M include/block/dirty-bitmap.h
    M include/qemu/hbitmap.h
    M nbd/server.c
    M tests/test-hbitmap.c
    M util/hbitmap.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into 
staging

Pull request

# gpg: Signature made Wed 18 Mar 2020 20:23:28 GMT
# gpg:                using RSA key F9B7ABDBBCACDF95BE76CBD07DEF8106AAFC390E
# gpg: Good signature from "John Snow (John Huston) <address@hidden>" [full]
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* remotes/jnsnow/tags/bitmaps-pull-request:
  block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty
  nbd/server: use bdrv_dirty_bitmap_next_dirty_area
  nbd/server: introduce NBDExtentArray
  block/dirty-bitmap: improve _next_dirty_area API
  block/dirty-bitmap: add _next_dirty API
  block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t
  hbitmap: drop meta bitmaps as they are unused
  hbitmap: unpublish hbitmap_iter_skip_words
  hbitmap: move hbitmap_iter_next_word to hbitmap.c
  hbitmap: assert that we don't create bitmap larger than INT64_MAX
  build: Silence clang warning on older glib autoptr usage

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4dd6517e3698...e6d567db2321
reply via email to
[Prev in Thread] Current Thread [Next in Thread]