[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] a0cf42: dp8393x: Mask EOL bit from descriptor
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] a0cf42: dp8393x: Mask EOL bit from descriptor addresses, t... |
Date: |
Mon, 09 Mar 2020 09:45:13 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: a0cf4297d6b8d88047ab00c467f14aecf9c2a8eb
https://github.com/qemu/qemu/commit/a0cf4297d6b8d88047ab00c467f14aecf9c2a8eb
Author: Finn Thain <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/net/dp8393x.c
Log Message:
-----------
dp8393x: Mask EOL bit from descriptor addresses, take 2
A portion of a recent patch got lost due to a merge snafu. That patch is
now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses").
This patch restores the portion that got lost.
Signed-off-by: Finn Thain <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <alpine.LNX.2.22.394.2003041421280.12@nippy.intranet>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: bab694faedf17c2ea95d6c739b0792ec52d64cb9
https://github.com/qemu/qemu/commit/bab694faedf17c2ea95d6c739b0792ec52d64cb9
Author: Eric Blake <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M scripts/git.orderfile
Log Message:
-----------
maint: Include top-level *.rst files early in git diff
We are converting more doc files to *.rst rather than *.texi. Most
doc files are already listed early in diffs due to our catchall
docs/*, but a few top-level files get missed by that glob.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 1a28f878b50f55cd5965dfb61d1e5e8009a59197
https://github.com/qemu/qemu/commit/1a28f878b50f55cd5965dfb61d1e5e8009a59197
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M Makefile
M rules.mak
Log Message:
-----------
build-sys: Move the print-variable rule to rules.mak
Currently the print-variable rule can only be used in the
root directory:
$ make print-vhost-user-json-y
vhost-user-json-y= contrib/vhost-user-gpu/50-qemu-gpu.json
tools/virtiofsd/50-qemu-virtiofsd.json
$ make -C i386-softmmu print-obj-y
make: Entering directory 'build/i386-softmmu'
make: *** No rule to make target 'print-obj-y'. Stop.
make: Leaving directory 'build/i386-softmmu'
Move it to rules.mak so we can use it from other directories:
$ make -C i386-softmmu print-obj-y
make: Entering directory 'build/i386-softmmu'
obj-y=qapi-introspect.o qapi-types-machine-target.o qapi-types-misc-target.o
qapi-types.o qapi-visit-machine-target.o qapi-visit-misc-target.o qapi-visit.o
qapi-events-machine-target.o qapi-events-misc-target.o qapi-events.o
qapi-commands-machine-target.o qapi-commands-misc-target.o qapi-commands.o
qapi-init-commands.o
make: Leaving directory 'build/i386-softmmu'
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 02f7a1644dd140d0036de054cafa62b90bcff9a4
https://github.com/qemu/qemu/commit/02f7a1644dd140d0036de054cafa62b90bcff9a4
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/audio/fmopl.c
Log Message:
-----------
hw/audio/fmopl: Fix a typo twice
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 3b6b3a279ad3c32903b0c0fdf3cacf24b02541f2
https://github.com/qemu/qemu/commit/3b6b3a279ad3c32903b0c0fdf3cacf24b02541f2
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/net/e1000.c
M hw/net/e1000e_core.c
Log Message:
-----------
hw/net/e1000: Add readops/writeops typedefs
Express the macreg[] arrays using typedefs.
No logical changes introduced here.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Reviewed-by: Dmitry Fleytman <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: da5cf9a4fef1e04608501605b4697f39ea56e0ea
https://github.com/qemu/qemu/commit/da5cf9a4fef1e04608501605b4697f39ea56e0ea
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/net/e1000.c
M hw/net/e1000e_core.c
Log Message:
-----------
hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
Each array consumes 256KiB of .data. As we do not reassign entries,
we can move it to the .rodata section, and save a total of 1MiB of
.data (size reported on x86_64 host).
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Reviewed-by: Dmitry Fleytman <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: b8ccfadc1f95b73766bf1ff33ea3549e37bd7c92
https://github.com/qemu/qemu/commit/b8ccfadc1f95b73766bf1ff33ea3549e37bd7c92
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M fsdev/virtfs-proxy-helper.c
Log Message:
-----------
virtfs-proxy-helper: Make the helper_opts[] array const
Reduce a bit the memory footprint by making the helper_opts[]
array const.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Greg Kurz <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: fe48442fd6bb57614049ad08d2cf3fcf7a2e46bb
https://github.com/qemu/qemu/commit/fe48442fd6bb57614049ad08d2cf3fcf7a2e46bb
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M softmmu/vl.c
Log Message:
-----------
vl: Add missing "hw/boards.h" include
vl.c calls machine_usb() declared in "hw/boards.h". Include it.
This fixes (when modifying unrelated headers):
vl.c:1283:10: error: implicit declaration of function 'machine_usb' is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (!machine_usb(current_machine)) {
^
vl.c:1283:10: error: this function declaration is not a prototype
[-Werror,-Wstrict-prototypes]
vl.c:1283:22: error: use of undeclared identifier 'current_machine'
if (!machine_usb(current_machine)) {
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: a1c4a3de2ecbd89b3643da51a59f3d80a0c0e73f
https://github.com/qemu/qemu/commit/a1c4a3de2ecbd89b3643da51a59f3d80a0c0e73f
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/acpi/ich9.c
M hw/isa/lpc_ich9.c
M include/hw/i386/ich9.h
Log Message:
-----------
hw/southbridge/ich9: Removed unused headers
The ICH9 chipset is not X86/PC specific.
These files don't use anything declared by the "hw/i386/pc.h"
or "hw/i386/ioapic.h" headers. Remove them.
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 1b5c0b5dc642927116be2f52f88be2ccf3474d9e
https://github.com/qemu/qemu/commit/1b5c0b5dc642927116be2f52f88be2ccf3474d9e
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M include/hw/i386/ioapic_internal.h
Log Message:
-----------
hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
The "ioapic_internal.h" does not use anything from
"hw/i386/ioapic.h", remove it.
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 4e24b59a3d80870e23e7e6e6812d2774a46f0ff5
https://github.com/qemu/qemu/commit/4e24b59a3d80870e23e7e6e6812d2774a46f0ff5
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/rtc/twl92230.c
M hw/timer/hpet.c
Log Message:
-----------
hw/timer: Remove unused "ui/console.h" header
The timer models don't need anything from "ui/console.h".
Remove it.
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: d797c3013463c0e89eb05038e156275255797441
https://github.com/qemu/qemu/commit/d797c3013463c0e89eb05038e156275255797441
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/usb/dev-storage.c
Log Message:
-----------
hw/usb/dev-storage: Remove unused "ui/console.h" header
The USB models related to storage don't need anything from
"ui/console.h". Remove it.
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 2479300674249ff4a2d08709e28bf5f6482da030
https://github.com/qemu/qemu/commit/2479300674249ff4a2d08709e28bf5f6482da030
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M include/hw/i386/intel_iommu.h
Log Message:
-----------
hw/i386/intel_iommu: Remove unused includes
intel_iommu.h does not use any of these includes, remove them.
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 540818bbb491cb1a5f46bcda7409827594109fad
https://github.com/qemu/qemu/commit/540818bbb491cb1a5f46bcda7409827594109fad
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/alpha/alpha_sys.h
Log Message:
-----------
hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
alpha_sys.h does not use anything from the "hw/ide.h" header.
Remove it.
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: b58337ffee04cc62b66c6117285f2ea404658ed3
https://github.com/qemu/qemu/commit/b58337ffee04cc62b66c6117285f2ea404658ed3
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/alpha/dp264.c
Log Message:
-----------
hw/alpha/dp264: Include "net/net.h"
hw/alpha/dp264.c uses NICInfo variables which are declared in
"net/net.h". Include it.
This fixes (when modifying unrelated headers):
hw/alpha/dp264.c:89:21: error: use of undeclared identifier 'nb_nics'
for (i = 0; i < nb_nics; i++) {
^
hw/alpha/dp264.c:90:30: error: use of undeclared identifier 'nd_table'
pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL);
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: e07c4f44b0d5c80577cb00421a5370d2dbbcfa6b
https://github.com/qemu/qemu/commit/e07c4f44b0d5c80577cb00421a5370d2dbbcfa6b
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/hppa/machine.c
Log Message:
-----------
hw/hppa/machine: Include "net/net.h"
hw/hppa/machine.c uses NICInfo variables which are declared in
"net/net.h". Include it.
This fixes (when modifying unrelated headers):
hw/hppa/machine.c:126:21: error: use of undeclared identifier 'nb_nics'
for (i = 0; i < nb_nics; i++) {
^
hw/hppa/machine.c:127:30: error: use of undeclared identifier 'nd_table'
pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL);
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 38e131d2e2fa6e9b17782d7ce96e7207fa276562
https://github.com/qemu/qemu/commit/38e131d2e2fa6e9b17782d7ce96e7207fa276562
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/acpi/cpu_hotplug.c
Log Message:
-----------
hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
hw/acpi/cpu_hotplug.c calls pci_address_space_io(). Include
"hw/pci/pci.h" which declares it.
This fixes (when modifying unrelated headers):
hw/acpi/cpu_hotplug.c:103:28: error: implicit declaration of function
'pci_address_space_io' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
MemoryRegion *parent = pci_address_space_io(PCI_DEVICE(gpe_cpu->device));
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 858be92357ec195978b7ccb599fa8067f4b91849
https://github.com/qemu/qemu/commit/858be92357ec195978b7ccb599fa8067f4b91849
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/timer/hpet.c
Log Message:
-----------
hw/timer/hpet: Include "exec/address-spaces.h"
hw/timer/hpet.c calls address_space_stl_le() declared in
"exec/address-spaces.h". Include it.
This fixes (when modifying unrelated headers):
hw/timer/hpet.c:210:31: error: use of undeclared identifier
'address_space_memory'
address_space_stl_le(&address_space_memory, timer->fsb >> 32,
^~~~~~~~~~~~~~~~~~~~
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 577aa4895a138782d426be592aa3c41ecf28a2c2
https://github.com/qemu/qemu/commit/577aa4895a138782d426be592aa3c41ecf28a2c2
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M include/hw/pci-host/q35.h
Log Message:
-----------
hw/pci-host/q35: Include "qemu/range.h"
The MCHPCIState structure uses the Range type which is declared in
"qemu/range.h". Include it.
This fixes (when modifying unrelated headers):
In file included from hw/pci-host/q35.c:32:
include/hw/pci-host/q35.h:57:11: error: field has incomplete type 'Range'
(aka 'struct Range')
Range pci_hole;
^
include/qemu/typedefs.h:116:16: note: forward declaration of 'struct Range'
typedef struct Range Range;
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 5588a58ce2eccc946f1227f3acae97cb28c0013d
https://github.com/qemu/qemu/commit/5588a58ce2eccc946f1227f3acae97cb28c0013d
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/i2c/smbus_ich9.c
Log Message:
-----------
hw/i2c/smbus_ich9: Include "qemu/range.h"
hw/i2c/smbus_ich9.c calls range_covers_byte(). Include "qemu/range.h"
which declares it.
This fixes (when modifying unrelated headers):
hw/i2c/smbus_ich9.c:66:9: error: implicit declaration of function
'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (range_covers_byte(address, len, ICH9_SMB_HOSTC)) {
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 9a5711613527a4dd7b57289bbbb8892b69d328b5
https://github.com/qemu/qemu/commit/9a5711613527a4dd7b57289bbbb8892b69d328b5
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/pci-host/i440fx.c
Log Message:
-----------
hw/pci-host/piix: Include "qemu/range.h"
hw/pci-host/piix.c calls various functions from the Range API.
Include "qemu/range.h" which declares them.
This fixes (when modifying unrelated headers):
hw/pci-host/i440fx.c:54:11: error: field has incomplete type 'Range' (aka
'struct Range')
Range pci_hole;
^
include/qemu/typedefs.h:116:16: note: forward declaration of 'struct Range'
typedef struct Range Range;
^
hw/pci-host/i440fx.c:126:9: error: implicit declaration of function
'ranges_overlap' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (ranges_overlap(address, len, I440FX_PAM, I440FX_PAM_SIZE) ||
^
hw/pci-host/i440fx.c:126:9: error: this function declaration is not a
prototype [-Werror,-Wstrict-prototypes]
hw/pci-host/i440fx.c:127:9: error: implicit declaration of function
'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
range_covers_byte(address, len, I440FX_SMRAM)) {
^
hw/pci-host/i440fx.c:127:9: error: this function declaration is not a
prototype [-Werror,-Wstrict-prototypes]
hw/pci-host/i440fx.c:189:13: error: implicit declaration of function
'range_is_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
val64 = range_is_empty(&s->pci_hole) ? 0 : range_lob(&s->pci_hole);
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 132a908bc4fd12f4d6d24661eff44b927450c8e7
https://github.com/qemu/qemu/commit/132a908bc4fd12f4d6d24661eff44b927450c8e7
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/acpi/ich9.c
M hw/acpi/piix4.c
Log Message:
-----------
hw/acpi: Include "hw/mem/nvdimm.h"
Both ich9.c and piix4.c use methods/definitions declared in the
NVDIMM device header. Include it.
This fixes (when modifying unrelated headers):
hw/acpi/ich9.c:507:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/acpi/ich9.c:508:13: error: implicit declaration of function
'nvdimm_acpi_plug_cb' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_acpi_plug_cb(hotplug_dev, dev);
^
hw/acpi/piix4.c:403:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/acpi/piix4.c:404:13: error: implicit declaration of function
'nvdimm_acpi_plug_cb' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_acpi_plug_cb(hotplug_dev, dev);
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 4b997690c60ba21135323d2db54a03495232acd6
https://github.com/qemu/qemu/commit/4b997690c60ba21135323d2db54a03495232acd6
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/i386/acpi-build.c
M hw/i386/pc.c
M hw/i386/pc_piix.c
M hw/i386/pc_q35.c
Log Message:
-----------
hw/i386: Include "hw/mem/nvdimm.h"
All this files use methods/definitions declared in the NVDIMM
device header. Include it.
This fixes (when modifying unrelated headers):
hw/i386/acpi-build.c:2733:9: error: implicit declaration of function
'nvdimm_build_acpi' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_build_acpi(table_offsets, tables_blob, tables->linker,
^
hw/i386/pc.c:1996:61: error: use of undeclared identifier 'TYPE_NVDIMM'
const bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM);
^
hw/i386/pc.c:2032:55: error: use of undeclared identifier 'TYPE_NVDIMM'
bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM);
^
hw/i386/pc.c:2040:9: error: implicit declaration of function 'nvdimm_plug' is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_plug(ms->nvdimms_state);
^
hw/i386/pc.c:2040:9: error: this function declaration is not a prototype
[-Werror,-Wstrict-prototypes]
nvdimm_plug(ms->nvdimms_state);
^
hw/i386/pc.c:2065:42: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/i386/pc_i440fx.c:307:9: error: implicit declaration of function
'nvdimm_init_acpi_state' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_init_acpi_state(machine->nvdimms_state, system_io,
^
hw/i386/pc_q35.c:332:9: error: implicit declaration of function
'nvdimm_init_acpi_state' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_init_acpi_state(machine->nvdimms_state, system_io,
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 71adf91a82ac3a34dbbbfc77ae9f06764bbb8553
https://github.com/qemu/qemu/commit/71adf91a82ac3a34dbbbfc77ae9f06764bbb8553
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/pci-host/q35.c
M include/hw/pci-host/q35.h
Log Message:
-----------
hw/pci-host/q35: Remove unused includes
Only q35.c requires declarations from "hw/i386/pc.h", move it there.
Remove all the includes not used by "q35.h".
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: fe8ce968c13ab58f42068eb0a7d557b1d209cd8d
https://github.com/qemu/qemu/commit/fe8ce968c13ab58f42068eb0a7d557b1d209cd8d
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M include/hw/i386/pc.h
Log Message:
-----------
hw/i386/pc: Clean up includes
Various headers are not required by hw/i386/pc.h:
- "qemu/range.h"
- "qemu/bitmap.h"
- "qemu/module.h"
- "exec/memory.h"
- "hw/pci/pci.h"
- "hw/mem/pc-dimm.h"
- "hw/mem/nvdimm.h"
- "net/net.h"
Remove them.
Add 3 headers that were missing:
- "hw/hotplug.h"
PCMachineState::acpi_dev is of type HotplugHandler
- "qemu/notify.h"
PCMachineState::machine_done is of type Notifier
- "qapi/qapi-types-common.h"
PCMachineState::vmport/smm is of type OnOffAuto
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 2244f2335ea8f3b92cbecbb123dc392570b06e6c
https://github.com/qemu/qemu/commit/2244f2335ea8f3b92cbecbb123dc392570b06e6c
Author: Pan Nengyuan <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/core/qdev.c
Log Message:
-----------
core/qdev: fix memleak in qdev_get_gpio_out_connector()
Fix a memory leak in qdev_get_gpio_out_connector().
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 35c9453592944c46bc4f8cd273b9ed54362a50e5
https://github.com/qemu/qemu/commit/35c9453592944c46bc4f8cd273b9ed54362a50e5
Author: Chen Qun <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M block/stream.c
Log Message:
-----------
block/stream: Remove redundant statement in stream_run()
Clang static code analyzer show warning:
block/stream.c:186:9: warning: Value stored to 'ret' is never read
ret = 0;
^ ~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 76e91cda07d783c4dca50df3cd87156bd14b692c
https://github.com/qemu/qemu/commit/76e91cda07d783c4dca50df3cd87156bd14b692c
Author: Chen Qun <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M block/file-posix.c
Log Message:
-----------
block/file-posix: Remove redundant statement in raw_handle_perm_lock()
Clang static code analyzer show warning:
block/file-posix.c:891:9: warning: Value stored to 'op' is never read
op = RAW_PL_ABORT;
^ ~~~~~~~~~~~~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 780c7dad17374592d202098b083376c70342356e
https://github.com/qemu/qemu/commit/780c7dad17374592d202098b083376c70342356e
Author: Chen Qun <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/dma/xlnx-zdma.c
Log Message:
-----------
dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
Clang static code analyzer show warning:
hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Francisco Iglesias <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 88492745a50372f81d4af7fd35aca26b41603776
https://github.com/qemu/qemu/commit/88492745a50372f81d4af7fd35aca26b41603776
Author: Chen Qun <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/scsi/scsi-disk.c
Log Message:
-----------
scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command()
Clang static code analyzer show warning:
scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read
buflen = req->cmd.xfer;
^ ~~~~~~~~~~~~~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 4e34d82eee9233d2b210391365b4b84ad78284cd
https://github.com/qemu/qemu/commit/4e34d82eee9233d2b210391365b4b84ad78284cd
Author: Chen Qun <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/display/pxa2xx_lcd.c
Log Message:
-----------
display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse()
Clang static code analyzer show warning:
hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read
format = 0;
^ ~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 488a0ddae2de036af902f98b5b1a0c2dc0bd90b5
https://github.com/qemu/qemu/commit/488a0ddae2de036af902f98b5b1a0c2dc0bd90b5
Author: Chen Qun <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M hw/display/exynos4210_fimd.c
Log Message:
-----------
display/exynos4210_fimd: Remove redundant statement in
exynos4210_fimd_update()
Clang static code analyzer show warning:
hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is
never read
is_dirty = false;
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 916c92503bd5348a33e561db600d8894bde636bb
https://github.com/qemu/qemu/commit/916c92503bd5348a33e561db600d8894bde636bb
Author: Chen Qun <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M monitor/hmp-cmds.c
Log Message:
-----------
monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups()
Clang static code analyzer show warning:
monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
set = true;
^ ~~~~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Commit: 06db86c8e72bbd87ed321338fce863d6240e0658
https://github.com/qemu/qemu/commit/06db86c8e72bbd87ed321338fce863d6240e0658
Author: Peter Maydell <address@hidden>
Date: 2020-03-09 (Mon, 09 Mar 2020)
Changed paths:
M Makefile
M block/file-posix.c
M block/stream.c
M fsdev/virtfs-proxy-helper.c
M hw/acpi/cpu_hotplug.c
M hw/acpi/ich9.c
M hw/acpi/piix4.c
M hw/alpha/alpha_sys.h
M hw/alpha/dp264.c
M hw/audio/fmopl.c
M hw/core/qdev.c
M hw/display/exynos4210_fimd.c
M hw/display/pxa2xx_lcd.c
M hw/dma/xlnx-zdma.c
M hw/hppa/machine.c
M hw/i2c/smbus_ich9.c
M hw/i386/acpi-build.c
M hw/i386/pc.c
M hw/i386/pc_piix.c
M hw/i386/pc_q35.c
M hw/isa/lpc_ich9.c
M hw/net/dp8393x.c
M hw/net/e1000.c
M hw/net/e1000e_core.c
M hw/pci-host/i440fx.c
M hw/pci-host/q35.c
M hw/rtc/twl92230.c
M hw/scsi/scsi-disk.c
M hw/timer/hpet.c
M hw/usb/dev-storage.c
M include/hw/i386/ich9.h
M include/hw/i386/intel_iommu.h
M include/hw/i386/ioapic_internal.h
M include/hw/i386/pc.h
M include/hw/pci-host/q35.h
M monitor/hmp-cmds.c
M rules.mak
M scripts/git.orderfile
M softmmu/vl.c
Log Message:
-----------
Merge remote-tracking branch
'remotes/vivier2/tags/trivial-branch-pull-request' into staging
- includes cleanup
- reduce .data footprint
- fix warnings reported by Clang static code analyzer
- fix dp8393x part lost in merge
- update git.orderfile and rules.mak
# gpg: Signature made Mon 09 Mar 2020 15:07:47 GMT
# gpg: using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg: issuer "address@hidden"
# gpg: Good signature from "Laurent Vivier <address@hidden>" [full]
# gpg: aka "Laurent Vivier <address@hidden>" [full]
# gpg: aka "Laurent Vivier (Red Hat) <address@hidden>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F 5173 F30C 38BD 3F2F BE3C
* remotes/vivier2/tags/trivial-branch-pull-request: (33 commits)
monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups()
display/exynos4210_fimd: Remove redundant statement in
exynos4210_fimd_update()
display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse()
scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command()
dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
block/file-posix: Remove redundant statement in raw_handle_perm_lock()
block/stream: Remove redundant statement in stream_run()
core/qdev: fix memleak in qdev_get_gpio_out_connector()
hw/i386/pc: Clean up includes
hw/pci-host/q35: Remove unused includes
hw/i386: Include "hw/mem/nvdimm.h"
hw/acpi: Include "hw/mem/nvdimm.h"
hw/pci-host/piix: Include "qemu/range.h"
hw/i2c/smbus_ich9: Include "qemu/range.h"
hw/pci-host/q35: Include "qemu/range.h"
hw/timer/hpet: Include "exec/address-spaces.h"
hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
hw/hppa/machine: Include "net/net.h"
hw/alpha/dp264: Include "net/net.h"
hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
...
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/dee65a00d1e6...06db86c8e72b
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] a0cf42: dp8393x: Mask EOL bit from descriptor addresses, t...,
Peter Maydell <=