[Qemu-commits] [qemu/qemu] cd8fef: Arithmetic error in EDID generation fixed

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cd8fef8d4b2dfeadc68ffb4d741ab23e9e13dad1
      
https://github.com/qemu/qemu/commit/cd8fef8d4b2dfeadc68ffb4d741ab23e9e13dad1
  Author: Anton V. Boyarshinov <address@hidden>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M hw/display/edid-generate.c

  Log Message:
  -----------
  Arithmetic error in EDID generation fixed

To calculate screen size in centimeters we should calculate:
pixels/dpi*2.54
but not
pixels*dpi/2540

Using wrong formula we actually get 65 DPI and very small fonts.

Signed-off-by: Anton V. Boyarshinov <address@hidden>
Message-id: 20200226122054.366b9cda@table.localdomain
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 44b5c1ebfa5db337714180e9d4a8d525da5595d6
      
https://github.com/qemu/qemu/commit/44b5c1ebfa5db337714180e9d4a8d525da5595d6
  Author: Gerd Hoffmann <address@hidden>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  qxl: map rom r/o

Map qxl rom read-only into the guest, so the guest can't tamper with the
content.  qxl has a shadow copy of the rom to deal with that, but the
shadow doesn't cover the mode list.  A privilidged user in the guest can
manipulate the mode list and that to trick qemu into oob reads, leading
to a DoS via segfault if that read access happens to hit unmapped memory.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden


  Commit: c81acb643a61db199b9198add7972d8a8496b27c
      
https://github.com/qemu/qemu/commit/c81acb643a61db199b9198add7972d8a8496b27c
  Author: Peter Maydell <address@hidden>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M hw/display/edid-generate.c
    M hw/display/qxl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200302-pull-request' 
into staging

vga: bugfixes for qxl and edid generator.

# gpg: Signature made Mon 02 Mar 2020 09:16:28 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/vga-20200302-pull-request:
  qxl: map rom r/o
  Arithmetic error in EDID generation fixed

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/9f1750ed6891...c81acb643a61