qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 96eef0: multifd: Add multifd-compression para


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 96eef0: multifd: Add multifd-compression parameter
Date: Fri, 28 Feb 2020 08:15:14 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 96eef04238f4bef63cc2beeef804701f9b60ea7d
      
https://github.com/qemu/qemu/commit/96eef04238f4bef63cc2beeef804701f9b60ea7d
  Author: Juan Quintela <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M hw/core/qdev-properties.c
    M include/hw/qdev-properties.h
    M migration/migration.c
    M monitor/hmp-cmds.c
    M qapi/migration.json
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  multifd: Add multifd-compression parameter

This will store the compression method to use.  We start with none.

Signed-off-by: Juan Quintela <address@hidden>
Acked-by: Markus Armbruster <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>

---

Rename multifd-method to multifd-compression


  Commit: a2d07731e7e2f1462e90f9d0a7eaf9e39da29eb0
      
https://github.com/qemu/qemu/commit/a2d07731e7e2f1462e90f9d0a7eaf9e39da29eb0
  Author: Juan Quintela <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M include/qemu/module.h
    M softmmu/vl.c

  Log Message:
  -----------
  migration: Add support for modules

So we don't have to compile everything in, or have ifdefs

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: ab7cbb0b9a3b229025cae3d132504cbb9f25170f
      
https://github.com/qemu/qemu/commit/ab7cbb0b9a3b229025cae3d132504cbb9f25170f
  Author: Juan Quintela <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/migration.c
    M migration/migration.h
    M migration/multifd.c
    M migration/multifd.h
    M migration/ram.c

  Log Message:
  -----------
  multifd: Make no compression operations into its own structure

It will be used later.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>

---

No comp value needs to be zero.


  Commit: 9004db48c080632aef2329c1ac154c448d7da276
      
https://github.com/qemu/qemu/commit/9004db48c080632aef2329c1ac154c448d7da276
  Author: Juan Quintela <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/migration.c
    M migration/migration.h
    M monitor/hmp-cmds.c
    M qapi/migration.json

  Log Message:
  -----------
  multifd: Add multifd-zlib-level parameter

This parameter specifies the zlib compression level. The next patch
will put it to use.

Signed-off-by: Juan Quintela <address@hidden>
Acked-by: Markus Armbruster <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 7ec2c2b3c1bc0c713b349b102413468b07336aab
      
https://github.com/qemu/qemu/commit/7ec2c2b3c1bc0c713b349b102413468b07336aab
  Author: Juan Quintela <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M hw/core/qdev-properties.c
    M migration/Makefile.objs
    A migration/multifd-zlib.c
    M migration/multifd.c
    M migration/multifd.h
    M qapi/migration.json
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  multifd: Add zlib compression multifd support

Signed-off-by: Juan Quintela <address@hidden>
Acked-by: Markus Armbruster <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 3a67848134d0c07da49033f9ed08bf0ddeec0c6d
      
https://github.com/qemu/qemu/commit/3a67848134d0c07da49033f9ed08bf0ddeec0c6d
  Author: Juan Quintela <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M .gitlab-ci.yml
    M .travis.yml
    M configure
    M tests/docker/dockerfiles/centos7.docker
    M tests/docker/dockerfiles/fedora-i386-cross.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/ubuntu.docker
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/vm/fedora
    M tests/vm/freebsd
    M tests/vm/netbsd
    M tests/vm/openbsd

  Log Message:
  -----------
  configure: Enable test and libs for zstd

Add it to several build systems to make testing good.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 6a9ad1542065ca0bd54c6fe756c5eac3e093dfb5
      
https://github.com/qemu/qemu/commit/6a9ad1542065ca0bd54c6fe756c5eac3e093dfb5
  Author: Juan Quintela <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/migration.c
    M migration/migration.h
    M monitor/hmp-cmds.c
    M qapi/migration.json

  Log Message:
  -----------
  multifd: Add multifd-zstd-level parameter

This parameter specifies the zstd compression level. The next patch
will put it to use.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Acked-by: Markus Armbruster <address@hidden>


  Commit: 87dc6f5f665f581923536a1346220c7dcebe5105
      
https://github.com/qemu/qemu/commit/87dc6f5f665f581923536a1346220c7dcebe5105
  Author: Juan Quintela <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M hw/core/qdev-properties.c
    M migration/Makefile.objs
    A migration/multifd-zstd.c
    M migration/multifd.h
    M migration/ram.c
    M qapi/migration.json
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  multifd: Add zstd compression multifd support

Signed-off-by: Juan Quintela <address@hidden>
Acked-by: Markus Armbruster <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 600fe89d6e627a18a01f4b7aef15d84efdb81548
      
https://github.com/qemu/qemu/commit/600fe89d6e627a18a01f4b7aef15d84efdb81548
  Author: Chen Qun <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/vmstate.c

  Log Message:
  -----------
  migration/vmstate: Remove redundant statement in vmstate_save_state_v()

The "ret" has been assigned in all branches. It didn't need to be
 assigned separately.

Clang static code analyzer show warning:
  migration/vmstate.c:365:17: warning: Value stored to 'ret' is never read
                ret = 0;
                ^     ~

Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: a6fbd637557a850fa22a5527c896d990c4b4d60f
      
https://github.com/qemu/qemu/commit/a6fbd637557a850fa22a5527c896d990c4b4d60f
  Author: Chen Qun <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M tests/test-vmstate.c

  Log Message:
  -----------
  test-vmstate: Fix memleaks in test_load_qlist

There is memleak in test_load_qlist().It's not a big deal,
but test-vmstate will fail if sanitizers is enabled.

In addition, "ret" is written twice with the same value
 in test_gtree_load_iommu().

Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 26daeba4d6ad272f3372c02a4762cf565438042e
      
https://github.com/qemu/qemu/commit/26daeba4d6ad272f3372c02a4762cf565438042e
  Author: Pan Nengyuan <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  migration/savevm: release gslist after dump_vmstate_json

'list' forgot to free at the end of dump_vmstate_json_to_file(), although it's 
called only once, but seems like a clean code.

Fix the leak as follow:
Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x7fb946abd768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768)
    #1 0x7fb945eca445 in g_malloc (/lib64/libglib-2.0.so.0+0x52445)
    #2 0x7fb945ee2066 in g_slice_alloc (/lib64/libglib-2.0.so.0+0x6a066)
    #3 0x7fb945ee3139 in g_slist_prepend (/lib64/libglib-2.0.so.0+0x6b139)
    #4 0x5585db591581 in object_class_get_list_tramp 
/mnt/sdb/qemu-new/qemu/qom/object.c:1084
    #5 0x5585db590f66 in object_class_foreach_tramp 
/mnt/sdb/qemu-new/qemu/qom/object.c:1028
    #6 0x7fb945eb35f7 in g_hash_table_foreach (/lib64/libglib-2.0.so.0+0x3b5f7)
    #7 0x5585db59110c in object_class_foreach 
/mnt/sdb/qemu-new/qemu/qom/object.c:1038
    #8 0x5585db5916b6 in object_class_get_list 
/mnt/sdb/qemu-new/qemu/qom/object.c:1092
    #9 0x5585db335ca0 in dump_vmstate_json_to_file 
/mnt/sdb/qemu-new/qemu/migration/savevm.c:638
    #10 0x5585daa5bcbf in main /mnt/sdb/qemu-new/qemu/vl.c:4420
    #11 0x7fb941204812 in __libc_start_main ../csu/libc-start.c:308
    #12 0x5585da29420d in _start 
(/mnt/sdb/qemu-new/qemu/build/x86_64-softmmu/qemu-system-x86_64+0x27f020d)

Indirect leak of 7472 byte(s) in 467 object(s) allocated from:
    #0 0x7fb946abd768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768)
    #1 0x7fb945eca445 in g_malloc (/lib64/libglib-2.0.so.0+0x52445)
    #2 0x7fb945ee2066 in g_slice_alloc (/lib64/libglib-2.0.so.0+0x6a066)
    #3 0x7fb945ee3139 in g_slist_prepend (/lib64/libglib-2.0.so.0+0x6b139)
    #4 0x5585db591581 in object_class_get_list_tramp 
/mnt/sdb/qemu-new/qemu/qom/object.c:1084
    #5 0x5585db590f66 in object_class_foreach_tramp 
/mnt/sdb/qemu-new/qemu/qom/object.c:1028
    #6 0x7fb945eb35f7 in g_hash_table_foreach (/lib64/libglib-2.0.so.0+0x3b5f7)
    #7 0x5585db59110c in object_class_foreach 
/mnt/sdb/qemu-new/qemu/qom/object.c:1038
    #8 0x5585db5916b6 in object_class_get_list 
/mnt/sdb/qemu-new/qemu/qom/object.c:1092
    #9 0x5585db335ca0 in dump_vmstate_json_to_file 
/mnt/sdb/qemu-new/qemu/migration/savevm.c:638
    #10 0x5585daa5bcbf in main /mnt/sdb/qemu-new/qemu/vl.c:4420
    #11 0x7fb941204812 in __libc_start_main ../csu/libc-start.c:308
    #12 0x5585da29420d in _start 
(/mnt/sdb/qemu-new/qemu/build/x86_64-softmmu/qemu-system-x86_64+0x27f020d)

Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: a152bd00932a819af0f2ca3199e071e431fa93cb
      
https://github.com/qemu/qemu/commit/a152bd00932a819af0f2ca3199e071e431fa93cb
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/block.c

  Log Message:
  -----------
  migration/block: rename BLOCK_SIZE macro

Both <linux/fs.h> and <sys/mount.h> define BLOCK_SIZE macros.  Avoiding
using that name in block/migration.c.

I noticed this when including <liburing.h> (Linux io_uring) from
"block/aio.h" and compilation failed.  Although patches adding that
include haven't been sent yet, it makes sense to rename the macro now in
case someone else stumbles on it in the meantime.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 0306dae5ac47dfbcc1b166b9e2deb13fc4d5a011
      
https://github.com/qemu/qemu/commit/0306dae5ac47dfbcc1b166b9e2deb13fc4d5a011
  Author: zhanghailiang <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: fix COLO broken caused by a previous commit

This commit "migration: Create migration_is_running()" broke
COLO. Becuase there is a process broken by this commit.

colo_process_checkpoint
 ->colo_do_checkpoint_transaction
   ->migrate_set_block_enabled
     ->qmp_migrate_set_capabilities

It can be fixed by make COLO process as an exception,
Maybe we need a better way to fix it.

Cc: Juan Quintela <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 6ad8ad38d0404ee286f713e8d1f4bc2aad7eaec1
      
https://github.com/qemu/qemu/commit/6ad8ad38d0404ee286f713e8d1f4bc2aad7eaec1
  Author: zhanghailiang <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/colo.c

  Log Message:
  -----------
  migration/colo: wrap incoming checkpoint process into new helper

Split checkpoint incoming process into a helper.

Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: f51d0b4178738bba87d796eba7444f6cdb3aa0fd
      
https://github.com/qemu/qemu/commit/f51d0b4178738bba87d796eba7444f6cdb3aa0fd
  Author: zhanghailiang <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  savevm: Don't call colo_init_ram_cache twice

This helper has been called twice which is wrong.
Left the one where called while get COLO enable message
from source side.

Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: e27d5b488ef08408691bfed61f34ee2858136287
      
https://github.com/qemu/qemu/commit/e27d5b488ef08408691bfed61f34ee2858136287
  Author: Peter Maydell <address@hidden>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M .gitlab-ci.yml
    M .travis.yml
    M configure
    M hw/core/qdev-properties.c
    M include/hw/qdev-properties.h
    M include/qemu/module.h
    M migration/Makefile.objs
    M migration/block.c
    M migration/colo.c
    M migration/migration.c
    M migration/migration.h
    A migration/multifd-zlib.c
    A migration/multifd-zstd.c
    M migration/multifd.c
    M migration/multifd.h
    M migration/ram.c
    M migration/savevm.c
    M migration/vmstate.c
    M monitor/hmp-cmds.c
    M qapi/migration.json
    M softmmu/vl.c
    M tests/docker/dockerfiles/centos7.docker
    M tests/docker/dockerfiles/fedora-i386-cross.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/ubuntu.docker
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/qtest/migration-test.c
    M tests/test-vmstate.c
    M tests/vm/fedora
    M tests/vm/freebsd
    M tests/vm/netbsd
    M tests/vm/openbsd

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/juanquintela/tags/pull-migration-pull-request' into staging

Migration pull request

# gpg: Signature made Fri 28 Feb 2020 09:21:31 GMT
# gpg:                using RSA key 1899FF8EDEBF58CCEE034B82F487EF185872D723
# gpg: Good signature from "Juan Quintela <address@hidden>" [full]
# gpg:                 aka "Juan Quintela <address@hidden>" [full]
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* remotes/juanquintela/tags/pull-migration-pull-request:
  savevm: Don't call colo_init_ram_cache twice
  migration/colo: wrap incoming checkpoint process into new helper
  migration: fix COLO broken caused by a previous commit
  migration/block: rename BLOCK_SIZE macro
  migration/savevm: release gslist after dump_vmstate_json
  test-vmstate: Fix memleaks in test_load_qlist
  migration/vmstate: Remove redundant statement in vmstate_save_state_v()
  multifd: Add zstd compression multifd support
  multifd: Add multifd-zstd-level parameter
  configure: Enable test and libs for zstd
  multifd: Add zlib compression multifd support
  multifd: Add multifd-zlib-level parameter
  multifd: Make no compression operations into its own structure
  migration: Add support for modules
  multifd: Add multifd-compression parameter

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c12d4b60be78...e27d5b488ef0



reply via email to

[Prev in Thread] Current Thread [Next in Thread]