[Qemu-commits] [qemu/qemu] f2887b: tests/tcg: include a skip runner for pauth3 with p...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f2887ba33606b9dc98f451c7f0e89dba37cef94c
      
https://github.com/qemu/qemu/commit/f2887ba33606b9dc98f451c7f0e89dba37cef94c
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/tcg/aarch64/Makefile.softmmu-target

  Log Message:
  -----------
  tests/tcg: include a skip runner for pauth3 with plugins

If we have plugins enabled we still need to have built the test to be
able to run it.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Robert Foley <address@hidden>
Message-Id: <address@hidden>


  Commit: 804c96848b18458e05d64a5fdda8ced29c2470a9
      
https://github.com/qemu/qemu/commit/804c96848b18458e05d64a5fdda8ced29c2470a9
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/rcutorture.c

  Log Message:
  -----------
  tests/rcutorture: update usage hint

Although documented in the comments we don't display all the various
invocations we can in the usage.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: ea70ccff651d10625cb051521d7ac029874008c3
      
https://github.com/qemu/qemu/commit/ea70ccff651d10625cb051521d7ac029874008c3
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/rcutorture.c

  Log Message:
  -----------
  tests/rcutorture: better document locking of stats

This is pure code motion with no functional effect.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: a74c82c8dc73560d856dfabd22a6abb40ac907dc
      
https://github.com/qemu/qemu/commit/a74c82c8dc73560d856dfabd22a6abb40ac907dc
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/rcutorture.c

  Log Message:
  -----------
  tests/rcutorture: mild documenting refactor of update thread

This is mainly to help with reasoning what the test is trying to do.
We can move rcu_stress_idx to a local variable as there is only ever
one updater thread. I've also added an assert to catch the case where
we end up updating the current structure to itself which is the only
way I can see the mberror cases we are seeing on Travis.

We shall see if the rcutorture test failures go away now.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>

Message-Id: <address@hidden>


  Commit: 31c8cc4f94e33571df3ac7427359e40a6e95d0f3
      
https://github.com/qemu/qemu/commit/31c8cc4f94e33571df3ac7427359e40a6e95d0f3
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: Test the s390-ccw build, too

Since we can now use a s390x host on Travis, we can also build and
test the s390-ccw bios images there. For this we have to make sure
that roms/SLOF is checked out, too, and then move the generated *.img
files to the right location before running the tests.

Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>


  Commit: 321e6ea5772f8c6140e3c5242540c97604a9730c
      
https://github.com/qemu/qemu/commit/321e6ea5772f8c6140e3c5242540c97604a9730c
  Author: Wainer dos Santos Moschetta <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: Fix Travis YAML configuration warnings

This fixes the following warnings Travis has detected on the
YAML configuration:

- 'on root: missing os, using the default "linux"'
- 'on root: the key matrix is an alias for jobs, using jobs'
- 'on jobs.include.python: unexpected sequence, using the first value (3.5)'
- 'on jobs.include.python: unexpected sequence, using the first value (3.6)'

Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>


  Commit: c9331e9c28184decb22ad8d66375bec03b988c7b
      
https://github.com/qemu/qemu/commit/c9331e9c28184decb22ad8d66375bec03b988c7b
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: single-thread build-tcg stages

This still seems to be a problem for Travis.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: 002375895c10df40615fc615e2639f49e0c442fe
      
https://github.com/qemu/qemu/commit/002375895c10df40615fc615e2639f49e0c442fe
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/qemu-iotests/214

  Log Message:
  -----------
  tests/iotests: be a little more forgiving on the size test

At least on ZFS this was failing as 512 was less than or equal to 512.
I suspect the reason is additional compression done by ZFS and however
qemu-img gets the actual size.

Loosen the criteria to make sure after is not bigger than before and
also dump the values in the report.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Robert Foley <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: 3d88754e2b096ace0f9c2e86dbbb84de4290d421
      
https://github.com/qemu/qemu/commit/3d88754e2b096ace0f9c2e86dbbb84de4290d421
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M trace/control.c

  Log Message:
  -----------
  tracing: only allow -trace to override -D if set

Otherwise any -D settings the user may have made get ignored.

Signed-off-by: Alex Bennée <address@hidden>
Tested-by: Laurent Vivier <address@hidden>
Reviewed-by: Robert Foley <address@hidden>
Message-Id: <address@hidden>


  Commit: 9675a9c6e85398f370aed0157cb50426e8351c55
      
https://github.com/qemu/qemu/commit/9675a9c6e85398f370aed0157cb50426e8351c55
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M docs/devel/tcg-plugins.rst

  Log Message:
  -----------
  docs/devel: document query handle lifetimes

I forgot to document the lifetime of handles in the developer
documentation. Do so now.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Robert Foley <address@hidden>
Reviewed-by: Robert Foley <address@hidden>
Message-Id: <address@hidden>


  Commit: dcc474c69e6a59044b9bb54624bd636cbfd98aa9
      
https://github.com/qemu/qemu/commit/dcc474c69e6a59044b9bb54624bd636cbfd98aa9
  Author: Emilio G. Cota <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M plugins/core.c

  Log Message:
  -----------
  plugins/core: add missing break in cb_to_tcg_flags

Fixes: 54cb65d8588
Reported-by: Robert Henry <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Cc: address@hidden
Message-Id: <address@hidden>


  Commit: 413368611039ce435e74fd0ce1b677ccc08a380e
      
https://github.com/qemu/qemu/commit/413368611039ce435e74fd0ce1b677ccc08a380e
  Author: Chen Qun <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/plugin/bb.c
    M tests/plugin/insn.c

  Log Message:
  -----------
  tests/plugin: prevent uninitialized warning

According to the glibc function requirements, we need initialise
 the variable. Otherwise there will be compilation warnings:

glib-autocleanups.h:28:3: warning: ‘out’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
   g_free (*pp);
   ^~~~~~~~~~~~

Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
[AJB: uses Thomas's single line allocation]
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: ed04c8b14c8bed6b8d940547ed237d309fca7dfc
      
https://github.com/qemu/qemu/commit/ed04c8b14c8bed6b8d940547ed237d309fca7dfc
  Author: Yoshinori Sato <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M include/qemu/bitops.h

  Log Message:
  -----------
  qemu/bitops.h: Add extract8 and extract16

Signed-off-by: Yoshinori Sato <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>


  Commit: 25139bf7f87a0d0e758d4198579a227ab551802a
      
https://github.com/qemu/qemu/commit/25139bf7f87a0d0e758d4198579a227ab551802a
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M target/riscv/instmap.h
    M target/riscv/translate.c

  Log Message:
  -----------
  target/riscv: progressively load the instruction during decode

The plugin system would throw up a harmless warning when it detected
that a disassembly of an instruction didn't use all it's bytes. Fix
the riscv decoder to only load the instruction bytes it needs as it
needs them.

This drops opcode from the ctx in favour if passing the appropriately
sized opcode down a few levels of the decode.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Robert Foley <address@hidden>

Message-Id: <address@hidden>


  Commit: ec11c4a8ec7e858ec328772910def6e2fca9079a
      
https://github.com/qemu/qemu/commit/ec11c4a8ec7e858ec328772910def6e2fca9079a
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/plugin/howvec.c

  Log Message:
  -----------
  tests/plugins: make howvec clean-up after itself.

TCG plugins are responsible for their own memory usage and although
the plugin_exit is tied to the end of execution in this case it is
still poor practice. Ensure we delete the hash table and related data
when we are done to be a good plugin citizen.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Robert Foley <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>

Message-Id: <address@hidden>


  Commit: a0dafafebaefadc1eb883c124830b22d64ad0f8a
      
https://github.com/qemu/qemu/commit/a0dafafebaefadc1eb883c124830b22d64ad0f8a
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/tcg/Makefile.target

  Log Message:
  -----------
  tests/tcg: give debug builds a little bit longer

When combined with heavy plugins we occasionally hit the timeouts.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: fcc54ab5c7ca84ae72e8bf3781c33c9193a911aa
      
https://github.com/qemu/qemu/commit/fcc54ab5c7ca84ae72e8bf3781c33c9193a911aa
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tcg/tcg-op.c

  Log Message:
  -----------
  tcg: save vaddr temp for plugin usage

While do_gen_mem_cb does copy (via extu_tl_i64) vaddr into a new temp
this won't help if the vaddr temp gets clobbered by the actual
load/store op. To avoid this clobbering we explicitly copy vaddr
before the op to ensure it is live my the time we do the
instrumentation.

Suggested-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Emilio G. Cota <address@hidden>
Cc: address@hidden
Message-Id: <address@hidden>


  Commit: a62f849dc5410b649781355a2635cd2956817c74
      
https://github.com/qemu/qemu/commit/a62f849dc5410b649781355a2635cd2956817c74
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/tcg/configure.sh

  Log Message:
  -----------
  tests/tcg: fix typo in configure.sh test for v8.3

Although most people use the docker images this can trip up on
developer systems with actual valid cross-compilers!

Fixes: bb516dfc5b3
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: bc97f9f64f8a4a84d0d06949749e9dbec143b9f5
      
https://github.com/qemu/qemu/commit/bc97f9f64f8a4a84d0d06949749e9dbec143b9f5
  Author: Alex Bennée <address@hidden>
  Date:   2020-02-25 (Tue, 25 Feb 2020)

  Changed paths:
    M tests/tcg/aarch64/pauth-4.c

  Log Message:
  -----------
  tests/tcg: take into account expected clashes pauth-4

Pointer authentication isn't perfect so measure the percentage of
failed checks. As we want to vary the pointer we work through a bunch
of different addresses.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Robert Foley <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: 8b6269c8ec14b9213dd22200c1c05aaecd6cbb9d
      
https://github.com/qemu/qemu/commit/8b6269c8ec14b9213dd22200c1c05aaecd6cbb9d
  Author: Peter Maydell <address@hidden>
  Date:   2020-02-27 (Thu, 27 Feb 2020)

  Changed paths:
    M .travis.yml
    M docs/devel/tcg-plugins.rst
    M include/qemu/bitops.h
    M plugins/core.c
    M target/riscv/instmap.h
    M target/riscv/translate.c
    M tcg/tcg-op.c
    M tests/plugin/bb.c
    M tests/plugin/howvec.c
    M tests/plugin/insn.c
    M tests/qemu-iotests/214
    M tests/rcutorture.c
    M tests/tcg/Makefile.target
    M tests/tcg/aarch64/Makefile.softmmu-target
    M tests/tcg/aarch64/pauth-4.c
    M tests/tcg/configure.sh
    M trace/control.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-testing-and-plugins-250220-1' into staging

Testing and plugin updates:

 - fix pauth TCG tests
 - tweak away rcutorture failures
 - various Travis updates
 - relax iotest size check a little
 - fix for -trace/-D clash
 - fix cross compile detection for tcg tests
 - document plugin query lifetime
 - fix missing break in plugin core
 - fix some plugin warnings
 - better progressive instruction decode
 - avoid trampling vaddr in plugins

# gpg: Signature made Tue 25 Feb 2020 20:21:56 GMT
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) <address@hidden>" 
[full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-testing-and-plugins-250220-1:
  tests/tcg: take into account expected clashes pauth-4
  tests/tcg: fix typo in configure.sh test for v8.3
  tcg: save vaddr temp for plugin usage
  tests/tcg: give debug builds a little bit longer
  tests/plugins: make howvec clean-up after itself.
  target/riscv: progressively load the instruction during decode
  qemu/bitops.h: Add extract8 and extract16
  tests/plugin: prevent uninitialized warning
  plugins/core: add missing break in cb_to_tcg_flags
  docs/devel: document query handle lifetimes
  tracing: only allow -trace to override -D if set
  tests/iotests: be a little more forgiving on the size test
  travis.yml: single-thread build-tcg stages
  travis.yml: Fix Travis YAML configuration warnings
  travis.yml: Test the s390-ccw build, too
  tests/rcutorture: mild documenting refactor of update thread
  tests/rcutorture: better document locking of stats
  tests/rcutorture: update usage hint
  tests/tcg: include a skip runner for pauth3 with plugins

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2a7b18a3205b...8b6269c8ec14