[Qemu-commits] [qemu/qemu] 24f7ee: test-logging: Fix -Werror=maybe-uninitialized warning

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 24f7eeed9ad7f90975c2da44425d15b8f0837120
      
https://github.com/qemu/qemu/commit/24f7eeed9ad7f90975c2da44425d15b8f0837120
  Author: Miroslav Rezanina <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M tests/test-logging.c

  Log Message:
  -----------
  test-logging: Fix -Werror=maybe-uninitialized warning

Checking for uninitialized variables raises warning for file path
variables in test_logfile_write and test_logfile_lock functions.

To suppress this warning, initialize varibles to NULL. This is safe
change as result of g_build_filename is stored to them before any usage.

Signed-off-by: Miroslav Rezanina <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Robert Foley <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 4eb387267ee7604239be2fbd45e5cb34de93d6d8
      
https://github.com/qemu/qemu/commit/4eb387267ee7604239be2fbd45e5cb34de93d6d8
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M tests/Makefile.include
    M tests/qtest/Makefile.include

  Log Message:
  -----------
  tests/vhost-user-bridge: Fix build

vhost-user-bridge isn't actually a test, it's just a helper
(that should probably move somewhere else) - but the build was
broken in the qtest move.

Fixes: 833884f37adc9f125fa2
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 316082b119d7b9f62753c3d245de911f2a33fb79
      
https://github.com/qemu/qemu/commit/316082b119d7b9f62753c3d245de911f2a33fb79
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M docs/devel/testing.rst

  Log Message:
  -----------
  docs/devel: Fix qtest paths and info about check-block in testing.rst

The qtests have recently been moved to a separate subdirectory, so
the paths that are mentioned in the documentation have to be adjusted
accordingly. And some of the iotests are now always run as part of
"make check", so this information has to be adjusted here, too.

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: ab00cf4d73150822f24ca6cf762595a8c0cda452
      
https://github.com/qemu/qemu/commit/ab00cf4d73150822f24ca6cf762595a8c0cda452
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests/Makefile: Fix inclusion of the qos dependency files

The qos dependency files can be found under tests/qtest/libqos and
not under tests/qtest/qos.

Fixes: 1cf4323ecd0 ("Move the libqos files under tests/qtest/")
Message-Id: <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 77c24259b635c2c858e2b5ae61363843c4d88560
      
https://github.com/qemu/qemu/commit/77c24259b635c2c858e2b5ae61363843c4d88560
  Author: Pan Nengyuan <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M tests/qtest/boot-order-test.c
    M tests/qtest/libqos/fw_cfg.h

  Log Message:
  -----------
  boot-order-test: fix memleaks in boot-order-test

It's not a big deal, but 'check qtest-ppc/ppc64' runs fail if sanitizers is 
enabled.
The memory leak stack is as follow:

Direct leak of 128 byte(s) in 4 object(s) allocated from:
    #0 0x7f11756f5970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970)
    #1 0x7f1174f2549d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d)
    #2 0x556af05aa7da in mm_fw_cfg_init /mnt/sdb/qemu/tests/libqos/fw_cfg.c:119
    #3 0x556af059f4f5 in read_boot_order_pmac 
/mnt/sdb/qemu/tests/boot-order-test.c:137
    #4 0x556af059efe2 in test_a_boot_order 
/mnt/sdb/qemu/tests/boot-order-test.c:47
    #5 0x556af059f2c0 in test_boot_orders 
/mnt/sdb/qemu/tests/boot-order-test.c:59
    #6 0x556af059f52d in test_pmac_oldworld_boot_order 
/mnt/sdb/qemu/tests/boot-order-test.c:152
    #7 0x7f1174f46cb9  (/lib64/libglib-2.0.so.0+0x73cb9)
    #8 0x7f1174f46b73  (/lib64/libglib-2.0.so.0+0x73b73)
    #9 0x7f1174f46b73  (/lib64/libglib-2.0.so.0+0x73b73)
    #10 0x7f1174f46f71 in g_test_run_suite (/lib64/libglib-2.0.so.0+0x73f71)
    #11 0x7f1174f46f94 in g_test_run (/lib64/libglib-2.0.so.0+0x73f94)

Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: c66e8ab0e3af8fb163a7de8fa2df2dd69858a894
      
https://github.com/qemu/qemu/commit/c66e8ab0e3af8fb163a7de8fa2df2dd69858a894
  Author: Heyi Guo <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M tests/qtest/bios-tables-test.c

  Log Message:
  -----------
  tests/qtest: update comments about bios-tables-test-allowed-diff.h

Update comments in tests/qtest/bios-tables-test.c to reflect the
current path of bios-tables-test-allowed-diff.h, which is now under
tests/qtest/ as well.

Signed-off-by: Heyi Guo <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: c7cf4ddb8068d83d6da1a626590ca67ba4c508ad
      
https://github.com/qemu/qemu/commit/c7cf4ddb8068d83d6da1a626590ca67ba4c508ad
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Refresh the list of iotests

iotest 147 and 205 have recently been marked as "NBD-only", so they
are currently simply skipped and thus can be removed.

iotest 129 occasionally fails in the gitlab-CI, and according to Max,
there are some known issues with this test (see for example this URL:
https://lists.nongnu.org/archive/html/qemu-block/2019-06/msg00499.html ),
so for the time being, let's disable it until the problems are fixed.

The iotests 040, 127, 203 and 256 are scheduled to become part of "make
check-block", so we also do not have to test them seperately here anymore.

On the other side, new iotests have been added to the QEMU repository
in the past months, so we can now add some new test > 256 instead.

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 432b119be4a5d0902d71869f2a29c3c01d60eb45
      
https://github.com/qemu/qemu/commit/432b119be4a5d0902d71869f2a29c3c01d60eb45
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M include/sysemu/sysemu.h

  Log Message:
  -----------
  include/sysemu/sysemu.h: Remove usused variable no_quit

The no_quit variable has been removed in commit 78782712a62d56 ("vl: drop
no_quit variable"), so let's remove the extern declaration in the header
now, too.

Fixes: 78782712a62d ("vl: drop no_quit variable")
Message-Id: <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: d9018fbbd68bf3a8338828ee3038341518c74212
      
https://github.com/qemu/qemu/commit/d9018fbbd68bf3a8338828ee3038341518c74212
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M hw/xenpv/xen_machine_pv.c
    M include/sysemu/sysemu.h

  Log Message:
  -----------
  trivial: Remove xenfb_enabled from sysemu.h

The define is only used in one other place. Move the code there
instead of keeping this xen-specific define in sysemu.h.

Message-Id: <address@hidden>
Acked-by: Paul Durrant <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 3ab5a6ece5ce40a144b6838737f13a413651c5b1
      
https://github.com/qemu/qemu/commit/3ab5a6ece5ce40a144b6838737f13a413651c5b1
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M hw/adc/Makefile.objs
    M hw/block/Makefile.objs
    M hw/char/Makefile.objs
    M hw/core/Makefile.objs
    M hw/display/Makefile.objs
    M hw/dma/Makefile.objs
    M hw/gpio/Makefile.objs
    M hw/i2c/Makefile.objs
    M hw/i2c/ppc4xx_i2c.c
    M hw/input/Makefile.objs
    M hw/net/Makefile.objs
    M hw/nvram/Makefile.objs
    M hw/pcmcia/Makefile.objs
    M hw/sd/Makefile.objs
    M hw/ssi/Makefile.objs
    M hw/usb/Makefile.objs

  Log Message:
  -----------
  hw/*/Makefile.objs: Move many .o files to common-objs

We have many files that apparently do not depend on the target CPU
configuration, i.e. which can be put into common-obj-y instead of
obj-y. This way, the code can be shared for example between
qemu-system-arm and qemu-system-aarch64, or the various big and
little endian variants like qemu-system-sh4 and qemu-system-sh4eb,
so that we do not have to compile the code multiple times anymore.

Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: ea763fd23334ee5f11e19c7cd1ae75bcab8dc15c
      
https://github.com/qemu/qemu/commit/ea763fd23334ee5f11e19c7cd1ae75bcab8dc15c
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  Makefile: Do not use wildcard hw/*/Kconfig as input for minikconf

The hw/*/Kconfig files should be sourced from hw/Kconfig, so there
is no need to pass them along as input files to minikconfig. We should
use the hw/*/Kconfig wildcard only for build dependencies in the Makefile.

With this change, there are now no duplicate entries in the generated
*-softmmu/config-devices.mak.d files anymore, and there is finally a
chance to get rid of stale Kconfig files like hw/bt/Kconfig, too (once
they do not show up in the config-devices.mak.d files now anymore).

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 10ebc0a8fde078c51d7340d194aa45d58f076f5b
      
https://github.com/qemu/qemu/commit/10ebc0a8fde078c51d7340d194aa45d58f076f5b
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M hw/input/Kconfig
    M hw/isa/Kconfig

  Log Message:
  -----------
  hw/input: Do not enable CONFIG_PCKBD by default

The i8042 PS/2 Controller should not be enabled by default. It has
to be selected by machines or chipsets (e.g. SuperIO chipsets).

Message-Id: <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 9154cf688bbc721a9a38197537fa821f6291b91f
      
https://github.com/qemu/qemu/commit/9154cf688bbc721a9a38197537fa821f6291b91f
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M hw/hppa/Kconfig

  Log Message:
  -----------
  hw/hppa/Kconfig: LASI chipset requires PARALLEL port

The PARISC Lasi chipset emulation requires some of the common parallel
support and fails to build on a --without-default-devices:

    LINK    hppa-softmmu/qemu-system-hppa
  /usr/bin/ld: hw/hppa/lasi.o: in function `lasi_init':
  hw/hppa/lasi.c:324: undefined reference to `parallel_mm_init'
  collect2: error: ld returned 1 exit status
  make[1]: *** [Makefile:206: qemu-system-hppa] Error 1

Fixes: 376b851909d
Reported-by: Alex Bennée <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Acked-by: Helge Deller <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 4f67366e3bbe6040998be038156486eed264ea58
      
https://github.com/qemu/qemu/commit/4f67366e3bbe6040998be038156486eed264ea58
  Author: Thomas Huth <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Fix typo of the have_afalg variable

The variable is called 'have_afalg' and not 'hava_afalg'.

Fixes: f0d92b56d88 ('introduce some common functions for af_alg backend')
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Longpeng(Mike) <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 7bd9d0a9e26c7a3c67c0f174f0009ba19969b158
      
https://github.com/qemu/qemu/commit/7bd9d0a9e26c7a3c67c0f174f0009ba19969b158
  Author: Peter Maydell <address@hidden>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M .gitlab-ci.yml
    M Makefile
    M configure
    M docs/devel/testing.rst
    M hw/adc/Makefile.objs
    M hw/block/Makefile.objs
    M hw/char/Makefile.objs
    M hw/core/Makefile.objs
    M hw/display/Makefile.objs
    M hw/dma/Makefile.objs
    M hw/gpio/Makefile.objs
    M hw/hppa/Kconfig
    M hw/i2c/Makefile.objs
    M hw/i2c/ppc4xx_i2c.c
    M hw/input/Kconfig
    M hw/input/Makefile.objs
    M hw/isa/Kconfig
    M hw/net/Makefile.objs
    M hw/nvram/Makefile.objs
    M hw/pcmcia/Makefile.objs
    M hw/sd/Makefile.objs
    M hw/ssi/Makefile.objs
    M hw/usb/Makefile.objs
    M hw/xenpv/xen_machine_pv.c
    M include/sysemu/sysemu.h
    M tests/Makefile.include
    M tests/qtest/Makefile.include
    M tests/qtest/bios-tables-test.c
    M tests/qtest/boot-order-test.c
    M tests/qtest/libqos/fw_cfg.h
    M tests/test-logging.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2020-02-04' into staging

* Current qtests queue
* Some Kconfig updates
* Some trivial clean-ups here and there

# gpg: Signature made Tue 04 Feb 2020 08:43:28 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2020-02-04:
  configure: Fix typo of the have_afalg variable
  hw/hppa/Kconfig: LASI chipset requires PARALLEL port
  hw/input: Do not enable CONFIG_PCKBD by default
  Makefile: Do not use wildcard hw/*/Kconfig as input for minikconf
  hw/*/Makefile.objs: Move many .o files to common-objs
  trivial: Remove xenfb_enabled from sysemu.h
  include/sysemu/sysemu.h: Remove usused variable no_quit
  gitlab-ci: Refresh the list of iotests
  tests/qtest: update comments about bios-tables-test-allowed-diff.h
  boot-order-test: fix memleaks in boot-order-test
  tests/Makefile: Fix inclusion of the qos dependency files
  docs/devel: Fix qtest paths and info about check-block in testing.rst
  tests/vhost-user-bridge: Fix build
  test-logging: Fix -Werror=maybe-uninitialized warning

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/163b09516857...7bd9d0a9e26c