[Qemu-commits] [qemu/qemu] c388f4: ui: Print available display backends with '-displa...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c388f408b538b38db83999fd20b17020d5fdf68f
      
https://github.com/qemu/qemu/commit/c388f408b538b38db83999fd20b17020d5fdf68f
  Author: Thomas Huth <address@hidden>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M include/ui/console.h
    M qemu-options.hx
    M ui/console.c
    M vl.c

  Log Message:
  -----------
  ui: Print available display backends with '-display help'

We already print availabled devices with "-device help", or available
backends with "-netdev help" or "-chardev help". Let's provide a way
for the users to query the available display backends, too.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: c4c00922cc948bb5e879bfae60764eba1f8745f3
      
https://github.com/qemu/qemu/commit/c4c00922cc948bb5e879bfae60764eba1f8745f3
  Author: Nikola Pavlica <address@hidden>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M include/ui/gtk.h
    M ui/gtk.c

  Log Message:
  -----------
  display/gtk: get proper refreshrate

Because some VMs in QEMU can get GPU virtualization (using technologies
such as iGVT-g, as mentioned previously), they could produce a video
output that had a higher display refresh rate than of what the GTK
display was displaying. (fxp. Playing a video game inside of a Windows
VM at 60 Hz, while the output stood locked at 33 Hz because of defaults
set in include/ui/console.h)

Since QEMU does indeed have internal systems for determining frame
times as defined in ui/console.c.
The code checks for a variable called update_interval that it later
uses for time calculation. This variable, however, isn't defined
anywhere in ui/gtk.c and instead ui/console.c just sets it to
GUI_REFRESH_INTERVAL_DEFAULT which is 30

update_interval represents the number of milliseconds per display
refresh, and by doing some math we get that 1000/30 = 33.33... Hz

This creates the mentioned problem and what this patch does is that it
checks for the display refresh rate reported by GTK itself (we can take
this as a safe value) and just converts it back to a number of
milliseconds per display refresh.

Signed-off-by: Nikola Pavlica <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden

[ kraxel: style tweak: add blank line between vars and code ]

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3a63b24a1bbf166e6f455fe43a6bbd8dea413d92
      
https://github.com/qemu/qemu/commit/3a63b24a1bbf166e6f455fe43a6bbd8dea413d92
  Author: Peter Maydell <address@hidden>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M include/ui/console.h
    M include/ui/gtk.h
    M qemu-options.hx
    M ui/console.c
    M ui/gtk.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20200114-pull-request' 
into staging

ui: add "-display help", gtk refresh rate.

# gpg: Signature made Tue 14 Jan 2020 10:01:14 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20200114-pull-request:
  display/gtk: get proper refreshrate
  ui: Print available display backends with '-display help'

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/fee0ec1fd11a...3a63b24a1bbf