[Qemu-commits] [qemu/qemu] deda49: error: Fix -msg timestamp default

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] deda49: error: Fix -msg timestamp default

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] deda49: error: Fix -msg timestamp default
Date:	Fri, 20 Dec 2019 03:30:14 -0800
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: deda497b846addcc6841274a7ac17e13d3eb146c
      
https://github.com/qemu/qemu/commit/deda497b846addcc6841274a7ac17e13d3eb146c
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M include/qemu/error-report.h
    M qemu-options.hx
    M util/qemu-error.c
    M vl.c

  Log Message:
  -----------
  error: Fix -msg timestamp default

-msg parameter "timestamp" defaults to "off" if you don't specify msg,
and to "on" if you do.  Messed up right in commit 5e2ac51917 "add
timestamp to error_report()".  Mostly harmless, because "timestamp" is
the only parameter, so "if you do" is "-msg ''", which nobody does.

Change the default to "off" no matter what.

While there, rename enable_timestamp_msg to error_with_timestamp, and
polish documentation.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>


  Commit: 8cb846db9e026dac849698208fbebb2991d9754d
      
https://github.com/qemu/qemu/commit/8cb846db9e026dac849698208fbebb2991d9754d
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M crypto/tlscredsx509.c

  Log Message:
  -----------
  crypto: Fix certificate file error handling crash bug

qcrypto_tls_creds_load_cert() passes uninitialized GError *gerr by
reference to g_file_get_contents().  When g_file_get_contents() fails,
it'll try to set a GError.  Unless @gerr is null by dumb luck, this
logs a ERROR_OVERWRITTEN_WARNING warning message and leaves @gerr
unchanged.  qcrypto_tls_creds_load_cert() then dereferences the
uninitialized @gerr.

Fix by initializing @gerr properly.

Fixes: 9a2fd4347c40321f5cbb4ab4220e759fcbf87d03
Cc: "Daniel P. Berrangé" <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Acked-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


  Commit: 118bf79a78fce6bff11b5ef621a613e480f61afd
      
https://github.com/qemu/qemu/commit/118bf79a78fce6bff11b5ef621a613e480f61afd
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M include/crypto/tlssession.h

  Log Message:
  -----------
  crypto: Fix typo in QCryptoTLSSession's <example> comment

Cc: "Daniel P. Berrangé" <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Acked-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


  Commit: e4eb089c62fa7b1e758a895aec7682b4bed6a360
      
https://github.com/qemu/qemu/commit/e4eb089c62fa7b1e758a895aec7682b4bed6a360
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M include/io/task.h

  Log Message:
  -----------
  io: Fix Error usage in a comment <example>

Cc: "Daniel P. Berrangé" <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Acked-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


  Commit: 53cb2fc859bef4116bb5e8ef9a80ca6c05963d6f
      
https://github.com/qemu/qemu/commit/53cb2fc859bef4116bb5e8ef9a80ca6c05963d6f
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M tests/test-qobject-output-visitor.c
    M tests/test-string-output-visitor.c

  Log Message:
  -----------
  tests: Clean up initialization of Error *err variables

Declaring a local Error *err without initializer looks suspicious.
Fuse the declaration with the initialization to avoid that.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


  Commit: 56e477a56399c4e6d7fc0f6227fd9c475f83a8ce
      
https://github.com/qemu/qemu/commit/56e477a56399c4e6d7fc0f6227fd9c475f83a8ce
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  exec: Fix file_ram_alloc() error API violations

When os_mem_prealloc() fails, file_ram_alloc() calls qemu_ram_munmap()
and returns null.  Except it doesn't when its @errp argument is null,
because it checks for failure with (errp && *errp).  Introduced in
commit 056b68af77 "fix qemu exit on memory hotplug when allocation
fails at prealloc time".

No caller actually passes null.

Fix anyway: splice in a local Error *err, and error_propagate().

Cc: Igor Mammedov <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 49e3e11f8f27a75070062965c097e3feacc5d029
      
https://github.com/qemu/qemu/commit/49e3e11f8f27a75070062965c097e3feacc5d029
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/acpi/cpu_hotplug.c

  Log Message:
  -----------
  hw/acpi: Fix legacy CPU plug error API violations

legacy_acpi_cpu_plug_cb() dereferences @errp when
acpi_set_cpu_present_bit() fails.  That's wrong; see the big comment
in error.h.  Introduced in commit cc43364de7 "acpi/cpu-hotplug:
introduce helper function to keep bit setting in one place".

No caller actually passes null, and acpi_set_cpu_present_bit() can't
actually fail.

Fix anyway: drop acpi_set_cpu_present_bit()'s @errp parameter.

Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Igor Mammedov <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>


  Commit: bc0e339b01b330c55532571ae6fce89b0f8a4a96
      
https://github.com/qemu/qemu/commit/bc0e339b01b330c55532571ae6fce89b0f8a4a96
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/core/loader-fit.c

  Log Message:
  -----------
  hw/core: Fix fit_load_fdt() error API violations

fit_load_fdt() passes @errp to fit_image_addr(), then recovers from
ENOENT failures.  Passing @errp is wrong, because it works only as
long as @errp is neither @error_fatal nor @error_abort.  Error
recovery dereferences @errp.  That's also wrong; see the big comment
in error.h.  Error recovery can leave *errp pointing to a freed
Error object.  Wrong, it must be null on success.  Messed up in
commit 3eb99edb48 "loader-fit: Wean off error_printf()".

No caller actually passes such values, or uses *errp on success.

Fix anyway: splice in a local Error *err, and error_propagate().

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


  Commit: f6166a4da59bdd57b3af8b1c742ce611d6c3d3aa
      
https://github.com/qemu/qemu/commit/f6166a4da59bdd57b3af8b1c742ce611d6c3d3aa
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/ipmi/isa_ipmi_bt.c
    M hw/ipmi/isa_ipmi_kcs.c
    M hw/ipmi/pci_ipmi_bt.c
    M hw/ipmi/pci_ipmi_kcs.c

  Log Message:
  -----------
  hw/ipmi: Fix realize() error API violations

isa_ipmi_bt_realize(), ipmi_isa_realize(), pci_ipmi_bt_realize(), and
pci_ipmi_kcs_realize() dereference @errp when IPMIInterfaceClass
method init() fails.  That's wrong; see the big comment in error.h.
Introduced in commit 0719029c47 "ipmi: Add an ISA KCS low-level
interface", then imitated in commit a9b74079cb "ipmi: Add a BT
low-level interface" and commit 12f983c6aa "ipmi: Add PCI IPMI
interfaces".

No caller actually passes null.

Fix anyway: splice in a local Error *err, and error_propagate().

Cc: Corey Minyard <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>


  Commit: 292743d976324004d0c4f6f08e6d0589679d40ea
      
https://github.com/qemu/qemu/commit/292743d976324004d0c4f6f08e6d0589679d40ea
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M qga/commands-posix.c

  Log Message:
  -----------
  qga: Fix guest-get-fsinfo error API violations

build_guest_fsinfo_for_virtual_device() dereferences @errp when
build_guest_fsinfo_for_device() fails.  That's wrong; see the big
comment in error.h.  Introduced in commit 46d4c5723e "qga: Add
guest-get-fsinfo command".

No caller actually passes null.

Fix anyway: splice in a local Error *err, and error_propagate().

Cc: Michael Roth <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


  Commit: 8574c9f1ad905e473593230308a0b2a68c46ebe3
      
https://github.com/qemu/qemu/commit/8574c9f1ad905e473593230308a0b2a68c46ebe3
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/mem/memory-device.c

  Log Message:
  -----------
  memory-device: Fix memory pre-plug error API violations

memory_device_get_free_addr() dereferences @errp when
memory_device_check_addable() fails.  That's wrong; see the big
comment in error.h.  Introduced in commit 1b6d6af21b "pc-dimm: factor
out capacity and slot checks into MemoryDevice".

No caller actually passes null.

Fix anyway: splice in a local Error *err, and error_propagate().

Cc: David Hildenbrand <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>


  Commit: 8ca63ba8c2b1ee6746d2c245d70d82e7f7ef6e46
      
https://github.com/qemu/qemu/commit/8ca63ba8c2b1ee6746d2c245d70d82e7f7ef6e46
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/intc/s390_flic_kvm.c
    M hw/ppc/spapr_pci.c
    M hw/ppc/spapr_pci_nvlink2.c
    M tests/test-blockjob.c

  Log Message:
  -----------
  error: Clean up unusual names of Error * variables

Local Error * variables are conventionally named @err or @local_err,
and Error ** parameters @errp.  Naming local variables like parameters
is confusing.  Clean that up.

Naming parameters like local variables is also confusing.  Left for
another day.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: d402c98396b69d088d33070794893f7de254cbab
      
https://github.com/qemu/qemu/commit/d402c98396b69d088d33070794893f7de254cbab
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/intc/s390_flic_kvm.c

  Log Message:
  -----------
  hw/intc/s390: Simplify error handling in kvm_s390_flic_realize()

Cc: Halil Pasic <address@hidden>
Cc: Cornelia Huck <address@hidden>
Cc: Christian Borntraeger <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Acked-by: Halil Pasic <address@hidden>
Message-Id: <address@hidden>


  Commit: 0cf9e2b4f8e85477fbb50c9beb030aaf400d581a
      
https://github.com/qemu/qemu/commit/0cf9e2b4f8e85477fbb50c9beb030aaf400d581a
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M tests/test-blockjob.c

  Log Message:
  -----------
  tests-blockjob: Use error_free_or_abort()

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>


  Commit: 33c9642f657193bc478c96f08434ae746397b70e
      
https://github.com/qemu/qemu/commit/33c9642f657193bc478c96f08434ae746397b70e
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M net/net.c

  Log Message:
  -----------
  net/net: Clean up variable shadowing in net_client_init()

Variable int err in inner scope shadows Error *err in outer scope.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 49fbc7236dd203f9c6afa87454f603a9236a0b3b
      
https://github.com/qemu/qemu/commit/49fbc7236dd203f9c6afa87454f603a9236a0b3b
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M include/qapi/error.h
    M util/error.c

  Log Message:
  -----------
  error: make Error **errp const where it is appropriate

Mostly, Error ** is for returning error from the function, so the
callee sets it. However these three functions get already filled errp
parameter. They don't change the pointer itself, only change the
internal state of referenced Error object. So we can make it
Error *const * errp, to stress the behavior. It will also help
coccinelle script (in future) to distinguish such cases from common
errp usage.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Commit message typo fixed]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 187c614767cdb3407bc67acf77b9b1a0d985a39d
      
https://github.com/qemu/qemu/commit/187c614767cdb3407bc67acf77b9b1a0d985a39d
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M dump/dump-hmp-cmds.c
    M hw/core/machine-hmp-cmds.c
    M include/monitor/hmp.h
    M monitor/hmp-cmds.c
    M qdev-monitor.c
    M qom/qom-hmp-cmds.c

  Log Message:
  -----------
  hmp: drop Error pointer indirection in hmp_handle_error

We don't need Error **, as all callers pass local Error object, which
isn't used after the call. Use Error * instead.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Acked-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 34ab29c2ff5cfb638623a06bf8cb56fcae23a5a6
      
https://github.com/qemu/qemu/commit/34ab29c2ff5cfb638623a06bf8cb56fcae23a5a6
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  vnc: drop Error pointer indirection in vnc_client_io_error

We don't need Error **, as all callers pass local Error object, which
isn't used after the call, or NULL. Use Error * instead.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 340773260bfaff4e8b0c1a8ec6f22d8b078f590b
      
https://github.com/qemu/qemu/commit/340773260bfaff4e8b0c1a8ec6f22d8b078f590b
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev-monitor: make Error **errp const where it is appropriate

Mostly, Error ** is for returning error from the function, so the
callee sets it. However qbus_list_bus and qbus_list_dev get already
filled errp parameter. They don't change the pointer itself, only
change the internal state of referenced Error object. So we can make
it Error *const * errp, to stress the behavior. It will also help
coccinelle script (in future) to distinguish such cases from common
errp usage.

While there, rename the functions to
qbus_error_append_bus_list_hint(), qbus_error_append_dev_list_hint().

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Commit message replaced]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 1a639fdf960393d91d96bb938e1c08a5de41fd76
      
https://github.com/qemu/qemu/commit/1a639fdf960393d91d96bb938e1c08a5de41fd76
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/ppc/spapr.c
    M target/ppc/kvm.c
    M target/ppc/kvm_ppc.h

  Log Message:
  -----------
  Revert "ppc: well form kvmppc_hint_smt_possible error hint helper"

This reverts commit cdcca22aabafc0496894ce05c80097684832c7d9.

Commit cdcca22aaba is a superseded version of the next commit that
crept in by accident.  Revert it, so the final version applies.

Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 0c115681a5194a53a4b373c4ff6d8b42ddd23b55
      
https://github.com/qemu/qemu/commit/0c115681a5194a53a4b373c4ff6d8b42ddd23b55
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/ppc/spapr.c
    M target/ppc/kvm.c
    M target/ppc/kvm_ppc.h

  Log Message:
  -----------
  ppc: make Error **errp const where it is appropriate

Mostly, Error ** is for returning error from the function, so the
callee sets it. However kvmppc_hint_smt_possible gets already filled
errp parameter. It doesn't change the pointer itself, only change the
internal state of referenced Error object. So we can make it Error
*const * errp, to stress the behavior. It will also help coccinelle
script (in future) to distinguish such cases from common errp usage.

While there, rename the function to
kvmppc_error_append_smt_possible_hint().

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Message-Id: <address@hidden>
Acked-by: David Gibson <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Commit message replaced]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 4c5ec47e639f8dbcede5b343b6d373127758e844
      
https://github.com/qemu/qemu/commit/4c5ec47e639f8dbcede5b343b6d373127758e844
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c

  Log Message:
  -----------
  9pfs: make Error **errp const where it is appropriate

Mostly, Error ** is for returning error from the function, so the
callee sets it. However error_append_security_model_hint and
error_append_socket_sockfd_hint get already filled errp
parameter. They don't change the pointer itself, only change the
internal state of referenced Error object. So we can make it Error
*const * errp, to stress the behavior. It will also help coccinelle
script (in future) to distinguish such cases from common errp usage.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Acked-by: Greg Kurz <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Commit message replaced]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 40f03bd55cb201c7788db9620accad5c57a06cb0
      
https://github.com/qemu/qemu/commit/40f03bd55cb201c7788db9620accad5c57a06cb0
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  hw/core/qdev: cleanup Error ** variables

Rename Error ** parameter in check_only_migratable to common errp.

In device_set_realized:

 - Move "if (local_err != NULL)" closer to error setters.

 - Drop 'Error **local_errp': it doesn't save any LoCs, but it's very
   unusual.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: e53a578a8beb34249025e273c29ce0f4927bd1cf
      
https://github.com/qemu/qemu/commit/e53a578a8beb34249025e273c29ce0f4927bd1cf
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h

  Log Message:
  -----------
  block/snapshot: rename Error ** parameter to more common errp

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: c9b13a51d5ec4e6b262685f761dfd4187b086160
      
https://github.com/qemu/qemu/commit/c9b13a51d5ec4e6b262685f761dfd4187b086160
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/i386/amd_iommu.c

  Log Message:
  -----------
  hw/i386/amd_iommu: rename Error ** parameter to more common errp

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: b90abbac0b95f68a7ebac5545ab77b98f598a9c7
      
https://github.com/qemu/qemu/commit/b90abbac0b95f68a7ebac5545ab77b98f598a9c7
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/commands.c

  Log Message:
  -----------
  qga: rename Error ** parameter to more common errp

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: ec48595e2dcdac395d50320b9969b3195c419423
      
https://github.com/qemu/qemu/commit/ec48595e2dcdac395d50320b9969b3195c419423
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M monitor/qmp-cmds.c

  Log Message:
  -----------
  monitor/qmp-cmds: rename Error ** parameter to more common errp

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 547d645908f6c3ccc67d8e8f7fcab1248f27a0af
      
https://github.com/qemu/qemu/commit/547d645908f6c3ccc67d8e8f7fcab1248f27a0af
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/s390x/event-facility.c
    M hw/s390x/s390-stattrib.c

  Log Message:
  -----------
  hw/s390x: rename Error ** parameter to more common errp

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 1019388c82aae28bfd4a8aac1d365975d3ea009e
      
https://github.com/qemu/qemu/commit/1019388c82aae28bfd4a8aac1d365975d3ea009e
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/sd/sdhci.c

  Log Message:
  -----------
  hw/sd: drop extra whitespace in sdhci_sysbus_realize() header

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: e04e33213477aec641cea1edffe82f180bf0abcf
      
https://github.com/qemu/qemu/commit/e04e33213477aec641cea1edffe82f180bf0abcf
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/tpm/tpm_emulator.c

  Log Message:
  -----------
  hw/tpm: rename Error ** parameter to more common errp

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: a5fee60df2a5acbabfdc48a00fe3648072934c54
      
https://github.com/qemu/qemu/commit/a5fee60df2a5acbabfdc48a00fe3648072934c54
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/usb/dev-network.c

  Log Message:
  -----------
  hw/usb: rename Error ** parameter to more common errp

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 1dc6ba2425fed1d89204c69ec4ca71db3ba7f496
      
https://github.com/qemu/qemu/commit/1dc6ba2425fed1d89204c69ec4ca71db3ba7f496
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M include/qom/object.h

  Log Message:
  -----------
  include/qom/object.h: rename Error ** parameter to more common errp

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 7dc75edb0399677e4fb45c8103d77e56ae60e34d
      
https://github.com/qemu/qemu/commit/7dc75edb0399677e4fb45c8103d77e56ae60e34d
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M backends/cryptodev.c

  Log Message:
  -----------
  backends/cryptodev: drop local_err from cryptodev_backend_complete()

No reason for local_err here, use errp directly instead.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Gonglei <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: b5e45b0f48ae837d693230809d97615bc0862832
      
https://github.com/qemu/qemu/commit/b5e45b0f48ae837d693230809d97615bc0862832
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M hw/vfio/ap.c

  Log Message:
  -----------
  hw/vfio/ap: drop local_err from vfio_ap_realize

No reason for local_err here, use errp directly instead.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: d936613547aec49b0b80193cee0b9df05cd8a2ae
      
https://github.com/qemu/qemu/commit/d936613547aec49b0b80193cee0b9df05cd8a2ae
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M block/nbd.c

  Log Message:
  -----------
  nbd: assert that Error** is not NULL in nbd_iter_channel_error

All callers of nbd_iter_channel_error() pass the address of a
local_err variable, and only call this function if an error has
already occurred, using this function to propagate that error.
This is already implied by its name (local_err instead of the classic
errp), but it is worth additionally stressing this by adding an
assertion to make it part of the function contract.

The local_err parameter is not here to return information about
nbd_iter_channel_error failure. Instead it's assumed to be filled when
passed to the function. This is already stressed by its name
(local_err, instead of classic errp). Stress it additionally by
assertion.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 31b2bd89b915d527ff907e8f3c151585e0c45d4f
      
https://github.com/qemu/qemu/commit/31b2bd89b915d527ff907e8f3c151585e0c45d4f
  Author: Peter Maydell <address@hidden>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M backends/cryptodev.c
    M block/nbd.c
    M block/snapshot.c
    M crypto/tlscredsx509.c
    M dump/dump-hmp-cmds.c
    M exec.c
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c
    M hw/acpi/cpu_hotplug.c
    M hw/core/loader-fit.c
    M hw/core/machine-hmp-cmds.c
    M hw/core/qdev.c
    M hw/i386/amd_iommu.c
    M hw/intc/s390_flic_kvm.c
    M hw/ipmi/isa_ipmi_bt.c
    M hw/ipmi/isa_ipmi_kcs.c
    M hw/ipmi/pci_ipmi_bt.c
    M hw/ipmi/pci_ipmi_kcs.c
    M hw/mem/memory-device.c
    M hw/ppc/spapr_pci.c
    M hw/ppc/spapr_pci_nvlink2.c
    M hw/s390x/event-facility.c
    M hw/s390x/s390-stattrib.c
    M hw/sd/sdhci.c
    M hw/tpm/tpm_emulator.c
    M hw/usb/dev-network.c
    M hw/vfio/ap.c
    M include/block/snapshot.h
    M include/crypto/tlssession.h
    M include/io/task.h
    M include/monitor/hmp.h
    M include/qapi/error.h
    M include/qemu/error-report.h
    M include/qom/object.h
    M monitor/hmp-cmds.c
    M monitor/qmp-cmds.c
    M net/net.c
    M qdev-monitor.c
    M qemu-options.hx
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/commands.c
    M qom/qom-hmp-cmds.c
    M target/ppc/kvm.c
    M target/ppc/kvm_ppc.h
    M tests/test-blockjob.c
    M tests/test-qobject-output-visitor.c
    M tests/test-string-output-visitor.c
    M ui/vnc.c
    M ui/vnc.h
    M util/error.c
    M util/qemu-error.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2019-12-17-v2' 
into staging

Error reporting patches for 2019-12-17

# gpg: Signature made Wed 18 Dec 2019 07:45:24 GMT
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Markus Armbruster <address@hidden>" [full]
# gpg:                 aka "Markus Armbruster <address@hidden>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-error-2019-12-17-v2: (35 commits)
  nbd: assert that Error** is not NULL in nbd_iter_channel_error
  hw/vfio/ap: drop local_err from vfio_ap_realize
  backends/cryptodev: drop local_err from cryptodev_backend_complete()
  include/qom/object.h: rename Error ** parameter to more common errp
  hw/usb: rename Error ** parameter to more common errp
  hw/tpm: rename Error ** parameter to more common errp
  hw/sd: drop extra whitespace in sdhci_sysbus_realize() header
  hw/s390x: rename Error ** parameter to more common errp
  monitor/qmp-cmds: rename Error ** parameter to more common errp
  qga: rename Error ** parameter to more common errp
  hw/i386/amd_iommu: rename Error ** parameter to more common errp
  block/snapshot: rename Error ** parameter to more common errp
  hw/core/qdev: cleanup Error ** variables
  9pfs: make Error **errp const where it is appropriate
  ppc: make Error **errp const where it is appropriate
  Revert "ppc: well form kvmppc_hint_smt_possible error hint helper"
  qdev-monitor: make Error **errp const where it is appropriate
  vnc: drop Error pointer indirection in vnc_client_io_error
  hmp: drop Error pointer indirection in hmp_handle_error
  error: make Error **errp const where it is appropriate
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/aceeaa69d28e...31b2bd89b915
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] deda49: error: Fix -msg timestamp default, Peter Maydell <=
Prev by Date: [Qemu-commits] [qemu/qemu] 6da68d: hw/arm/nseries: Replace the bluetooth chardev with...
Next by Date: [Qemu-commits] [qemu/qemu] 9b3a31: kvm: Reallocate dirty_bmap when we change a slot
Previous by thread: [Qemu-commits] [qemu/qemu] 6da68d: hw/arm/nseries: Replace the bluetooth chardev with...
Next by thread: [Qemu-commits] [qemu/qemu] 9b3a31: kvm: Reallocate dirty_bmap when we change a slot
Index(es):
- Date
- Thread