[Qemu-commits] [qemu/qemu] 6da68d: hw/arm/nseries: Replace the bluetooth chardev with...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6da68df7f9b92e901263ea065712a289c8d3838e
      
https://github.com/qemu/qemu/commit/6da68df7f9b92e901263ea065712a289c8d3838e
  Author: Thomas Huth <address@hidden>
  Date:   2019-12-16 (Mon, 16 Dec 2019)

  Changed paths:
    M hw/arm/nseries.c
    M qemu-doc.texi

  Log Message:
  -----------
  hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev

We are going to remove the bitrotten bluetooth backend, so we can
not use it in the n800 and n810 machines anymore. Replace the chardev
here with a "null" chardev and stop including the "hw/bt.h" header.

I am not aware of a full working N8x0 environment that can be used to
test these machines, but the Linux kernel from the Meego project that
can be found on http://stskeeps.subnetmask.net/meego-n8x0/ still seems
to boot as far as it did before.

Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 43d68d0a94ef13058f6479b3dd490169a9a62966
      
https://github.com/qemu/qemu/commit/43d68d0a94ef13058f6479b3dd490169a9a62966
  Author: Thomas Huth <address@hidden>
  Date:   2019-12-16 (Mon, 16 Dec 2019)

  Changed paths:
    M hw/usb/Kconfig
    M hw/usb/Makefile.objs
    R hw/usb/dev-bluetooth.c
    M qemu-doc.texi

  Log Message:
  -----------
  hw/usb: Remove the USB bluetooth dongle device

We are going to remove the bluetooth backend, so the USB bluetooth
dongle can not work anymore. It's a completely optional device, no
board depends on it, so let's simply remove it now.

Message-Id: <address@hidden>
Reviewed-by: Ján Tomko <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 1d4ffe8dc77cbc9aafe8bcf514ca0e43f85aaae3
      
https://github.com/qemu/qemu/commit/1d4ffe8dc77cbc9aafe8bcf514ca0e43f85aaae3
  Author: Thomas Huth <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M Makefile.objs
    R bt-host.c
    R bt-vhci.c
    M configure
    M hw/Kconfig
    M hw/Makefile.objs
    M hw/bt/Kconfig
    R hw/bt/Makefile.objs
    R hw/bt/core.c
    R hw/bt/hci-csr.c
    R hw/bt/hci.c
    R hw/bt/hid.c
    R hw/bt/l2cap.c
    R hw/bt/sdp.c
    R include/hw/bt.h
    R include/sysemu/bt.h
    M qemu-deprecated.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  Remove the core bluetooth code

It's been deprecated since QEMU v3.1. We've explicitly asked in the
deprecation message that people should speak up on qemu-devel in case
they are still actively using the bluetooth part of QEMU, but nobody
ever replied that they are really still using it.

I've tried it on my own to use this bluetooth subsystem for one of my
guests, but I was also not able to get it running anymore: When I was
trying to pass-through a real bluetooth device, either the guest did
not see the device at all, or the guest crashed.

Even worse for the emulated device: When running

 qemu-system-x86_64 -bt device:keyboard

QEMU crashes once you hit a key.

So it seems like the bluetooth stack is not only neglected, it is
completely bitrotten, as far as I can tell. The only attention that
this code got during the past years were some CVEs that have been
spotted there. So this code is a burden for the developers, without
any real benefit anymore. Time to remove it.

Note: hw/bt/Kconfig only gets cleared but not removed here yet.
Otherwise there is a problem with the *-softmmu/config-devices.mak.d
dependency files - they still contain a reference to this file which
gets evaluated first on some build hosts, before the file gets
properly recreated. To avoid breaking these builders, we still need
the file around for some time. It will get removed in a couple of
weeks instead.

Message-Id: <address@hidden>
Reviewed-by: Ján Tomko <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 2831a7e580e0ee85ff9dbb225a38e5741671542e
      
https://github.com/qemu/qemu/commit/2831a7e580e0ee85ff9dbb225a38e5741671542e
  Author: Thomas Huth <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M .gitlab-ci.yml
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/ubuntu.docker
    M tests/docker/dockerfiles/ubuntu1804.docker

  Log Message:
  -----------
  Remove libbluetooth / bluez from the CI tests

Since the bluetooth code has been removed, we don't need to test
with this library anymore.

Message-Id: <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: eca3a945234a5f0a499860dd11df64b5f1a2e0a5
      
https://github.com/qemu/qemu/commit/eca3a945234a5f0a499860dd11df64b5f1a2e0a5
  Author: Cole Robinson <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M tests/modules-test.c

  Log Message:
  -----------
  tests: fix modules-test 'duplicate test case' error

./configure --enable-sdl --audio-drv-list=sdl --enable-modules

Will generate two identical test names: /$arch/module/load/sdl
Which generates an error like:

(tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test case 
path: /aarch64//module/load/sdl

Add the subsystem prefix in the name as well, so instead we get:

/$arch/module/load/audio-sdl
/$arch/module/load/ui-sdl

Signed-off-by: Cole Robinson <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 1ee5e144ea6bed4afab8c28f1c552c82ef56bc95
      
https://github.com/qemu/qemu/commit/1ee5e144ea6bed4afab8c28f1c552c82ef56bc95
  Author: Laurent Vivier <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M tests/migration-test.c

  Log Message:
  -----------
  pseries: disable migration-test if /dev/kvm cannot be used

On ppc64, migration-test only works with kvm_hv, and we already
have a check to verify the module is loaded.

kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists,
but on some systems (like build systems) /dev/kvm can be missing
(by administrators choice).

And as kvm_hv exists test-migration is started but QEMU falls back to
TCG because it cannot be used:

    Could not access KVM kernel module: No such file or directory
    failed to initialize KVM: No such file or directory
    Back to tcg accelerator

And as the test is done with TCG, it fails.

As for s390x, we must check for the existence and the access rights
of /dev/kvm.

Reported-by: Cole Robinson <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: e858e04dd400744a93d453e97b33f9eaee2dabec
      
https://github.com/qemu/qemu/commit/e858e04dd400744a93d453e97b33f9eaee2dabec
  Author: Markus Armbruster <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M hw/misc/ivshmem.c

  Log Message:
  -----------
  hw/misc/ivshmem: Bury dead legacy INTx code

Devices "ivshmem-plain" and "ivshmem-doorbell" support only MSI-X.
Config space register Interrupt Pin is zero.  Device "ivshmem"
additionally supported legacy INTx, but it was removed in commit
5a0e75f0a9 "hw/misc/ivshmem: Remove deprecated "ivshmem" legacy
device".  The commit left ivshmem_update_irq() behind.  Since the
Interrupt Pin register is zero, the function does nothing.  Remove it.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: e468ffdc6d3b1c7127b785eb73a1f5c94751fb01
      
https://github.com/qemu/qemu/commit/e468ffdc6d3b1c7127b785eb73a1f5c94751fb01
  Author: Marc-André Lureau <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M include/sysemu/os-win32.h
    M os-win32.c
    M tests/libqtest.c
    M tests/test-crypto-tlscredsx509.c
    M tests/test-crypto-tlssession.c
    M tests/test-io-channel-tls.c
    M tests/test-vmstate.c
    M ui/sdl2.c

  Log Message:
  -----------
  glib: use portable g_setenv()

We have a setenv() wrapper in os-win32.c that no one is actually using.
Drop it and change to g_setenv() uniformly.

Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: c3088cd306caf965f1901e0a9ed818353c530b4e
      
https://github.com/qemu/qemu/commit/c3088cd306caf965f1901e0a9ed818353c530b4e
  Author: Wainer dos Santos Moschetta <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests/Makefile: Fix check-report.* targets shown in check-help

The check-report.html and check-report.xml targets were replaced
with check-report.tap in commit 9df43317b82 but the check-help
text was not updated so it still lists check-report.html.

Fixes: 9df43317b82
Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 0f555602c7430ae55b5a4bacf39ce9e483e11193
      
https://github.com/qemu/qemu/commit/0f555602c7430ae55b5a4bacf39ce9e483e11193
  Author: Paolo Bonzini <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M tests/ivshmem-test.c
    M tests/test-bitmap.c
    M tests/test-qga.c

  Log Message:
  -----------
  tests: use g_test_rand_int

g_test_rand_int provides a reproducible random integer number, using a
different number seed every time but allowing reproduction using the
--seed command line option.  It is thus better suited to tests than
g_random_int or random.

Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: aceeaa69d28e6f08a24395d0aa6915b687d0a681
      
https://github.com/qemu/qemu/commit/aceeaa69d28e6f08a24395d0aa6915b687d0a681
  Author: Peter Maydell <address@hidden>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M .gitlab-ci.yml
    M Makefile.objs
    R bt-host.c
    R bt-vhci.c
    M configure
    M hw/Kconfig
    M hw/Makefile.objs
    M hw/arm/nseries.c
    M hw/bt/Kconfig
    R hw/bt/Makefile.objs
    R hw/bt/core.c
    R hw/bt/hci-csr.c
    R hw/bt/hci.c
    R hw/bt/hid.c
    R hw/bt/l2cap.c
    R hw/bt/sdp.c
    M hw/misc/ivshmem.c
    M hw/usb/Kconfig
    M hw/usb/Makefile.objs
    R hw/usb/dev-bluetooth.c
    R include/hw/bt.h
    R include/sysemu/bt.h
    M include/sysemu/os-win32.h
    M os-win32.c
    M qemu-deprecated.texi
    M qemu-doc.texi
    M qemu-options.hx
    M tests/Makefile.include
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/ubuntu.docker
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/ivshmem-test.c
    M tests/libqtest.c
    M tests/migration-test.c
    M tests/modules-test.c
    M tests/test-bitmap.c
    M tests/test-crypto-tlscredsx509.c
    M tests/test-crypto-tlssession.c
    M tests/test-io-channel-tls.c
    M tests/test-qga.c
    M tests/test-vmstate.c
    M ui/sdl2.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging

* Removal of the deprecated bluetooth code
* Some qtest and misc patches

# gpg: Signature made Tue 17 Dec 2019 08:09:08 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2019-12-17:
  tests: use g_test_rand_int
  tests/Makefile: Fix check-report.* targets shown in check-help
  glib: use portable g_setenv()
  hw/misc/ivshmem: Bury dead legacy INTx code
  pseries: disable migration-test if /dev/kvm cannot be used
  tests: fix modules-test 'duplicate test case' error
  Remove libbluetooth / bluez from the CI tests
  Remove the core bluetooth code
  hw/usb: Remove the USB bluetooth dongle device
  hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/f6e7a97acbe9...aceeaa69d28e