[Qemu-commits] [qemu/qemu] 10f9f1: hw/block/pflash: Remove dynamic field width from t...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 10f9f1fbed11e520e6fd71f02cd71f0e9c759b69
      
https://github.com/qemu/qemu/commit/10f9f1fbed11e520e6fd71f02cd71f0e9c759b69
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M hw/block/pflash_cfi01.c
    M hw/block/pflash_cfi02.c
    M hw/block/trace-events

  Log Message:
  -----------
  hw/block/pflash: Remove dynamic field width from trace events

Since not all trace backends support dynamic field width in
format (dtrace via stap does not), replace by a static field
width instead.

We previously passed to the trace API 'width << 1' as the number
of hex characters to display (the dynamic field width). We don't
need this anymore. Instead, display the size of bytes accessed.

Fixes: e8aa2d95ea ("pflash: Simplify trace_pflash_io_read/write")
Fixes: c1474acd5d ("pflash: Simplify trace_pflash_data_read/write")
Reported-by: Eric Blake <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Buglink: https://bugs.launchpad.net/qemu/+bug/1844817
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: abc7cf36559f953777faf27d2e0dfb561ac533a5
      
https://github.com/qemu/qemu/commit/abc7cf36559f953777faf27d2e0dfb561ac533a5
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M hw/mips/gt64xxx_pci.c
    M hw/mips/trace-events

  Log Message:
  -----------
  hw/mips/gt64xxx: Remove dynamic field width from trace events

Since not all trace backends support dynamic field width in
format (dtrace via stap does not), replace by a static field
width instead.

We previously passed to the trace API 'width << 1' as the number
of hex characters to display (the dynamic field width). We don't
need this anymore. Instead, display the size of bytes accessed.

Fixes: ab6bff424f ("gt64xxx_pci: Convert debug printf to trace events")
Reported-by: Eric Blake <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Buglink: https://bugs.launchpad.net/qemu/+bug/1844817
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 4b8be65ec5b42027b9b0587955643646d015f2ee
      
https://github.com/qemu/qemu/commit/4b8be65ec5b42027b9b0587955643646d015f2ee
  Author: Peter Maydell <address@hidden>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M hw/block/pflash_cfi01.c
    M hw/block/pflash_cfi02.c
    M hw/block/trace-events
    M hw/mips/gt64xxx_pci.c
    M hw/mips/trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/philmd-gitlab/tags/mips-next-20191119' 
into staging

The DTrace via SystemTap backend can not support the dynamic '*' width
format. We failed at noticing it for the 4.1 release, and LP#1844817
was opened to track it. Fix this regression for the next release.

# gpg: Signature made Tue 19 Nov 2019 13:56:50 GMT
# gpg:                using RSA key 89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (Phil) <address@hidden>" 
[marginal]
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 89C1 E78F 601E E86C 8674  95CB A2A3 FD6E DEAD C0DE

* remotes/philmd-gitlab/tags/mips-next-20191119:
  hw/mips/gt64xxx: Remove dynamic field width from trace events
  hw/block/pflash: Remove dynamic field width from trace events

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/9263dec8ef9a...4b8be65ec5b4