[Qemu-commits] [qemu/qemu] a18025: qga-win: network-get-interfaces command name field...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a18025f9ac56aafdbb4ac08fdf5ef7c46a3baf34
      
https://github.com/qemu/qemu/commit/a18025f9ac56aafdbb4ac08fdf5ef7c46a3baf34
  Author: Bishara AbuHattoum <address@hidden>
  Date:   2019-11-04 (Mon, 04 Nov 2019)

  Changed paths:
    M qga/commands-win32.c

  Log Message:
  -----------
  qga-win: network-get-interfaces command name field bug fix

Network interface name is fetched as an encoded WCHAR array, (wide
character), then it is decoded using the guest's CP_ACP Windows code
page, which is the default code page as configure in the guest's
Windows, then it is returned as a byte array, (char array).

As stated in the BZ#1733165, when renaming a network interface to a
Chinese name and invoking this command, the returned name field has
the (\ufffd) value for each Chinese character the name had, this
value is an indication that the code page does not have the decoding
information for the given character.

This bug is a result of using the CP_ACP code page for decoding which
is an interchangeable code page, instead CP_UTF8 code page should be
used for decoding the network interface's name.

https://bugzilla.redhat.com/show_bug.cgi?id=1733165

Signed-off-by: Bishara AbuHattoum <address@hidden>
Cc: address@hidden
Signed-off-by: Michael Roth <address@hidden>


  Commit: 28d8dd355be98da6239bd5569721980c833df6a1
      
https://github.com/qemu/qemu/commit/28d8dd355be98da6239bd5569721980c833df6a1
  Author: Basil Salman <address@hidden>
  Date:   2019-11-04 (Mon, 04 Nov 2019)

  Changed paths:
    M qga/commands-posix.c
    M qga/commands-win32.c

  Log Message:
  -----------
  qga: Add "guest-get-memory-block-info" to blacklist

Memory block commands are only supported for linux with sysfs,
"guest-get-memory-block-info" was not in blacklist for other
cases.

Reported on:
https://bugzilla.redhat.com/show_bug.cgi?id=1751431

Signed-off-by: Basil Salman <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 50d2d550d75b66529f4037d1daa7f4715351bdca
      
https://github.com/qemu/qemu/commit/50d2d550d75b66529f4037d1daa7f4715351bdca
  Author: Peter Maydell <address@hidden>
  Date:   2019-11-06 (Wed, 06 Nov 2019)

  Changed paths:
    M qga/commands-posix.c
    M qga/commands-win32.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2019-11-04-tag' 
into staging

qemu-ga patch queue for hard-freeze

* fix handling of Chinese network device names in
  guest-network-get-interfaces
* add missing blacklist entries for guest-get-memory-block-info for
  w32/non-linux builds

# gpg: Signature made Mon 04 Nov 2019 17:25:54 GMT
# gpg:                using RSA key CEACC9E15534EBABB82D3FA03353C9CEF108B584
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Michael Roth <address@hidden>" [full]
# gpg:                 aka "Michael Roth <address@hidden>" [full]
# gpg:                 aka "Michael Roth <address@hidden>" [full]
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* remotes/mdroth/tags/qga-pull-2019-11-04-tag:
  qga: Add "guest-get-memory-block-info" to blacklist
  qga-win: network-get-interfaces command name field bug fix

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e9102eb84dbc...50d2d550d75b