qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 20a192: fw_cfg: Allow reboot-timeout=-1 again


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 20a192: fw_cfg: Allow reboot-timeout=-1 again
Date: Tue, 05 Nov 2019 12:58:52 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 20a192203222efde055df688cc344f9efb87c372
      
https://github.com/qemu/qemu/commit/20a192203222efde055df688cc344f9efb87c372
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2019-11-01 (Fri, 01 Nov 2019)

  Changed paths:
    M hw/nvram/fw_cfg.c

  Log Message:
  -----------
  fw_cfg: Allow reboot-timeout=-1 again

Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout
to only allow the range 0..65535; however both qemu and libvirt document
the special value -1  to mean don't reboot.
Allow it again.

Fixes: ee5d0f89de3e53cdb0dc ("fw_cfg: Fix -boot reboot-timeout error checking")
RH bz: https://bugzilla.redhat.com/show_bug.cgi?id=1765443
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Suggested-by: Laszlo Ersek <address@hidden>
Message-Id: <address@hidden>
[PMD: Applied Laszlo's suggestions]
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: eda4e62cc2f5d12fcedcf799a5a3f9eba855ad77
      
https://github.com/qemu/qemu/commit/eda4e62cc2f5d12fcedcf799a5a3f9eba855ad77
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-11-01 (Fri, 01 Nov 2019)

  Changed paths:
    M tests/fw_cfg-test.c

  Log Message:
  -----------
  tests/fw_cfg: Test 'reboot-timeout=-1' special value

The special value -1 means "don't reboot" for QEMU/libvirt.
Add a trivial test.

Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 412fbef3d076c43e56451bacb28c4544858c66a3
      
https://github.com/qemu/qemu/commit/412fbef3d076c43e56451bacb28c4544858c66a3
  Author: Peter Maydell <address@hidden>
  Date:   2019-11-05 (Tue, 05 Nov 2019)

  Changed paths:
    M hw/nvram/fw_cfg.c
    M tests/fw_cfg-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging

Fix the fw_cfg reboot-timeout=-1 special value, add a test for it.

# gpg: Signature made Sun 03 Nov 2019 22:21:02 GMT
# gpg:                using RSA key 89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (Phil) <address@hidden>" 
[marginal]
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 89C1 E78F 601E E86C 8674  95CB A2A3 FD6E DEAD C0DE

* remotes/philmd-gitlab/tags/fw_cfg-next-pull-request:
  tests/fw_cfg: Test 'reboot-timeout=-1' special value
  fw_cfg: Allow reboot-timeout=-1 again

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/36609b4fa36f...412fbef3d076



reply via email to

[Prev in Thread] Current Thread [Next in Thread]