qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 7d6013: IDE: deprecate ide-drive

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 7d6013: IDE: deprecate ide-drive
Date: Thu, 31 Oct 2019 17:11:00 +0000 (UTC) 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7d60133fcae81b1c829d30ceca4f16eaa26c4d36
      
https://github.com/qemu/qemu/commit/7d60133fcae81b1c829d30ceca4f16eaa26c4d36
  Author: John Snow <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M hw/ide/qdev.c
    M qemu-deprecated.texi
    M tests/qemu-iotests/051.pc.out

  Log Message:
  -----------
  IDE: deprecate ide-drive

It's an old compatibility shim that just delegates to ide-cd or ide-hd.
I'd like to refactor these some day, and getting rid of the super-object
will make that easier.

Either way, we don't need this.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
ACKed-by: Peter Krempa <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 8e6a1749373b49f781d744375e6e280f4686f1da
      
https://github.com/qemu/qemu/commit/8e6a1749373b49f781d744375e6e280f4686f1da
  Author: Sam Eiderman <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M hw/ide/qdev.c
    M include/hw/block/block.h

  Log Message:
  -----------
  block: Refactor macros - fix tabbing

Fixing tabbing in block related macros.

Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Reviewed-by: Karl Heubaum <address@hidden>
Reviewed-by: Arbel Moshe <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: John Snow <address@hidden>


  Commit: 64c5bb83df51bc40bf9da5075709b270b86f66e3
      
https://github.com/qemu/qemu/commit/64c5bb83df51bc40bf9da5075709b270b86f66e3
  Author: Sam Eiderman <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M include/hw/block/block.h

  Log Message:
  -----------
  block: Support providing LCHS from user

Add logical geometry variables to BlockConf.

A user can now supply "lcyls", "lheads" & "lsecs" for any HD device
that supports CHS ("cyls", "heads", "secs").

These devices include:
    * ide-hd
    * scsi-hd
    * virtio-blk-pci

In future commits we will use the provided LCHS and pass it to the BIOS
through fw_cfg to be supplied using INT13 routines.

Reviewed-by: Karl Heubaum <address@hidden>
Reviewed-by: Arbel Moshe <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: John Snow <address@hidden>


  Commit: f7209ea1be116e06b66408d9949f5281a6c7137c
      
https://github.com/qemu/qemu/commit/f7209ea1be116e06b66408d9949f5281a6c7137c
  Author: Sam Eiderman <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M bootdevice.c
    M include/sysemu/sysemu.h

  Log Message:
  -----------
  bootdevice: Add interface to gather LCHS

Add an interface to provide direct logical CHS values for boot devices.
We will use this interface in the next commits.

Reviewed-by: Karl Heubaum <address@hidden>
Reviewed-by: Arbel Moshe <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: John Snow <address@hidden>


  Commit: 6b98c5aae65b432816b3f6d9ce765edf78d66864
      
https://github.com/qemu/qemu/commit/6b98c5aae65b432816b3f6d9ce765edf78d66864
  Author: Sam Eiderman <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M hw/scsi/scsi-bus.c
    M include/hw/scsi/scsi.h

  Log Message:
  -----------
  scsi: Propagate unrealize() callback to scsi-hd

We will need to add LCHS removal logic to scsi-hd's unrealize() in the
next commit.

Reviewed-by: Karl Heubaum <address@hidden>
Reviewed-by: Arbel Moshe <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: John Snow <address@hidden>


  Commit: 71f571a23d732711908a5af8c24c56b218a44256
      
https://github.com/qemu/qemu/commit/71f571a23d732711908a5af8c24c56b218a44256
  Author: Sam Eiderman <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M hw/block/virtio-blk.c
    M hw/ide/qdev.c
    M hw/scsi/scsi-disk.c

  Log Message:
  -----------
  bootdevice: Gather LCHS from all relevant devices

Relevant devices are:
    * ide-hd (and ide-cd, ide-drive)
    * scsi-hd (and scsi-cd, scsi-disk, scsi-block)
    * virtio-blk-pci

We do not call del_boot_device_lchs() for ide-* since we don't need to -
IDE block devices do not support unplugging.

Reviewed-by: Karl Heubaum <address@hidden>
Reviewed-by: Arbel Moshe <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: John Snow <address@hidden>


  Commit: 42f068019926078e8cd61c7c4357143199003f0b
      
https://github.com/qemu/qemu/commit/42f068019926078e8cd61c7c4357143199003f0b
  Author: Sam Eiderman <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M bootdevice.c

  Log Message:
  -----------
  bootdevice: Refactor get_boot_devices_list

Move device name construction to a separate function.

We will reuse this function in the following commit to pass logical CHS
parameters through fw_cfg much like we currently pass bootindex.

Reviewed-by: Karl Heubaum <address@hidden>
Reviewed-by: Arbel Moshe <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: John Snow <address@hidden>


  Commit: aea60a13b9d43bb4c5748a1216af954a0e9d22d4
      
https://github.com/qemu/qemu/commit/aea60a13b9d43bb4c5748a1216af954a0e9d22d4
  Author: Sam Eiderman <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M bootdevice.c
    M hw/nvram/fw_cfg.c
    M include/sysemu/sysemu.h

  Log Message:
  -----------
  bootdevice: FW_CFG interface for LCHS values

Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS.

Non-standard logical geometries break under QEMU.

A virtual disk which contains an operating system which depends on
logical geometries (consistent values being reported from BIOS INT13
AH=08) will most likely break under QEMU/SeaBIOS if it has non-standard
logical geometries - for example 56 SPT (sectors per track).
No matter what QEMU will report - SeaBIOS, for large enough disks - will
use LBA translation, which will report 63 SPT instead.

In addition we cannot force SeaBIOS to rely on physical geometries at
all. A virtio-blk-pci virtual disk with 255 phyiscal heads cannot
report more than 16 physical heads when moved to an IDE controller,
since the ATA spec allows a maximum of 16 heads - this is an artifact of
virtualization.

By supplying the logical geometries directly we are able to support such
"exotic" disks.

We serialize this information in a similar way to the "bootorder"
interface.
The new fw_cfg entry is "bios-geometry".

Reviewed-by: Karl Heubaum <address@hidden>
Reviewed-by: Arbel Moshe <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: John Snow <address@hidden>


  Commit: dc237c45aee52f268369dc6a485c623f1232e1d3
      
https://github.com/qemu/qemu/commit/dc237c45aee52f268369dc6a485c623f1232e1d3
  Author: Sam Eiderman <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M tests/Makefile.include
    M tests/hd-geo-test.c

  Log Message:
  -----------
  hd-geo-test: Add tests for lchs override

Add QTest tests to check the logical geometry override option.

The tests in hd-geo-test are out of date - they only test IDE and do not
test interesting MBRs.

Creating qcow2 disks with specific size and MBR layout is currently
unused - we only use a default empty MBR.

Reviewed-by: Karl Heubaum <address@hidden>
Reviewed-by: Arbel Moshe <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: Sam Eiderman <address@hidden>
Signed-off-by: John Snow <address@hidden>


  Commit: b7c9a7f353c0e260519bf735ff0d4aa01e72784b
      
https://github.com/qemu/qemu/commit/b7c9a7f353c0e260519bf735ff0d4aa01e72784b
  Author: Peter Maydell <address@hidden>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M bootdevice.c
    M hw/block/virtio-blk.c
    M hw/ide/qdev.c
    M hw/nvram/fw_cfg.c
    M hw/scsi/scsi-bus.c
    M hw/scsi/scsi-disk.c
    M include/hw/block/block.h
    M include/hw/scsi/scsi.h
    M include/sysemu/sysemu.h
    M qemu-deprecated.texi
    M tests/Makefile.include
    M tests/hd-geo-test.c
    M tests/qemu-iotests/051.pc.out

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into 
staging

Pull request

# gpg: Signature made Thu 31 Oct 2019 15:55:44 GMT
# gpg:                using RSA key F9B7ABDBBCACDF95BE76CBD07DEF8106AAFC390E
# gpg: Good signature from "John Snow (John Huston) <address@hidden>" [full]
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* remotes/jnsnow/tags/ide-pull-request:
  hd-geo-test: Add tests for lchs override
  bootdevice: FW_CFG interface for LCHS values
  bootdevice: Refactor get_boot_devices_list
  bootdevice: Gather LCHS from all relevant devices
  scsi: Propagate unrealize() callback to scsi-hd
  bootdevice: Add interface to gather LCHS
  block: Support providing LCHS from user
  block: Refactor macros - fix tabbing
  IDE: deprecate ide-drive

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/f3cad9c6dbd4...b7c9a7f353c0
reply via email to
[Prev in Thread] Current Thread [Next in Thread]