qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 2f160e: tci: Add implementation for INDEX_op_


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 2f160e: tci: Add implementation for INDEX_op_ld16u_i64
Date: Tue, 29 Oct 2019 08:31:43 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2f160e0f9797c7522bfd0d09218d0c9340a5137c
      
https://github.com/qemu/qemu/commit/2f160e0f9797c7522bfd0d09218d0c9340a5137c
  Author: Stefan Weil <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M tcg/tci.c

  Log Message:
  -----------
  tci: Add implementation for INDEX_op_ld16u_i64

This fixes "make check-tcg" on a Debian x86_64 host.

Signed-off-by: Stefan Weil <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 4cef72d0425c34cca05f1df9796bd57a96318310
      
https://github.com/qemu/qemu/commit/4cef72d0425c34cca05f1df9796bd57a96318310
  Author: Alex Bennée <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M accel/tcg/cputlb.c
    M include/exec/cpu_ldst_template.h
    M target/cris/translate_v10.inc.c
    M tcg/tcg.h

  Log Message:
  -----------
  cputlb: ensure _cmmu helper functions follow the naming standard

We document this in docs/devel/load-stores.rst so lets follow it. The
32 bit and 64 bit access functions have historically not included the
sign so we leave those as is. We also introduce some signed helpers
which are used for loading immediate values in the translator.

Fixes: 282dffc8
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 50276a79aa15713decfede5cab183fc371e3e57d
      
https://github.com/qemu/qemu/commit/50276a79aa15713decfede5cab183fc371e3e57d
  Author: Wei Yang <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M include/exec/cpu-all.h

  Log Message:
  -----------
  cpu: use ROUND_UP() to define xxx_PAGE_ALIGN

Use ROUND_UP() to define, which is a little bit easy to read.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 7886cefe5ddd238c64d07eb037804f1aef24755c
      
https://github.com/qemu/qemu/commit/7886cefe5ddd238c64d07eb037804f1aef24755c
  Author: Richard Henderson <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M Makefile.target
    A exec-vary.c
    M exec.c
    M include/qemu-common.h

  Log Message:
  -----------
  exec: Split out variable page size support to exec-vary.c

The next patch will play a trick with "const" that will
confuse the compiler about the uses of target_page_bits
within exec.c.  Moving everything to a new file prevents
this confusion.

No functional change so far.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: db8aaae822dfdb18d993a686a146efcc63c216c0
      
https://github.com/qemu/qemu/commit/db8aaae822dfdb18d993a686a146efcc63c216c0
  Author: Richard Henderson <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Detect compiler support for __attribute__((alias))

Such support is present almost everywhere, except for Xcode 9.
It is added in Xcode 10, but travis uses xcode9 by default,
so we should support it for a while yet.

Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: bbc17caf81f94523e67c64a6e6cd8f869b7a1da5
      
https://github.com/qemu/qemu/commit/bbc17caf81f94523e67c64a6e6cd8f869b7a1da5
  Author: Richard Henderson <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M exec-vary.c
    M include/exec/cpu-all.h

  Log Message:
  -----------
  exec: Use const alias for TARGET_PAGE_BITS_VARY

Using a variable that is declared "const" for this tells the
compiler that it may read the value once and assume that it
does not change across function calls.

For target_page_size, this means we have only one assert per
function, and one read of the variable.

This reduces the size of qemu-system-aarch64 by 8k.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 639044b5f121a44909eca929d7fd6d070024b9f9
      
https://github.com/qemu/qemu/commit/639044b5f121a44909eca929d7fd6d070024b9f9
  Author: Richard Henderson <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M include/exec/cpu-all.h

  Log Message:
  -----------
  exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG

This reduces the size of a release build by about 10k.
Noticably, within the tlb miss helpers.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: f048b8a7cefcabb0e55210a76775f9be57c4d3f4
      
https://github.com/qemu/qemu/commit/f048b8a7cefcabb0e55210a76775f9be57c4d3f4
  Author: Richard Henderson <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M include/exec/cpu-all.h

  Log Message:
  -----------
  exec: Promote TARGET_PAGE_MASK to target_long

There are some uint64_t uses that expect TARGET_PAGE_MASK to
extend for a 32-bit, so this must continue to be a signed type.
Define based on TARGET_PAGE_BITS not TARGET_PAGE_SIZE; this
will make a following patch more clear.

This should not have a functional effect so far.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: bb8e3ea6fa8f616678133c9e8c8c3bf232c179ec
      
https://github.com/qemu/qemu/commit/bb8e3ea6fa8f616678133c9e8c8c3bf232c179ec
  Author: Richard Henderson <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M exec-vary.c
    M include/exec/cpu-all.h

  Log Message:
  -----------
  exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY

This eliminates a set of runtime shifts.  It turns out that we
require TARGET_PAGE_MASK more often than TARGET_PAGE_SIZE, so
redefine TARGET_PAGE_SIZE based on TARGET_PAGE_MASK instead of
the other way around.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 7f445c8c7aad0d8fca7d99a48cc8118dc82aa0f3
      
https://github.com/qemu/qemu/commit/7f445c8c7aad0d8fca7d99a48cc8118dc82aa0f3
  Author: Richard Henderson <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M accel/tcg/cputlb.c

  Log Message:
  -----------
  cputlb: Fix tlb_vaddr_to_host

Using uintptr_t instead of target_ulong meant that, for 64-bit guest
and 32-bit host, we truncated the guest address comparator and so may
not hit the tlb when we should.

Fixes: 4811e9095c0
Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 1b1940026c95b941d9cf75bd38b37fe3feaa78a7
      
https://github.com/qemu/qemu/commit/1b1940026c95b941d9cf75bd38b37fe3feaa78a7
  Author: Clement Deschamps <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M accel/tcg/translate-all.c

  Log Message:
  -----------
  translate-all: fix uninitialized tb->orig_tb

This fixes a segmentation fault in icount mode when executing
from an IO region.

TB is marked as CF_NOCACHE but tb->orig_tb is not initialized
(equals previous value in code_gen_buffer).

The issue happens in cpu_io_recompile() when it tries to invalidate orig_tb.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Clement Deschamps <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: fe9b676fb3160496b4b2bf0c57d33be724bf04c3
      
https://github.com/qemu/qemu/commit/fe9b676fb3160496b4b2bf0c57d33be724bf04c3
  Author: Richard Henderson <address@hidden>
  Date:   2019-10-28 (Mon, 28 Oct 2019)

  Changed paths:
    M accel/tcg/translate-all.c

  Log Message:
  -----------
  translate-all: Remove tb_alloc

Since 2ac01d6dafab, this function does only two things: assert a
lock is held, and call tcg_tb_alloc.  It is used exactly once,
and its user has already done the assert.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Clement Deschamps <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 8c68ff250ac3dbb63632a7e9e703c71786132147
      
https://github.com/qemu/qemu/commit/8c68ff250ac3dbb63632a7e9e703c71786132147
  Author: Peter Maydell <address@hidden>
  Date:   2019-10-29 (Tue, 29 Oct 2019)

  Changed paths:
    M Makefile.target
    M accel/tcg/cputlb.c
    M accel/tcg/translate-all.c
    M configure
    A exec-vary.c
    M exec.c
    M include/exec/cpu-all.h
    M include/exec/cpu_ldst_template.h
    M include/qemu-common.h
    M target/cris/translate_v10.inc.c
    M tcg/tcg.h
    M tcg/tci.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20191028' into staging

Improvements for TARGET_PAGE_BITS_VARY
Fix for TCI ld16u_i64.
Fix for segv on icount execute from i/o memory.
Two misc cleanups.

# gpg: Signature made Mon 28 Oct 2019 14:55:08 GMT
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Richard Henderson <address@hidden>" [full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-tcg-20191028:
  translate-all: Remove tb_alloc
  translate-all: fix uninitialized tb->orig_tb
  cputlb: Fix tlb_vaddr_to_host
  exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY
  exec: Promote TARGET_PAGE_MASK to target_long
  exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG
  exec: Use const alias for TARGET_PAGE_BITS_VARY
  configure: Detect compiler support for __attribute__((alias))
  exec: Split out variable page size support to exec-vary.c
  cpu: use ROUND_UP() to define xxx_PAGE_ALIGN
  cputlb: ensure _cmmu helper functions follow the naming standard
  tci: Add implementation for INDEX_op_ld16u_i64

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b13197b1a8b7...8c68ff250ac3



reply via email to

[Prev in Thread] Current Thread [Next in Thread]