qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 53bdbf: linux-user: add strace for dup3


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 53bdbf: linux-user: add strace for dup3
Date: Tue, 22 Oct 2019 04:02:42 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 53bdbfdf5326ad453b307c5b4bb9e71aeab29cf3
      
https://github.com/qemu/qemu/commit/53bdbfdf5326ad453b307c5b4bb9e71aeab29cf3
  Author: Andreas Schwab <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/strace.list

  Log Message:
  -----------
  linux-user: add strace for dup3

Signed-off-by: Andreas Schwab <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 1645fb5a1e537f85eda744bfa6e9d3dda047ba28
      
https://github.com/qemu/qemu/commit/1645fb5a1e537f85eda744bfa6e9d3dda047ba28
  Author: Shu-Chun Weng <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/fd-trans.c

  Log Message:
  -----------
  Fix unsigned integer underflow in fd-trans.c

In any of these `*_for_each_*` functions, the last entry in the buffer (so the
"remaining length in the buffer" `len` is equal to the length of the
entry `nlmsg_len`/`nla_len`/etc) has size that is not a multiple of the
alignment, the aligned lengths `*_ALIGN(*_len)` will be greater than `len`.
Since `len` is unsigned (`size_t`), it underflows and the loop will read
pass the buffer.

This may manifest as random EINVAL or EOPNOTSUPP error on IO or network
system calls.

Signed-off-by: Shu-Chun Weng <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 8f93089d0a3cde294e8bb16978a3f7fd0b2df2a3
      
https://github.com/qemu/qemu/commit/8f93089d0a3cde294e8bb16978a3f7fd0b2df2a3
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/strace.c

  Log Message:
  -----------
  linux-user/strace: Display invalid pointer in print_timeval()

Suggested-by: Laurent Vivier <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 6d33e036119048d3edcc3217864cf08fec2d35df
      
https://github.com/qemu/qemu/commit/6d33e036119048d3edcc3217864cf08fec2d35df
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/strace.c

  Log Message:
  -----------
  linux-user/strace: Add print_timezone()

Suggested-by: Laurent Vivier <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 0d2187c4e0256ce1f3682cda9c6aadfa445a1c48
      
https://github.com/qemu/qemu/commit/0d2187c4e0256ce1f3682cda9c6aadfa445a1c48
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/strace.c
    M linux-user/strace.list

  Log Message:
  -----------
  linux-user/strace: Improve settimeofday()

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Tested-By: Guido Günther <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: a47401bca779582139dbb4d2551b1955b0a95d4a
      
https://github.com/qemu/qemu/commit/a47401bca779582139dbb4d2551b1955b0a95d4a
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/syscall.c
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user/syscall: Introduce target_sockaddr_nl

Tested-By: Guido Günther <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 814ae70ff9d6bd842d1530521c9ca12dd984b8ae
      
https://github.com/qemu/qemu/commit/814ae70ff9d6bd842d1530521c9ca12dd984b8ae
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/strace.c

  Log Message:
  -----------
  linux-user/strace: Dump AF_NETLINK sockaddr content

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Tested-By: Guido Günther <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: d84fe1ede770444686fa49b83dbf00f5796bb9eb
      
https://github.com/qemu/qemu/commit/d84fe1ede770444686fa49b83dbf00f5796bb9eb
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/strace.c

  Log Message:
  -----------
  linux-user/strace: Add print_sockfd()

Extract common print_sockfd() from various socket related syscalls.

Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: bb10540e76e0c265a2988002117946a4b2e736af
      
https://github.com/qemu/qemu/commit/bb10540e76e0c265a2988002117946a4b2e736af
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/strace.c
    M linux-user/strace.list

  Log Message:
  -----------
  linux-user/strace: Improve bind() output

Tested-By: Guido Günther <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 42b15d70cf0f14511dcb114e18ebcb01aae61808
      
https://github.com/qemu/qemu/commit/42b15d70cf0f14511dcb114e18ebcb01aae61808
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/strace.c

  Log Message:
  -----------
  linux-user/strace: Let print_sockaddr() have a 'last' argument

If the format is not the syscall last argument, a comma is append.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 9a68960d8e7fdda16c2ea779a70f7f894ed2ce56
      
https://github.com/qemu/qemu/commit/9a68960d8e7fdda16c2ea779a70f7f894ed2ce56
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-10-21 (Mon, 21 Oct 2019)

  Changed paths:
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user/syscall: Align target_sockaddr fields using ABI types

Target architectures align types differently for instance m68k
aligns on 16bit whereas others on 32bit).
Use ABI types to keep alignments good.

Suggested-by: Laurent Vivier <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 419af24e7e492dd94a16a1691736ab48d0029a30
      
https://github.com/qemu/qemu/commit/419af24e7e492dd94a16a1691736ab48d0029a30
  Author: Peter Maydell <address@hidden>
  Date:   2019-10-22 (Tue, 22 Oct 2019)

  Changed paths:
    M linux-user/fd-trans.c
    M linux-user/strace.c
    M linux-user/strace.list
    M linux-user/syscall.c
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/linux-user-for-4.2-pull-request' into staging

sockaddr alignment fixes, strace update and fd-trans fix.

# gpg: Signature made Tue 22 Oct 2019 09:10:44 BST
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/linux-user-for-4.2-pull-request:
  linux-user/syscall: Align target_sockaddr fields using ABI types
  linux-user/strace: Let print_sockaddr() have a 'last' argument
  linux-user/strace: Improve bind() output
  linux-user/strace: Add print_sockfd()
  linux-user/strace: Dump AF_NETLINK sockaddr content
  linux-user/syscall: Introduce target_sockaddr_nl
  linux-user/strace: Improve settimeofday()
  linux-user/strace: Add print_timezone()
  linux-user/strace: Display invalid pointer in print_timeval()
  Fix unsigned integer underflow in fd-trans.c
  linux-user: add strace for dup3

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e9d42461920f...419af24e7e49



reply via email to

[Prev in Thread] Current Thread [Next in Thread]