[Qemu-commits] [qemu/qemu] 20869f: Acceptance test machine_m68k_nextcube.py: relax th...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 20869f9865b2e2571304aaee0fd269a6b598f31e
      
https://github.com/qemu/qemu/commit/20869f9865b2e2571304aaee0fd269a6b598f31e
  Author: Cleber Rosa <address@hidden>
  Date:   2019-09-20 (Fri, 20 Sep 2019)

  Changed paths:
    M tests/acceptance/machine_m68k_nextcube.py

  Log Message:
  -----------
  Acceptance test machine_m68k_nextcube.py: relax the error code pattern

Instead of looking for a specific error, let's relax the pattern
because different errors have been seen (I'm consistenly getting 52)
and the real goal of this test is to validate the framebuffer
operation, and not to reproduce one specific error.

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>


  Commit: 1840326c91756ca3ea1f9d7d00a9ad10658252b1
      
https://github.com/qemu/qemu/commit/1840326c91756ca3ea1f9d7d00a9ad10658252b1
  Author: Cleber Rosa <address@hidden>
  Date:   2019-09-20 (Fri, 20 Sep 2019)

  Changed paths:
    M tests/acceptance/x86_cpu_model_versions.py

  Log Message:
  -----------
  Acceptance test x86_cpu_model_versions: shutdown VMs

This shuts down the VMs that won't be used any longer during the
remainder of the test.

It's debatable if the very last one should also be shutdown manually,
and my opinion is that it shouldn't because that's taken care by the
immediately following tearDown().

Signed-off-by: Cleber Rosa <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: d0b63087ce97da2f9b69e9c07daefc57fd99e83e
      
https://github.com/qemu/qemu/commit/d0b63087ce97da2f9b69e9c07daefc57fd99e83e
  Author: Cleber Rosa <address@hidden>
  Date:   2019-09-20 (Fri, 20 Sep 2019)

  Changed paths:
    M tests/acceptance/x86_cpu_model_versions.py

  Log Message:
  -----------
  Acceptance test x86_cpu_model_versions: fix mismatches between test and 
messages

This fixes a few mismatches between the test and the error messages
produced in case of failures.

Signed-off-by: Cleber Rosa <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 7219c2e842019222792d4070808108e78142da7f
      
https://github.com/qemu/qemu/commit/7219c2e842019222792d4070808108e78142da7f
  Author: Cleber Rosa <address@hidden>
  Date:   2019-09-20 (Fri, 20 Sep 2019)

  Changed paths:
    M tests/acceptance/x86_cpu_model_versions.py

  Log Message:
  -----------
  Acceptance test x86_cpu_model_versions: split into smaller tests

The justifications being automatic destruction of the vm instances
when no longer needed and more compact test naming under a common
class.

Besides those, a smaller test makes the one and only assertion rather
obvious, which suggests that we could even get rid of the more verbose
(and manual) error messages (to be decided).

Naming of the tests tries to follow the following pattern:

 test_($cpu_version)_($no_arch_capabitilies_set_or_unset)_($machine_version)

The presence of each naming component is optional, depending on
whether the test manually sets it or not.

Signed-off-by: Cleber Rosa <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 07d647b26195819a8e237badb38fcb4feed90646
      
https://github.com/qemu/qemu/commit/07d647b26195819a8e237badb38fcb4feed90646
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-09-20 (Fri, 20 Sep 2019)

  Changed paths:
    M tests/acceptance/linux_ssh_mips_malta.py

  Log Message:
  -----------
  tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py

This patch restructures code organization around the test case
executions. At the same time, rather than outputing a cryptic message:

FAIL: True not found in [False],

the following will be reported too, if the command output does not meet
specified expectations:

'lspci -d 11ab:4620' output doesn't contain the word 'GT-64120'

Signed-off-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 9090d3332cdcc425643fe88bdfac21a33bb1d43d
      
https://github.com/qemu/qemu/commit/9090d3332cdcc425643fe88bdfac21a33bb1d43d
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-09-20 (Fri, 20 Sep 2019)

  Changed paths:
    M tests/acceptance/linux_ssh_mips_malta.py

  Log Message:
  -----------
  tests/acceptance: Add new test cases in linux_ssh_mips_malta.py

Add 15 new tests cases. They all rely on simple commands used for
detecting hardware configuration information.

Signed-off-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cleber Rosa <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 2fe6f4d9babb957244676fdf23b9a7ca2323034b
      
https://github.com/qemu/qemu/commit/2fe6f4d9babb957244676fdf23b9a7ca2323034b
  Author: Cleber Rosa <address@hidden>
  Date:   2019-09-20 (Fri, 20 Sep 2019)

  Changed paths:
    M tests/acceptance/linux_ssh_mips_malta.py
    M tests/requirements.txt

  Log Message:
  -----------
  Acceptance tests: use avocado.utils.ssh for SSH interaction

This replaces paramiko with avocado.utils.ssh module, which is based
on a (open)ssh binary, supposedly more ubiquitous.

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
[Cleber: consolidated existing skipUnless from tests to setUp]
Signed-off-by: Cleber Rosa <address@hidden>


  Commit: 8dc57281b80f1de11a7c114a0acb6f192b3e1a9a
      
https://github.com/qemu/qemu/commit/8dc57281b80f1de11a7c114a0acb6f192b3e1a9a
  Author: Peter Maydell <address@hidden>
  Date:   2019-09-23 (Mon, 23 Sep 2019)

  Changed paths:
    M tests/acceptance/linux_ssh_mips_malta.py
    M tests/acceptance/machine_m68k_nextcube.py
    M tests/acceptance/x86_cpu_model_versions.py
    M tests/requirements.txt

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' 
into staging

Improvements include:

 * Relaxed error code pattern on machine_m68k_nextcube.py
 * Better naming and separation of tests in x86_cpu_model_versions.py
 * New checks on guest side on linux_ssh_mips_malta.py
 * Use of avocado.utils.ssh, and thus "/usr/bin/ssh" for SSH
   interaction

# gpg: Signature made Mon 23 Sep 2019 14:38:01 BST
# gpg:                using RSA key 7ABB96EB8B46B94D5E0FE9BB657E8D33A5F209F3
# gpg: Good signature from "Cleber Rosa <address@hidden>" [marginal]
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3

* remotes/cleber/tags/python-next-pull-request:
  Acceptance tests: use avocado.utils.ssh for SSH interaction
  tests/acceptance: Add new test cases in linux_ssh_mips_malta.py
  tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py
  Acceptance test x86_cpu_model_versions: split into smaller tests
  Acceptance test x86_cpu_model_versions: fix mismatches between test and 
messages
  Acceptance test x86_cpu_model_versions: shutdown VMs
  Acceptance test machine_m68k_nextcube.py: relax the error code pattern

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2f93a3ecdd3b...8dc57281b80f