[Qemu-commits] [qemu/qemu] 26b8e6: loader: Trace loaded images

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 26b8e6dc42b9e46b76295f5613c7f7d61a78ccf0
      
https://github.com/qemu/qemu/commit/26b8e6dc42b9e46b76295f5613c7f7d61a78ccf0
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2019-09-18 (Wed, 18 Sep 2019)

  Changed paths:
    M Makefile.objs
    M hw/core/loader.c
    A hw/core/trace-events

  Log Message:
  -----------
  loader: Trace loaded images

This adds a trace point which prints every loaded image. This includes
bios/firmware/kernel/initradmdisk/pcirom.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 794dcb54b3fc3cb91d1eeb34216be3177400d6a2
      
https://github.com/qemu/qemu/commit/794dcb54b3fc3cb91d1eeb34216be3177400d6a2
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-09-18 (Wed, 18 Sep 2019)

  Changed paths:
    M hw/misc/trace-events
    M hw/scsi/trace-events
    M hw/sd/trace-events
    M nbd/trace-events
    M net/trace-events

  Log Message:
  -----------
  trace: Remove trailing newline in events

While the tracing framework does not forbid trailing newline in
events format string, using them lead to confuse output.
It is the responsibility of the backend to properly end an event
line.

Some of our formats have trailing newlines, remove them.

[Fixed typo in commit description reported by Eric Blake
<address@hidden>
--Stefan]

Reviewed-by: John Snow <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 9f7ad79c16ede0da01902b18fb32929cfbd20f87
      
https://github.com/qemu/qemu/commit/9f7ad79c16ede0da01902b18fb32929cfbd20f87
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-09-18 (Wed, 18 Sep 2019)

  Changed paths:
    M docs/devel/tracing.txt
    M scripts/tracetool/__init__.py

  Log Message:
  -----------
  trace: Forbid event format ending with newline character

Event format ending with newlines confuse the trace reports.
Forbid them.

Add a check to refuse new format added with trailing newline:

  $ make
  [...]
    GEN     hw/misc/trace.h
  Traceback (most recent call last):
    File "scripts/tracetool.py", line 152, in <module>
      main(sys.argv)
    File "scripts/tracetool.py", line 143, in main
      events.extend(tracetool.read_events(fh, arg))
    File "scripts/tracetool/__init__.py", line 367, in read_events
      event = Event.build(line)
    File "scripts/tracetool/__init__.py", line 281, in build
      raise ValueError("Event format can not end with a newline character")
  ValueError: Error at hw/misc/trace-events:121: Event format can not end with 
a newline character

Reviewed-by: John Snow <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 590c0ac982a8fc726f4784bb6e3c721661e0718a
      
https://github.com/qemu/qemu/commit/590c0ac982a8fc726f4784bb6e3c721661e0718a
  Author: Peter Maydell <address@hidden>
  Date:   2019-09-19 (Thu, 19 Sep 2019)

  Changed paths:
    M Makefile.objs
    M docs/devel/tracing.txt
    M hw/core/loader.c
    A hw/core/trace-events
    M hw/misc/trace-events
    M hw/scsi/trace-events
    M hw/sd/trace-events
    M nbd/trace-events
    M net/trace-events
    M scripts/tracetool/__init__.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' 
into staging

Pull request

# gpg: Signature made Wed 18 Sep 2019 14:17:59 BST
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>" [full]
# gpg:                 aka "Stefan Hajnoczi <address@hidden>" [full]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/tracing-pull-request:
  trace: Forbid event format ending with newline character
  trace: Remove trailing newline in events
  loader: Trace loaded images

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/7cc0cdcd6a77...590c0ac982a8