[Qemu-commits] [qemu/qemu] 2501db: MAINTAINERS: update virtio-rng and virtio-serial m...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2501db70b24255ebe6503a66a5357377bcbc12c6
      
https://github.com/qemu/qemu/commit/2501db70b24255ebe6503a66a5357377bcbc12c6
  Author: Laurent Vivier <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: update virtio-rng and virtio-serial maintainer

As discussed with Amit, I volunteer to maintain virtio-rng and virtio-serial
previously maintained by Amit.

Signed-off-by: Laurent Vivier <address@hidden>
Acked-by: Amit Shah <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: d8b92bd41822c053daa4dbf88cf36b14241a0279
      
https://github.com/qemu/qemu/commit/d8b92bd41822c053daa4dbf88cf36b14241a0279
  Author: Wei Yang <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M docs/nvdimm.txt

  Log Message:
  -----------
  docs/nvdimm: add example on persistent backend setup

Persistent backend setup requires some knowledge about nvdimm and ndctl
tool. Some users report they may struggle to gather these knowledge and
have difficulty to setup it properly.

Here we provide two examples for persistent backend and gives the link
to ndctl. By doing so, user could try it directly and do more
investigation on persistent backend setup with ndctl.

Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Pankaj Gupta <address@hidden>

Message-Id: <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: d8438bd24a3f2b6fd6d0e788c18483ca9e239b36
      
https://github.com/qemu/qemu/commit/d8438bd24a3f2b6fd6d0e788c18483ca9e239b36
  Author: Raphael Norwitz <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M hw/block/vhost-user-blk.c

  Log Message:
  -----------
  vhost-user-blk: prevent using uninitialized vqs

Same rational as: e6cc11d64fc998c11a4dfcde8fda3fc33a74d844

Of the 3 virtqueues, seabios only sets cmd, leaving ctrl
and event without a physical address. This can cause
vhost_verify_ring_part_mapping to return ENOMEM, causing
the following logs:

qemu-system-x86_64: Unable to map available ring for ring 0
qemu-system-x86_64: Verify ring failure on region 0

This has already been fixed for vhost scsi devices and was
recently vhost-user scsi devices. This commit fixes it for
vhost-user-blk devices.

Suggested-by: Phillippe Mathieu-Daude <address@hidden>
Signed-off-by: Raphael Norwitz <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>


  Commit: b8487a357855e78957d8c9bddbbcf58548e1aa51
      
https://github.com/qemu/qemu/commit/b8487a357855e78957d8c9bddbbcf58548e1aa51
  Author: Raphael Norwitz <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M backends/vhost-user.c

  Log Message:
  -----------
  backends/vhost-user.c: prevent using uninitialized vqs

Similar rational to: e6cc11d64fc998c11a4dfcde8fda3fc33a74d844

For vhost scsi and vhost-user-scsi an issue was observed
where, of the 3 virtqueues, seabios would only set cmd,
leaving ctrl and event without a physical address.
This can caused vhost_verify_ring_part_mapping to return
ENOMEM, causing the following logs:

qemu-system-x86_64: Unable to map available ring for ring 0
qemu-system-x86_64: Verify ring failure on region 0

The issue has already been fixed elsewhere, but it was noted
that in backends/vhost-user.c, the vhost_user_backend_dev_init()
function, which other vdevs use in their realize() to initialize
their vqs, was not being properly zeroing out the queues. This
commit ensures hardware modules using the
vhost_user_backend_dev_init() API properly zero out their vqs on
initialization.

Suggested-by: Philippe Mathieu-Daude <address@hidden>
Signed-off-by: Raphael Norwitz <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>


  Commit: 28cf553afeb29b0c4f339c600171552a72a68cb7
      
https://github.com/qemu/qemu/commit/28cf553afeb29b0c4f339c600171552a72a68cb7
  Author: Peter Xu <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M hw/i386/intel_iommu.c

  Log Message:
  -----------
  intel_iommu: Sanity check vfio-pci config on machine init done

This check was previously only happened when the IOMMU is enabled in
the guest.  It was always too late because the enabling of IOMMU
normally only happens during the boot of guest OS.  It means that we
can bail out and exit directly during the guest OS boots if the
configuration of devices are not supported.  Or, if the guest didn't
enable vIOMMU at all, then the user can use the guest normally but as
long as it reconfigure the guest OS to enable the vIOMMU then reboot,
the user will see the panic right after the reset when the next boot
starts.

Let's make this failure even earlier so that we force the user to use
caching-mode for vfio-pci devices when with the vIOMMU.  So the user
won't get surprise at least during execution of the guest, which seems
a bit nicer.

This will affect some user who didn't enable vIOMMU in the guest OS
but was using vfio-pci and the vtd device in the past.  However I hope
it's not a majority because not enabling vIOMMU with the device
attached is actually meaningless.

We still keep the old assertion for safety so far because the hotplug
path could still reach it, so far.

Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: d2321d31ff98b75b652c2b1594f00a4cfd48102a
      
https://github.com/qemu/qemu/commit/d2321d31ff98b75b652c2b1594f00a4cfd48102a
  Author: Peter Xu <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M hw/core/qdev.c
    M include/hw/boards.h
    M include/hw/qdev-core.h
    M qdev-monitor.c

  Log Message:
  -----------
  qdev/machine: Introduce hotplug_allowed hook

Introduce this new per-machine hook to give any machine class a chance
to do a sanity check on the to-be-hotplugged device as a sanity test.
This will be used for x86 to try to detect some illegal configuration
of devices, e.g., possible conflictions between vfio-pci and x86
vIOMMU.

Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: c6cbc29d36fe8df078776ed715c37cebac582238
      
https://github.com/qemu/qemu/commit/c6cbc29d36fe8df078776ed715c37cebac582238
  Author: Peter Xu <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M hw/i386/pc.c

  Log Message:
  -----------
  pc/q35: Disallow vfio-pci hotplug without VT-d caching mode

Instead of bailing out when trying to hotplug a vfio-pci device with
below configuration:

  -device intel-iommu,caching-mode=off

With this we can return a warning message to the user via QMP/HMP and
the VM will continue to work after failing the hotplug:

  (qemu) device_add vfio-pci,bus=root.3,host=05:00.0,id=vfio1
  Error: Device assignment is not allowed without enabling caching-mode=on for 
Intel IOMMU.

Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: e7df189e19e86bf9f4d7aea4c6cf50ac0ebfce46
      
https://github.com/qemu/qemu/commit/e7df189e19e86bf9f4d7aea4c6cf50ac0ebfce46
  Author: Peter Xu <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M hw/i386/intel_iommu.c

  Log Message:
  -----------
  intel_iommu: Remove the caching-mode check during flag change

That's never a good place to stop QEMU process... Since now we have
both the machine done sanity check and also the hotplug handler, we
can safely remove this to avoid that.

Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 5dbf335968faa45e5a1ee3083fb6816d90dc6ff3
      
https://github.com/qemu/qemu/commit/5dbf335968faa45e5a1ee3083fb6816d90dc6ff3
  Author: Pankaj Gupta <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    A docs/virtio-pmem.rst

  Log Message:
  -----------
  virtio pmem: user document

This patch documents the steps to use virtio pmem.
It also documents other useful information about
virtio pmem e.g use-case, comparison with Qemu NVDIMM
backend and current limitations.

Signed-off-by: Pankaj Gupta <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 44e687a4d9ab327761e221844ced7dc9c23350a5
      
https://github.com/qemu/qemu/commit/44e687a4d9ab327761e221844ced7dc9c23350a5
  Author: Sergio Lopez <address@hidden>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M hw/virtio/virtio-mmio.c

  Log Message:
  -----------
  virtio-mmio: implement modern (v2) personality (virtio-1)

Implement the modern (v2) personality, according to the VirtIO 1.0
specification.

Support for v2 among guests is not as widespread as it'd be
desirable. While the Linux driver has had it for a while, support is
missing, at least, from Tianocore EDK II, NetBSD and FreeBSD.

For this reason, the v2 personality is disabled, keeping the legacy
behavior as default. Machine types willing to use v2, can enable it
using MachineClass's compat_props.

Signed-off-by: Sergio Lopez <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: f39641125996550b76f9ebbfe03430aecc6473c4
      
https://github.com/qemu/qemu/commit/f39641125996550b76f9ebbfe03430aecc6473c4
  Author: Peter Maydell <address@hidden>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M MAINTAINERS
    M backends/vhost-user.c
    M docs/nvdimm.txt
    A docs/virtio-pmem.rst
    M hw/block/vhost-user-blk.c
    M hw/core/qdev.c
    M hw/i386/intel_iommu.c
    M hw/i386/pc.c
    M hw/virtio/virtio-mmio.c
    M include/hw/boards.h
    M include/hw/qdev-core.h
    M qdev-monitor.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

virtio,vhost,pc: features, fixes, cleanups.

Virtio 1.0 support for virtio-mmio.
Misc fixes, cleanups.

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Mon 16 Sep 2019 16:17:30 BST
# gpg:                using RSA key 281F0DB8D28D5469
# gpg: Good signature from "Michael S. Tsirkin <address@hidden>" [full]
# gpg:                 aka "Michael S. Tsirkin <address@hidden>" [full]
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* remotes/mst/tags/for_upstream:
  virtio-mmio: implement modern (v2) personality (virtio-1)
  virtio pmem: user document
  intel_iommu: Remove the caching-mode check during flag change
  pc/q35: Disallow vfio-pci hotplug without VT-d caching mode
  qdev/machine: Introduce hotplug_allowed hook
  intel_iommu: Sanity check vfio-pci config on machine init done
  backends/vhost-user.c: prevent using uninitialized vqs
  vhost-user-blk: prevent using uninitialized vqs
  docs/nvdimm: add example on persistent backend setup
  MAINTAINERS: update virtio-rng and virtio-serial maintainer

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/f8c3db33a5e8...f39641125996