qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 9d3019: linux-user: remove useless variable


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 9d3019: linux-user: remove useless variable
Date: Thu, 12 Sep 2019 10:09:40 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9d3019bce39efd32f54d31d4aedef27a31a15c24
      
https://github.com/qemu/qemu/commit/9d3019bce39efd32f54d31d4aedef27a31a15c24
  Author: Laurent Vivier <address@hidden>
  Date:   2019-09-10 (Tue, 10 Sep 2019)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user: remove useless variable

filename is only used to open the file if AT_EXECFD is not provided.
But exec_path already contains the path of the file to open.
Remove filename as it is only used in main.c whereas exec_path is
also used in syscall.c.

Fixes: d088d664f201 ("linux-user: identify running binary in /proc/self/exe")
Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 2041df4a050cec1efbba4f87e2bb9c40e7fd6cdf
      
https://github.com/qemu/qemu/commit/2041df4a050cec1efbba4f87e2bb9c40e7fd6cdf
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-10 (Tue, 10 Sep 2019)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: Add AT_HWCAP2 for aarch64-linux-user

Add the HWCAP2_* bits from kernel version v5.3-rc3.
Enable the bits corresponding to ARMv8.5-CondM and ARMv8.5-FRINT.

Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 895e2ef521ae0eef2fdfcec8f2108d9ee3303a81
      
https://github.com/qemu/qemu/commit/895e2ef521ae0eef2fdfcec8f2108d9ee3303a81
  Author: Shu-Chun Weng <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: erroneous fd_trans_unregister call

timer_getoverrun returns the "overrun count" for the timer, which is not
a file descriptor and thus should not call fd_trans_unregister on it.

Signed-off-by: Shu-Chun Weng <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 7f4341e84bb867c6e3397a978d3ee131bf8a889b
      
https://github.com/qemu/qemu/commit/7f4341e84bb867c6e3397a978d3ee131bf8a889b
  Author: Alex Bennée <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user: fail and report on bad dfilter specs

Just passing NULL means we end up ignoring the bad dfilter spec
instead of reporting it and exiting as we should.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 9bdfa4d23f4395dab89a60eb6b05a0308792bd66
      
https://github.com/qemu/qemu/commit/9bdfa4d23f4395dab89a60eb6b05a0308792bd66
  Author: Shu-Chun Weng <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M include/qemu/memfd.h
    M linux-user/syscall.c
    M util/memfd.c

  Log Message:
  -----------
  linux-user: add memfd_create

Add support for the memfd_create syscall. If the host does not have the
libc wrapper, translate to a direct syscall with NC-macro.

Buglink: https://bugs.launchpad.net/qemu/+bug/1734792
Signed-off-by: Shu-Chun Weng <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 8f67b9c694d01e3468e73d632324cd52a129a38b
      
https://github.com/qemu/qemu/commit/8f67b9c694d01e3468e73d632324cd52a129a38b
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/arm/target_cpu.h
    M linux-user/main.c

  Log Message:
  -----------
  linux-user: Pass CPUState to MAX_RESERVED_VA

Turn the scalar macro into a functional macro.  Move the creation
of the cpu up a bit within main() so that we can pass it to the
invocation of MAX_RESERVED_VA.  Delay the validation of the -R
parameter until MAX_RESERVED_VA is computed.

So far no changes to any of the MAX_RESERVED_VA macros to actually
use the cpu in any way, but ARM will need it.

Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 0b689da375a689efe04ad8381f607d1292471d96
      
https://github.com/qemu/qemu/commit/0b689da375a689efe04ad8381f607d1292471d96
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/arm/target_cpu.h

  Log Message:
  -----------
  linux-user/arm: Adjust MAX_RESERVED_VA for M-profile

Limit the virtual address space for M-profile cpus to 2GB,
so that we avoid all of the magic addresses in the top half
of the M-profile system map.

Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: dc12567a53c88d7a91b9d71db3775782c7f35c84
      
https://github.com/qemu/qemu/commit/dc12567a53c88d7a91b9d71db3775782c7f35c84
  Author: Josh Kunz <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: Support gdb 'qOffsets' query for ELF

This is needed to support debugging PIE ELF binaries running under QEMU
user mode. Currently, `code_offset` and `data_offset` remain unset for
all ELF binaries, so GDB is unable to correctly locate the position of
the binary's text and data.

The fields `code_offset`, and `data_offset` were originally added way
back in 2006 to support debugging of bFMT executables (978efd6aac6),
and support was just never added for ELF. Since non-PIE binaries are
loaded at exactly the address specified in the binary, GDB does not need
to relocate any symbols, so the buggy behavior is not normally observed.

http://sourceware.org/gdb/onlinedocs/gdb/General-Query-Packets.html#index-qOffsets-packet

Buglink: https://bugs.launchpad.net/qemu/+bug/1528239
Signed-off-by: Josh Kunz <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
[lv: added link to documentation]
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 130ea8322bd01b27095079632f1946d9a2120870
      
https://github.com/qemu/qemu/commit/130ea8322bd01b27095079632f1946d9a2120870
  Author: Max Filippov <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/main.c
    M linux-user/xtensa/signal.c
    M target/xtensa/cpu.c
    M target/xtensa/cpu.h

  Log Message:
  -----------
  target/xtensa: linux-user: add call0 ABI support

Xtensa binaries built for call0 ABI don't rotate register window on
function calls and returns. Invocation of signal handlers from the
kernel is therefore different in windowed and call0 ABIs.
There's currently no way to determine xtensa ELF binary ABI from the
binary itself. Add handler for the -xtensa-abi-call0 command line
parameter/QEMU_XTENSA_ABI_CALL0 envitonment variable to the qemu-user
and record ABI choice. Use it to initialize PS.WOE in xtensa_cpu_reset.
Check PS.WOE in setup_rt_frame to determine how a signal should be
delivered.

Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Max Filippov <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 1cc52740160e6b6762b1fafcd3a9fc0e498e45d0
      
https://github.com/qemu/qemu/commit/1cc52740160e6b6762b1fafcd3a9fc0e498e45d0
  Author: Max Filippov <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user: drop redundant handling of environment variables

QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to
do it again in main.

Signed-off-by: Max Filippov <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 92c096f0aabc90380b82b5604e0ee73b38317e5c
      
https://github.com/qemu/qemu/commit/92c096f0aabc90380b82b5604e0ee73b38317e5c
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/ioctls.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: Add support for RNDRESEEDCRNG ioctl

RNDRESEEDCRNG is a newer ioctl (added in kernel 4.17), and an
"ifdef" guard is used for that reason in this patch.

Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 4e4b173fa1661537bd94da9f9cea364dcbe6b2f5
      
https://github.com/qemu/qemu/commit/4e4b173fa1661537bd94da9f9cea364dcbe6b2f5
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/ioctls.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: Add support for FIOGETOWN and FIOSETOWN ioctls

FIOGETOWN and FIOSETOWN ioctls have platform-specific definitions,
hence non-standard definition in QEMU too.

Other than that, they both have a single integer argument, and their
functionality is emulated in a straightforward way.

Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: ab22b4dd749f5769e72eaf4dd368072196ef29af
      
https://github.com/qemu/qemu/commit/ab22b4dd749f5769e72eaf4dd368072196ef29af
  Author: Yunqiang Su <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/ioctls.h
    M linux-user/syscall.c
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: Add support for FDFLUSH ioctl

FDFLUSH is used for flushing buffers of floppy drives. Support in
QEMU is needed because some of Debian packages use this ioctl while
running post-build tests. One such example is 'tar' package.

Signed-off-by: Yunqiang Su <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 7e35fc8b1e59ea5189a6de63a6cab9d06d00d2be
      
https://github.com/qemu/qemu/commit/7e35fc8b1e59ea5189a6de63a6cab9d06d00d2be
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/ioctls.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: Add support for FDMSGON and FDMSGOFF ioctls

FDMSGON and FDMSGOFF switch informational messages of floppy drives
on and off.

Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 5eea942900536b76ad13bef35e1d8f276566ae9e
      
https://github.com/qemu/qemu/commit/5eea942900536b76ad13bef35e1d8f276566ae9e
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M linux-user/ioctls.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls

FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls are misc commands
for controlling a floppy drive.

Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: a30cb4b1f22c58aa3b933ee9e1d7611399b57b5b
      
https://github.com/qemu/qemu/commit/a30cb4b1f22c58aa3b933ee9e1d7611399b57b5b
  Author: Peter Maydell <address@hidden>
  Date:   2019-09-12 (Thu, 12 Sep 2019)

  Changed paths:
    M include/qemu/memfd.h
    M linux-user/arm/target_cpu.h
    M linux-user/elfload.c
    M linux-user/ioctls.h
    M linux-user/main.c
    M linux-user/syscall.c
    M linux-user/syscall_defs.h
    M linux-user/xtensa/signal.c
    M target/xtensa/cpu.c
    M target/xtensa/cpu.h
    M util/memfd.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/linux-user-for-4.2-pull-request' into staging

Add several floppy drive ioctl,
xtensa call0 ABI support, arm MAX_RESERVED_VA for M-profile,
aarch64 AT_HWCAP2, qOffsets' query for ELF, memfd_create,
and some code cleanup

# gpg: Signature made Wed 11 Sep 2019 07:48:45 BST
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/linux-user-for-4.2-pull-request:
  linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls
  linux-user: Add support for FDMSGON and FDMSGOFF ioctls
  linux-user: Add support for FDFLUSH ioctl
  linux-user: Add support for FIOGETOWN and FIOSETOWN ioctls
  linux-user: Add support for RNDRESEEDCRNG ioctl
  linux-user: drop redundant handling of environment variables
  target/xtensa: linux-user: add call0 ABI support
  linux-user: Support gdb 'qOffsets' query for ELF
  linux-user/arm: Adjust MAX_RESERVED_VA for M-profile
  linux-user: Pass CPUState to MAX_RESERVED_VA
  linux-user: add memfd_create
  linux-user: fail and report on bad dfilter specs
  linux-user: erroneous fd_trans_unregister call
  linux-user: Add AT_HWCAP2 for aarch64-linux-user
  linux-user: remove useless variable

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6d2fdde42c33...a30cb4b1f22c



reply via email to

[Prev in Thread] Current Thread [Next in Thread]