[Qemu-commits] [qemu/qemu] 69be3e: target/arm: Use store_reg_from_load in thumb2 code

[Richard Henderson]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 69be3e13764111737e1a7a13bb0c231e4d5be756
      
https://github.com/qemu/qemu/commit/69be3e13764111737e1a7a13bb0c231e4d5be756
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Use store_reg_from_load in thumb2 code

This function already includes the test for an interworking write
to PC from a load.  Change the T32 LDM implementation to match the
A32 LDM implementation.

For LDM, the reordering of the tests does not change valid
behaviour because the only case that differs is has rn == 15,
which is UNPREDICTABLE.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 51409b9e8cfe997b1ac3365df7400e0c6e844437
      
https://github.com/qemu/qemu/commit/51409b9e8cfe997b1ac3365df7400e0c6e844437
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/Makefile.objs
    A target/arm/a32-uncond.decode
    A target/arm/a32.decode
    A target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Add stubs for aa32 decodetree

Add the infrastructure that will become the new decoder.
No instructions adjusted so far.

Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 25ae32c558182c07fc6ad01b936e9151cbf00c44
      
https://github.com/qemu/qemu/commit/25ae32c558182c07fc6ad01b936e9151cbf00c44
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Data Processing (register)

Convert the register shifted by immediate form of the data
processing insns.  For A32, we cannot yet remove any code
because the legacy decoder intertwines the reg-shifted-reg
and immediate forms.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 5be2c12337f4cbdbda4efe6ab485350f730faaad
      
https://github.com/qemu/qemu/commit/5be2c12337f4cbdbda4efe6ab485350f730faaad
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Data Processing (reg-shifted-reg)

Convert the register shifted by register form of the data
processing insns.  For A32, we cannot yet remove any code
because the legacy decoder intertwines the immediate form.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 581c6ebd17c8f56ad52772216e6c6d8cc8997e8b
      
https://github.com/qemu/qemu/commit/581c6ebd17c8f56ad52772216e6c6d8cc8997e8b
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Data Processing (immediate)

Convert the modified immediate form of the data processing insns.
For A32, we can finally remove any code that was intertwined with
the register and register-shifted-register forms.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: bd92fe353bda4412ffc46c0f7415207a684b45f2
      
https://github.com/qemu/qemu/commit/bd92fe353bda4412ffc46c0f7415207a684b45f2
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert multiply and multiply accumulate

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 2409d56454f0d028619fb1002eda86bf240906dd
      
https://github.com/qemu/qemu/commit/2409d56454f0d028619fb1002eda86bf240906dd
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Simplify UMAAL

Since all of the inputs and outputs are i32, dispense with
the intermediate promotion to i64 and use tcg_gen_mulu2_i32
and tcg_gen_add2_i32.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 6d0730a82417e3a4a1911eb8e0246f3ba996f932
      
https://github.com/qemu/qemu/commit/6d0730a82417e3a4a1911eb8e0246f3ba996f932
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Saturating addition and subtraction

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 26c6923de7131fa1cf223ab67131d1992dc17001
      
https://github.com/qemu/qemu/commit/26c6923de7131fa1cf223ab67131d1992dc17001
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Halfword multiply and multiply accumulate

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: ea96b374641bc429269096d88d4e91ee544273e9
      
https://github.com/qemu/qemu/commit/ea96b374641bc429269096d88d4e91ee544273e9
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Simplify op_smlaxxx for SMLAL*

Since all of the inputs and outputs are i32, dispense with
the intermediate promotion to i64 and use tcg_gen_add2_i32.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 485b607d4f393e0de92c922806a68aef22340c98
      
https://github.com/qemu/qemu/commit/485b607d4f393e0de92c922806a68aef22340c98
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Simplify op_smlawx for SMLAW*

By shifting the 16-bit input left by 16, we can align the desired
portion of the 48-bit product and use tcg_gen_muls2_i32.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 6313059623dc512308681ba160ed862ac387e2fb
      
https://github.com/qemu/qemu/commit/6313059623dc512308681ba160ed862ac387e2fb
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert MSR (immediate) and hints

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: d0b26644502103ca97093ef67749812dc1df7eea
      
https://github.com/qemu/qemu/commit/d0b26644502103ca97093ef67749812dc1df7eea
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert MRS/MSR (banked, register)

The m-profile and a-profile decodings overlap.  Only return false
for the case of wrong profile; handle UNDEFINED for permission failure
directly.  This ensures that we don't accidentally pass an insn that
applies to the wrong profile.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 6c35d53f1bde7fe327c074473c3048d6e6f15e95
      
https://github.com/qemu/qemu/commit/6c35d53f1bde7fe327c074473c3048d6e6f15e95
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Cyclic Redundancy Check

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 4ed95abd700e43dee8e032f754b53bec2b047f75
      
https://github.com/qemu/qemu/commit/4ed95abd700e43dee8e032f754b53bec2b047f75
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert BX, BXJ, BLX (register)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 4c97f5b2f0fa9b37f9ff497f15411d809e6fd098
      
https://github.com/qemu/qemu/commit/4c97f5b2f0fa9b37f9ff497f15411d809e6fd098
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert CLZ

Document our choice about the T32 CONSTRAINED UNPREDICTABLE behaviour.
This matches the undocumented choice made by the legacy decoder.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: ef11bc3c461e2c650e8bef552146a4b08f81884e
      
https://github.com/qemu/qemu/commit/ef11bc3c461e2c650e8bef552146a4b08f81884e
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert ERET

Pass the T5 encoding of SUBS PC, LR, #IMM through the normal SUBS path
to make it clear exactly what's happening -- we hit ALUExceptionReturn
along that path.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 2cde9ea57dbc4cdee3677a1a335574537810fe2e
      
https://github.com/qemu/qemu/commit/2cde9ea57dbc4cdee3677a1a335574537810fe2e
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert the rest of A32 Miscelaneous instructions

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 145952e87fb86aaa9434d768c31eedbd323f7157
      
https://github.com/qemu/qemu/commit/145952e87fb86aaa9434d768c31eedbd323f7157
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T32 ADDW/SUBW

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 5e291fe16846d216d5a69569b1c59f497dff96e4
      
https://github.com/qemu/qemu/commit/5e291fe16846d216d5a69569b1c59f497dff96e4
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert load/store (register, immediate, literal)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 1efdd407a25f617129e2e0d5c009c07cbe847990
      
https://github.com/qemu/qemu/commit/1efdd407a25f617129e2e0d5c009c07cbe847990
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Synchronization primitives

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: af2882289951e58363d714afd16f80050685fa29
      
https://github.com/qemu/qemu/commit/af2882289951e58363d714afd16f80050685fa29
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Diagnose UNPREDICTABLE ldrex/strex cases

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 86d21e4b509a2835ed79f234f476a4c5191d435b
      
https://github.com/qemu/qemu/commit/86d21e4b509a2835ed79f234f476a4c5191d435b
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert USAD8, USADA8, SBFX, UBFX, BFC, BFI, UDF

In op_bfx, note that tcg_gen_{,s}extract_i32 already checks
for width == 32, so we don't need to special case that here.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: adf1a5662a47d5b5b96f4f1e440e34c26b14a154
      
https://github.com/qemu/qemu/commit/adf1a5662a47d5b5b96f4f1e440e34c26b14a154
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Parallel addition and subtraction

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 46497f6af73bb33c1064d43a28a48cbb4d233a23
      
https://github.com/qemu/qemu/commit/46497f6af73bb33c1064d43a28a48cbb4d233a23
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert packing, unpacking, saturation, and reversal

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 2c7c4e090409189488149869797da4acf895bad0
      
https://github.com/qemu/qemu/commit/2c7c4e090409189488149869797da4acf895bad0
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Signed multiply, signed and unsigned divide

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 8f4451274b7010c1f50e0baa5bb608f19f02b90f
      
https://github.com/qemu/qemu/commit/8f4451274b7010c1f50e0baa5bb608f19f02b90f
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert MOVW, MOVT

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: c5c426d4c680f908a1e262091a17b088b5709200
      
https://github.com/qemu/qemu/commit/c5c426d4c680f908a1e262091a17b088b5709200
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert LDM, STM

This includes a minor bug fix to LDM (user), which requires
bit 21 to be 0, which means no writeback.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 3949f4675d13c587078f8f423845a3a537a22595
      
https://github.com/qemu/qemu/commit/3949f4675d13c587078f8f423845a3a537a22595
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Diagnose writeback register in list for LDM for v7

Prior to v7, for the A32 encoding, this operation wrote an UNKNOWN
value back to the base register.  Starting in v7 this is UNPREDICTABLE.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 4b222545dbf30b60c033e1cd6eddda612575fd8c
      
https://github.com/qemu/qemu/commit/4b222545dbf30b60c033e1cd6eddda612575fd8c
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Diagnose too few registers in list for LDM/STM

This has been a TODO item for quite a while.  The minimum bit
count for A32 and T16 is 1, and for T32 is 2.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: b0e382b8cf365fed8b8c43482029ac7655961a85
      
https://github.com/qemu/qemu/commit/b0e382b8cf365fed8b8c43482029ac7655961a85
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Diagnose base == pc for LDM/STM

We have been using store_reg and not store_reg_for_load when writing
back a loaded value into the base register.  At first glance this is
incorrect when base == pc, however that case is UNPREDICTABLE.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 360144f3b99f9a626ffcc6b9d76537e3a3e0e708
      
https://github.com/qemu/qemu/commit/360144f3b99f9a626ffcc6b9d76537e3a3e0e708
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32-uncond.decode
    M target/arm/a32.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert B, BL, BLX (immediate)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 542f5188a14758d64f7504580a9bd3cae973f546
      
https://github.com/qemu/qemu/commit/542f5188a14758d64f7504580a9bd3cae973f546
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert SVC

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 885782a78c6d05932c5d8f463dc50fc8312e3eb9
      
https://github.com/qemu/qemu/commit/885782a78c6d05932c5d8f463dc50fc8312e3eb9
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32-uncond.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert RFE and SRS

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 519b84711ea36bb8a339096e207b6b9b65cd2051
      
https://github.com/qemu/qemu/commit/519b84711ea36bb8a339096e207b6b9b65cd2051
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32-uncond.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Clear-Exclusive, Barriers

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 52f83b9c68bdde8d3da5f49292d3561bd474651d
      
https://github.com/qemu/qemu/commit/52f83b9c68bdde8d3da5f49292d3561bd474651d
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32-uncond.decode
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert CPS (privileged)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 48c04a5dfaf2c08e00b659a22c502ec098999cf1
      
https://github.com/qemu/qemu/commit/48c04a5dfaf2c08e00b659a22c502ec098999cf1
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32-uncond.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert SETEND

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: beb595f657d615856fee904f1e0f74f5e1e299a3
      
https://github.com/qemu/qemu/commit/beb595f657d615856fee904f1e0f74f5e1e299a3
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32-uncond.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert PLI, PLD, PLDW

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 610f4e1764aa2049fa1711893ff62faf777813f3
      
https://github.com/qemu/qemu/commit/610f4e1764aa2049fa1711893ff62faf777813f3
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/a32-uncond.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Unallocated memory hint

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 808092bbe356eef0897476be50193d0778596877
      
https://github.com/qemu/qemu/commit/808092bbe356eef0897476be50193d0778596877
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert Table Branch

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 35d240acf1b6a89558e74b490feb13267415b236
      
https://github.com/qemu/qemu/commit/35d240acf1b6a89558e74b490feb13267415b236
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert SG

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: d449f174e820b15ca1a1f5f3ec19999eeb7da14c
      
https://github.com/qemu/qemu/commit/d449f174e820b15ca1a1f5f3ec19999eeb7da14c
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t32.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert TT

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: f843e77144c9334e244a422848177f2fbef5eb05
      
https://github.com/qemu/qemu/commit/f843e77144c9334e244a422848177f2fbef5eb05
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Simplify disas_thumb2_insn

Fold away all of the cases that now just goto illegal_op,
because all of their internal bits are now in decodetree.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 590057d969a54de5d97261701c5702b3bebc9c07
      
https://github.com/qemu/qemu/commit/590057d969a54de5d97261701c5702b3bebc9c07
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Simplify disas_arm_insn

Fold away all of the cases that now just goto illegal_op,
because all of their internal bits are now in decodetree.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: f97b454e9e7f5d018d34b5ea85a66cff016bd3b7
      
https://github.com/qemu/qemu/commit/f97b454e9e7f5d018d34b5ea85a66cff016bd3b7
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/Makefile.objs
    A target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Add skeleton for T16 decodetree

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 080c4eadcbbaf95a6fcc4668cf16e4580f2bfe11
      
https://github.com/qemu/qemu/commit/080c4eadcbbaf95a6fcc4668cf16e4580f2bfe11
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 data-processing (two low regs)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: d1d229179c6b011cc3fa124d4b6b649866470530
      
https://github.com/qemu/qemu/commit/d1d229179c6b011cc3fa124d4b6b649866470530
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 load/store (register offset)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 07afd747f9fdd79fabf3a51416c7d795f873d297
      
https://github.com/qemu/qemu/commit/07afd747f9fdd79fabf3a51416c7d795f873d297
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 load/store (immediate offset)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 1cb1323433dca657a42483b2291c1ae923a91726
      
https://github.com/qemu/qemu/commit/1cb1323433dca657a42483b2291c1ae923a91726
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 add pc/sp (immediate)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 6e8514ba408f3cc758cd47e2da5475d8684507ec
      
https://github.com/qemu/qemu/commit/6e8514ba408f3cc758cd47e2da5475d8684507ec
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 load/store multiple

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: c4d3095bb62bdac0b4f9cb180bd7aa0b40c2c270
      
https://github.com/qemu/qemu/commit/c4d3095bb62bdac0b4f9cb180bd7aa0b40c2c270
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 add/sub (3 low, 2 low and imm)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 6c6d237a865041972ec5b226657398f3b3018561
      
https://github.com/qemu/qemu/commit/6c6d237a865041972ec5b226657398f3b3018561
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 one low register and immediate

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: a0ef07740425b679d010fac7d9954ae003c1b191
      
https://github.com/qemu/qemu/commit/a0ef07740425b679d010fac7d9954ae003c1b191
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 branch and exchange

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 90aa042115a0fe39fe4cb3bcae4c4f728e2f3fdb
      
https://github.com/qemu/qemu/commit/90aa042115a0fe39fe4cb3bcae4c4f728e2f3fdb
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 add, compare, move (two high registers)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 2e6a646d7b1304d9106baad73c655132e2736c6c
      
https://github.com/qemu/qemu/commit/2e6a646d7b1304d9106baad73c655132e2736c6c
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16 adjust sp (immediate)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: e6f69612cc79e2acc05dafda8695f791a916946f
      
https://github.com/qemu/qemu/commit/e6f69612cc79e2acc05dafda8695f791a916946f
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, extract

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 20556e7bd6111266fbf1d81e4ff7a89bfa5795a7
      
https://github.com/qemu/qemu/commit/20556e7bd6111266fbf1d81e4ff7a89bfa5795a7
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, Change processor state

Add a check for ARMv6 in trans_CPS.  We had this correct in
the T16 path, but had previously forgotten the check on the
A32 and T32 paths.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: ae3002b0218a90f2088817c70b35d3832ec91c18
      
https://github.com/qemu/qemu/commit/ae3002b0218a90f2088817c70b35d3832ec91c18
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, Reverse bytes

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 56e6250ede81b4e4b4ddb623874d6c3cdad4a96d
      
https://github.com/qemu/qemu/commit/56e6250ede81b4e4b4ddb623874d6c3cdad4a96d
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, nop hints

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 279de61a21a1622cb875ead82d6e78c989ba2966
      
https://github.com/qemu/qemu/commit/279de61a21a1622cb875ead82d6e78c989ba2966
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Split gen_nop_hint

Now that all callers pass a constant value, split the switch
statement into the individual trans_* functions.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 564b125fb9dec77e5bca9b4590786985ccc3d6cb
      
https://github.com/qemu/qemu/commit/564b125fb9dec77e5bca9b4590786985ccc3d6cb
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, push and pop

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 629fcaa71ca9a5d6695d1664257b6a5327f38bd6
      
https://github.com/qemu/qemu/commit/629fcaa71ca9a5d6695d1664257b6a5327f38bd6
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, Conditional branches, Supervisor call

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 43f7e42c7d515f41ff243034f51b28267ae69938
      
https://github.com/qemu/qemu/commit/43f7e42c7d515f41ff243034f51b28267ae69938
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, Miscellaneous 16-bit instructions

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 151c2f2841b01bf6fef079c9f1db15a86cae8276
      
https://github.com/qemu/qemu/commit/151c2f2841b01bf6fef079c9f1db15a86cae8276
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, shift immediate

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 46beb58efbb8a2a32f601a041aa22801a3138ece
      
https://github.com/qemu/qemu/commit/46beb58efbb8a2a32f601a041aa22801a3138ece
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, load (literal)

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 8d4a4dc849a28aded8f335a25b223e8e3391b6f2
      
https://github.com/qemu/qemu/commit/8d4a4dc849a28aded8f335a25b223e8e3391b6f2
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, Unconditional branch

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 67b54c554b39fd24f0c3aabc546e83b3082ee7ff
      
https://github.com/qemu/qemu/commit/67b54c554b39fd24f0c3aabc546e83b3082ee7ff
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/t16.decode
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Convert T16, long branches

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 0831403b08122b5bf801b0e3469cc63f019f60f0
      
https://github.com/qemu/qemu/commit/0831403b08122b5bf801b0e3469cc63f019f60f0
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Clean up disas_thumb_insn

Now that everything is converted, remove the rest of
the legacy decode.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: eac2f39602e0423adf56be410c9a22c31fec9a81
      
https://github.com/qemu/qemu/commit/eac2f39602e0423adf56be410c9a22c31fec9a81
  Author: Richard Henderson <address@hidden>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M target/arm/translate.c

  Log Message:
  -----------
  target/arm: Inline gen_bx_im into callers

There are only two remaining uses of gen_bx_im.  In each case, we
know the destination mode -- not changing in the case of gen_jmp
or changing in the case of trans_BLX_i.  Use this to simplify the
surrounding code.

For trans_BLX_i, use gen_jmp for the actual branch.  For gen_jmp,
use gen_set_pc_im to set up the single-step.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/500efcfcf0fe...eac2f39602e0