[Qemu-commits] [qemu/qemu] 725662: audio: fix invalid malloc size in audio_create_pdos

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 725662d6dbfbbc536bb4006fbd93bcc6e82c8a34
      
https://github.com/qemu/qemu/commit/725662d6dbfbbc536bb4006fbd93bcc6e82c8a34
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-28 (Wed, 28 Aug 2019)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: fix invalid malloc size in audio_create_pdos

The code used sizeof(AudiodevAlsaPerDirectionOptions) instead of the
appropriate per direction options for the audio backend.  If the size of
the actual audiodev's per direction options are larger than alsa's, it
could cause a buffer overflow.

However, alsa has three fields in per direction options: a string, an
uint32 and a bool.  Oss has the same fields, coreaudio has a single
uint32, paaudio has a string and an uint32, all other backends only use
the common options, so currently no per direction options struct should
be larger than alsa's.

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 4b3b7793e18e1e3edb90bbc21112e875f9ff826d
      
https://github.com/qemu/qemu/commit/4b3b7793e18e1e3edb90bbc21112e875f9ff826d
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-28 (Wed, 28 Aug 2019)

  Changed paths:
    M audio/audio.c
    M qemu-deprecated.texi

  Log Message:
  -----------
  audio: omitting audiodev= parameter is only deprecated

Unfortunately, changes introduced in af2041ed2d "audio: audiodev=
parameters no longer optional when -audiodev present" breaks backward
compatibility.  This patch changes the error into a deprecation warning.

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: fec105c2abda8567ec15230429c41429b5ee307c
      
https://github.com/qemu/qemu/commit/fec105c2abda8567ec15230429c41429b5ee307c
  Author: Peter Maydell <address@hidden>
  Date:   2019-09-03 (Tue, 03 Sep 2019)

  Changed paths:
    M audio/audio.c
    M qemu-deprecated.texi

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/audio-20190828-pull-request' into staging

audio: two little fixes.

# gpg: Signature made Wed 28 Aug 2019 12:51:32 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/audio-20190828-pull-request:
  audio: omitting audiodev= parameter is only deprecated
  audio: fix invalid malloc size in audio_create_pdos

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/cc6613e244e8...fec105c2abda