[Qemu-commits] [qemu/qemu] 00f2cf: glib: bump min required glib library version to 2.48

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 00f2cfbbec63fb6f5a7789797a62ccedd22466ea
      
https://github.com/qemu/qemu/commit/00f2cfbbec63fb6f5a7789797a62ccedd22466ea
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M configure
    M crypto/hmac-glib.c
    M include/glib-compat.h

  Log Message:
  -----------
  glib: bump min required glib library version to 2.48

Per supported platforms doc[1], the various min glib on relevant distros is:

  RHEL-8: 2.56.1
  RHEL-7: 2.50.3
  Debian (Buster): 2.58.3
  Debian (Stretch): 2.50.3
  OpenBSD (Ports): 2.58.3
  FreeBSD (Ports): 2.56.3
  OpenSUSE Leap 15: 2.54.3
  SLE12-SP2: 2.48.2
  Ubuntu (Xenial): 2.48.0
  macOS (Homebrew): 2.56.0

This suggests that a minimum glib of 2.48 is a reasonable target.

Compared to the previous version bump in

  commit e7b3af81597db1a6b55f2c15d030d703c6b2c6ac
  Author: Daniel P. Berrangé <address@hidden>
  Date:   Fri May 4 15:34:46 2018 +0100

    glib: bump min required glib library version to 2.40

This will result in us dropping support for Debian Jessie and
Ubuntu 14.04.

As per the commit message 14.04 was already outside our list
of supported build platforms and an exception was only made
because one of the build hosts used during merge testing was
stuck on 14.04.

Debian Jessie is justified to drop because we only aim to
support at most 2 major versions of Debian at any time. This
means Buster and Stretch at this time.

The g_strv_contains compat code is dropped as this API is
present since 2.44

The g_assert_cmpmem compat code is dropped as this API is
present since 2.46

[1] https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms

Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 133cf1e5b1a9a3cc6f1e47e5edad67d000259dd6
      
https://github.com/qemu/qemu/commit/133cf1e5b1a9a3cc6f1e47e5edad67d000259dd6
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M include/crypto/block.h
    M include/crypto/cipher.h
    M include/crypto/hmac.h
    M include/crypto/ivgen.h
    M include/crypto/tlssession.h

  Log Message:
  -----------
  crypto: define cleanup functions for use with g_autoptr

Allow crypto structs to be used with g_autoptr, avoiding the need to
explicitly call XXX_free() functions when variables go out of scope on
the stack.

Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 57b9f113fce2a2231a47e9295c1d461e9ff7f0f7
      
https://github.com/qemu/qemu/commit/57b9f113fce2a2231a47e9295c1d461e9ff7f0f7
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M crypto/afsplit.c
    M crypto/block-luks.c
    M crypto/block.c
    M crypto/pbkdf.c
    M crypto/secret.c
    M crypto/tlscredsanon.c
    M crypto/tlscredspsk.c
    M crypto/tlscredsx509.c

  Log Message:
  -----------
  crypto: use auto cleanup for many stack variables

Simplify cleanup paths by using glib's auto cleanup macros for stack
variables, allowing several goto jumps / labels to be eliminated.

Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 3590b27c7a2be7a24b4b265e2e9458b3761103e1
      
https://github.com/qemu/qemu/commit/3590b27c7a2be7a24b4b265e2e9458b3761103e1
  Author: Peter Maydell <address@hidden>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M configure
    M crypto/afsplit.c
    M crypto/block-luks.c
    M crypto/block.c
    M crypto/hmac-glib.c
    M crypto/pbkdf.c
    M crypto/secret.c
    M crypto/tlscredsanon.c
    M crypto/tlscredspsk.c
    M crypto/tlscredsx509.c
    M include/crypto/block.h
    M include/crypto/cipher.h
    M include/crypto/hmac.h
    M include/crypto/ivgen.h
    M include/crypto/tlssession.h
    M include/glib-compat.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/berrange/tags/autofree-pull-request' 
into staging

require newer glib2 to enable autofree'ing of stack variables exiting scope

* Bump minium glib2 version to 2.48
* Convert much of the crypto code to use automatic memory free functions

# gpg: Signature made Thu 22 Aug 2019 11:51:59 BST
# gpg:                using RSA key DAF3A6FDB26B62912D0E8E3FBE86EBB415104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>" [full]
# gpg:                 aka "Daniel P. Berrange <address@hidden>" [full]
# Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E  8E3F BE86 EBB4 1510 4FDF

* remotes/berrange/tags/autofree-pull-request:
  crypto: use auto cleanup for many stack variables
  crypto: define cleanup functions for use with g_autoptr
  glib: bump min required glib library version to 2.48

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d013d220c710...3590b27c7a2b