qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] e46349: audio: Add missing fall through comme


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] e46349: audio: Add missing fall through comments
Date: Wed, 21 Aug 2019 08:58:09 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: e4634941457022b284664bacae9a3320481b1756
      
https://github.com/qemu/qemu/commit/e4634941457022b284664bacae9a3320481b1756
  Author: Stefan Weil <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: Add missing fall through comments

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 526fb0581e1164ccf5e6d1a81b5da538594ae4d6
      
https://github.com/qemu/qemu/commit/526fb0581e1164ccf5e6d1a81b5da538594ae4d6
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/audio.c
    M audio/audio_int.h
    M audio/audio_template.h

  Log Message:
  -----------
  audio: reduce glob_audio_state usage

Remove glob_audio_state from functions, where possible without breaking
the API.  This means that most static functions in audio.c now take an
AudioState pointer instead of implicitly using glob_audio_state.  Also
included a pointer in SWVoice*, HWVoice* structs, so that functions
dealing them can know the audio state without having to pass it around
separately.

This is required in order to support multiple simultaneous audio
backends (added in a later commit).

Signed-off-by: Kővágó, Zoltán <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: ecd97e9592fefc5083f0d70fefadd42a1742a65f
      
https://github.com/qemu/qemu/commit/ecd97e9592fefc5083f0d70fefadd42a1742a65f
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/audio.c
    M audio/audio.h
    M audio/audio_int.h
    M audio/audio_template.h
    M audio/wavcapture.c
    M monitor/misc.c
    M ui/vnc.c

  Log Message:
  -----------
  audio: basic support for multi backend audio

Audio functions no longer access glob_audio_state, instead they get an
AudioState as a parameter.  This is required in order to support
multiple backends.

glob_audio_state is also gone, and replaced with a tailq so we can store
more than one states.

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f0b9f36d71a373d469da9feb133c91546d37643c
      
https://github.com/qemu/qemu/commit/f0b9f36d71a373d469da9feb133c91546d37643c
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M hmp-commands.hx
    M monitor/misc.c
    M qemu-options.hx
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  audio: add audiodev property to vnc and wav_capture

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 88e47b9a450f6dabc3429a4d2c421408b07d22bb
      
https://github.com/qemu/qemu/commit/88e47b9a450f6dabc3429a4d2c421408b07d22bb
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/audio.h
    M hw/audio/ac97.c
    M hw/audio/adlib.c
    M hw/audio/cs4231a.c
    M hw/audio/es1370.c
    M hw/audio/gus.c
    M hw/audio/hda-codec.c
    M hw/audio/milkymist-ac97.c
    M hw/audio/pcspk.c
    M hw/audio/pl041.c
    M hw/audio/sb16.c
    M hw/audio/wm8750.c
    M hw/core/qdev-properties-system.c
    M hw/usb/dev-audio.c
    M include/hw/qdev-properties.h

  Log Message:
  -----------
  audio: add audiodev properties to frontends

Finally add audiodev= options to audio frontends so users can specify
which backend to use when multiple backends exist.  Not specifying an
audiodev= option currently causes the first audiodev to be used, this is
fixed in the next commit.

Example usage: -audiodev pa,id=foo -device AC97,audiodev=foo

Signed-off-by: Kővágó, Zoltán <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 9d34e6d8a1a1db44d882cc307a0e6ebb7a406e28
      
https://github.com/qemu/qemu/commit/9d34e6d8a1a1db44d882cc307a0e6ebb7a406e28
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: prepare for multiple audiodev

Have a pool of refcounted connections per server, so if the user creates
multiple audiodevs to the same pa server, it will use a single connection.  (It
will still create different streams, so the user can manage those streams
separately in pulseaudio.)

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: af2041ed2d659923b997333c0a4472afaf9cb19f
      
https://github.com/qemu/qemu/commit/af2041ed2d659923b997333c0a4472afaf9cb19f
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: audiodev= parameters no longer optional when -audiodev present

This means you should probably stop using -soundhw (as it doesn't allow
you to specify any options) and add the device manually with -device.
The exception is pcspk, it's currently not possible to manually add it.
To use it with audiodev, use something like this:

    -audiodev id=foo,... -global isa-pcspk.audiodev=foo -soundhw pcspk

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 8a435f74780dccc7d52ddffff69230492e410c1d
      
https://github.com/qemu/qemu/commit/8a435f74780dccc7d52ddffff69230492e410c1d
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: do not move stream when sink/source name is specified

Unless we disable stream moving, pulseaudio can easily move the stream
on connect, effectively ignoring the source/sink specified by the user.

Signed-off-by: Kővágó, Zoltán <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 8692bf7d978aee2329d9449e31043451a8fdb357
      
https://github.com/qemu/qemu/commit/8692bf7d978aee2329d9449e31043451a8fdb357
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: properly disconnect streams in fini_*

Currently this needs a workaround due to bug #247 in pulseaudio.

Signed-off-by: Kővágó, Zoltán <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 589359150365616de479866f8bc594c876480bd8
      
https://github.com/qemu/qemu/commit/589359150365616de479866f8bc594c876480bd8
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/alsaaudio.c
    M audio/audio.c
    M audio/audio.h
    M audio/coreaudio.c
    M audio/dsoundaudio.c
    M audio/noaudio.c
    M audio/ossaudio.c
    M audio/paaudio.c
    M audio/sdlaudio.c
    M audio/spiceaudio.c
    M audio/wavaudio.c
    M hw/audio/ac97.c
    M hw/audio/adlib.c
    M hw/audio/cs4231a.c
    M hw/audio/es1370.c
    M hw/audio/gus.c
    M hw/audio/hda-codec.c
    M hw/audio/milkymist-ac97.c
    M hw/audio/pcspk.c
    M hw/audio/sb16.c
    M hw/audio/wm8750.c

  Log Message:
  -----------
  audio: remove audio_MIN, audio_MAX

There's already a MIN and MAX macro in include/qemu/osdep.h, use them
instead.

Signed-off-by: Kővágó, Zoltán <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 18e2c1771b693fd55d5f5967e20ef075a19d4667
      
https://github.com/qemu/qemu/commit/18e2c1771b693fd55d5f5967e20ef075a19d4667
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/alsaaudio.c
    M audio/audio.c
    M audio/audio_int.h
    M audio/ossaudio.c

  Log Message:
  -----------
  audio: do not run each backend in audio_run

audio_run is called manually by alsa and oss backends when polling.
In this case only the requesting backend should be run, not all of them.

Signed-off-by: Kővágó, Zoltán <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 10d5e750dcf9059c9039aa66efbdc5730a9cd324
      
https://github.com/qemu/qemu/commit/10d5e750dcf9059c9039aa66efbdc5730a9cd324
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: fix playback glitches

Pulseaudio normally assumes that when the server wants it, the client
can generate the audio samples and send it right away.  Unfortunately
this is not the case with QEMU -- it's up to the emulated system when
does it generate the samples.  Buffering the samples and sending them
from a background thread is just a workaround, that doesn't work too
well.  Instead enable pa's compatibility support and let pa worry about
the details.

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 1d793fec6cc4b1a6234e70da36be8d6b00aa250b
      
https://github.com/qemu/qemu/commit/1d793fec6cc4b1a6234e70da36be8d6b00aa250b
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/alsaaudio.c
    M audio/audio.c
    M audio/audio_int.h
    M audio/coreaudio.c
    M audio/dsoundaudio.c
    M audio/noaudio.c
    M audio/ossaudio.c
    M audio/paaudio.c
    M audio/sdlaudio.c
    M audio/spiceaudio.c
    M audio/wavaudio.c

  Log Message:
  -----------
  audio: remove read and write pcm_ops

They just called audio_pcm_sw_read/write anyway, so it makes no sense
to have them too.  (The noaudio's read is the only exception, but it
should work with the generic code too.)

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 7520462bc1eeda2f724ec84ff16338053b728920
      
https://github.com/qemu/qemu/commit/7520462bc1eeda2f724ec84ff16338053b728920
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/alsaaudio.c
    M audio/audio.c
    M audio/audio.h
    M audio/audio_int.h
    M audio/audio_template.h
    M audio/coreaudio.c
    M audio/dsoundaudio.c
    M audio/mixeng.h
    M audio/noaudio.c
    M audio/ossaudio.c
    M audio/paaudio.c
    M audio/rate_template.h
    M audio/sdlaudio.c
    M audio/spiceaudio.c
    M audio/wavaudio.c
    M include/sysemu/replay.h
    M replay/replay-audio.c
    M replay/replay.c

  Log Message:
  -----------
  audio: use size_t where makes sense

Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e76ba19a1f1377314573a6df7e2d82b597aa3d0a
      
https://github.com/qemu/qemu/commit/e76ba19a1f1377314573a6df7e2d82b597aa3d0a
  Author: Kővágó, Zoltán <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: fix memory leak reported by ASAN

Signed-off-by: Kővágó, Zoltán <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 33f18cf7dca7741d3647d514040904ce83edd73d
      
https://github.com/qemu/qemu/commit/33f18cf7dca7741d3647d514040904ce83edd73d
  Author: Peter Maydell <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M audio/alsaaudio.c
    M audio/audio.c
    M audio/audio.h
    M audio/audio_int.h
    M audio/audio_template.h
    M audio/coreaudio.c
    M audio/dsoundaudio.c
    M audio/mixeng.h
    M audio/noaudio.c
    M audio/ossaudio.c
    M audio/paaudio.c
    M audio/rate_template.h
    M audio/sdlaudio.c
    M audio/spiceaudio.c
    M audio/wavaudio.c
    M audio/wavcapture.c
    M hmp-commands.hx
    M hw/audio/ac97.c
    M hw/audio/adlib.c
    M hw/audio/cs4231a.c
    M hw/audio/es1370.c
    M hw/audio/gus.c
    M hw/audio/hda-codec.c
    M hw/audio/milkymist-ac97.c
    M hw/audio/pcspk.c
    M hw/audio/pl041.c
    M hw/audio/sb16.c
    M hw/audio/wm8750.c
    M hw/core/qdev-properties-system.c
    M hw/usb/dev-audio.c
    M include/hw/qdev-properties.h
    M include/sysemu/replay.h
    M monitor/misc.c
    M qemu-options.hx
    M replay/replay-audio.c
    M replay/replay.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/audio-20190821-pull-request' into staging

audio: second batch of -audiodev support, adding support for multiple backends.

# gpg: Signature made Wed 21 Aug 2019 09:40:37 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/audio-20190821-pull-request:
  audio: fix memory leak reported by ASAN
  audio: use size_t where makes sense
  audio: remove read and write pcm_ops
  paaudio: fix playback glitches
  audio: do not run each backend in audio_run
  audio: remove audio_MIN, audio_MAX
  paaudio: properly disconnect streams in fini_*
  paaudio: do not move stream when sink/source name is specified
  audio: audiodev= parameters no longer optional when -audiodev present
  paaudio: prepare for multiple audiodev
  audio: add audiodev properties to frontends
  audio: add audiodev property to vnc and wav_capture
  audio: basic support for multi backend audio
  audio: reduce glob_audio_state usage
  audio: Add missing fall through comments

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e65472c7bc41...33f18cf7dca7



reply via email to

[Prev in Thread] Current Thread [Next in Thread]