[Qemu-commits] [qemu/qemu] 676d1f: tests/vm: avoid extra compressed imag

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 676d1f: tests/vm: avoid extra compressed imag

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] 676d1f: tests/vm: avoid extra compressed image copy
Date:	Fri, 05 Jul 2019 05:33:14 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 676d1f3e2f4667ead88cb719db0581f396fc60bf
      
https://github.com/qemu/qemu/commit/676d1f3e2f4667ead88cb719db0581f396fc60bf
  Author: Cleber Rosa <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/centos
    M tests/vm/freebsd
    M tests/vm/netbsd
    M tests/vm/openbsd

  Log Message:
  -----------
  tests/vm: avoid extra compressed image copy

The image copy is only really needed because xz doesn't know to
properly decompress a file not named properly.  Instead of
decompressing to stdout, and having to rely on a shell, let's just
create a link instead of copying the file.

Signed-off-by: Cleber Rosa <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: fcd2060e8efff83b7bdef04323077f87e011fdc4
      
https://github.com/qemu/qemu/commit/fcd2060e8efff83b7bdef04323077f87e011fdc4
  Author: Cleber Rosa <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/centos
    M tests/vm/freebsd
    M tests/vm/netbsd
    M tests/vm/openbsd
    M tests/vm/ubuntu.i386

  Log Message:
  -----------
  tests/vm: avoid image presence check and removal

Python's os.rename() will silently replace an existing file,
so there's no need for the extra check and removal.

Reference: https://docs.python.org/3/library/os.html#os.rename

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 40309abb65bed0f14dbb734bee3532664edfd1e6
      
https://github.com/qemu/qemu/commit/40309abb65bed0f14dbb734bee3532664edfd1e6
  Author: Cleber Rosa <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/ubuntu.i386

  Log Message:
  -----------
  tests/vm: pin ubuntu.i386 image

It's a good practice to always have the same components used in tests.
According to:

   https://cloud-images.ubuntu.com/releases/16.04/

New images are released from time to time, and the "release/"
directory points to the latest release.  Let's pin to the latest
available version, and while at it, set a hash for verification.

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 95c44c250dfc31da2df315fbe16bd1ea767aba66
      
https://github.com/qemu/qemu/commit/95c44c250dfc31da2df315fbe16bd1ea767aba66
  Author: Cleber Rosa <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/ubuntu.i386

  Log Message:
  -----------
  tests/vm: add source repos on ubuntu.i386

Possibly because of different behavior on the newly update
cloud-image, trying to run 'apt-get build-dep' results in:

   E: You must put some 'source' URIs in your sources.list

This enables all source repos (even though some are not
needed) for simplicity sake.

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: b08ba163aaae37003e515376d760b282a0111213
      
https://github.com/qemu/qemu/commit/b08ba163aaae37003e515376d760b282a0111213
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/basevm.py

  Log Message:
  -----------
  tests/vm: send proxy environment variables over ssh

Packages are fetched via proxy that way, if configured on the host.
That might be required to pass firewalls, and it allows to route
package downloads through a caching proxy server.

Needs AcceptEnv setup in sshd_config on the guest side to work.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 796471e9756982f534c3fe1444a42a021d3d21d4
      
https://github.com/qemu/qemu/commit/796471e9756982f534c3fe1444a42a021d3d21d4
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/basevm.py

  Log Message:
  -----------
  tests/vm: use ssh with pty unconditionally

Allways ask ssh to run with a pseudo terminal.
Not having a terminal causes problems now and then.

Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 7f71d5051ef98427a4d2d73b952e7073de314083
      
https://github.com/qemu/qemu/commit/7f71d5051ef98427a4d2d73b952e7073de314083
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/Makefile.include

  Log Message:
  -----------
  tests/vm: run test builds on snapshot

The build script doesn't shutdown the guest VMs properly,
which results in filesystem corruption and guest boot
failures sooner or later.

Use the --snapshot to run builds on a snapshot,
That way killing the VM doesn't corrupt the base image.

Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Acked-by: Ed Maste <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
[AJB: added tags]
Signed-off-by: Alex Bennée <address@hidden>


  Commit: b3f94b2f46222f088eef898a8eb51553e25be3fa
      
https://github.com/qemu/qemu/commit/b3f94b2f46222f088eef898a8eb51553e25be3fa
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/basevm.py

  Log Message:
  -----------
  tests/vm: proper guest shutdown

When not running in snapshot mode ask the guest to poweroff and wait for
this to finish instead of simply quitting qemu, so the guest can flush
pending updates to disk.

Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: b1210f027883213638496ad2cb0b1878f0535251
      
https://github.com/qemu/qemu/commit/b1210f027883213638496ad2cb0b1878f0535251
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/Makefile.include

  Log Message:
  -----------
  tests/vm: add vm-boot-{ssh,serial}-<guest> targets

For testing/troubleshooting convenience.

make vm-boot-serial-<guest>
  Boot guest, with the serial console on stdio.

make vm-boot-ssh-<guest>
  Boot guest, login via ssh.

Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
[AJB: added tags]
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 8dd3833410c29dab1a2f63af2ab71f71f8ccccfc
      
https://github.com/qemu/qemu/commit/8dd3833410c29dab1a2f63af2ab71f71f8ccccfc
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/basevm.py

  Log Message:
  -----------
  tests/vm: serial console support helpers

Add a bunch of helpers to talk to the guest using the
serial console.

Also drop the hard-coded -serial parameter for the vm
so QEMUMachine.set_console() actually works.

Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
[AJB: added tags]
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 12745eaa02f4e4bd730126388a83e14ebe576f34
      
https://github.com/qemu/qemu/commit/12745eaa02f4e4bd730126388a83e14ebe576f34
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/openbsd

  Log Message:
  -----------
  tests/vm: openbsd autoinstall, using serial console

Instead of fetching the prebuilt image from patchew download the install
iso and prepare the image locally.  Install to disk, using the serial
console.  Create qemu user, configure ssh login.  Install packages
needed for qemu builds.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
[AJB: added tags]
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 918fb8fa41236f5002351d3993ae998a5c9568f5
      
https://github.com/qemu/qemu/commit/918fb8fa41236f5002351d3993ae998a5c9568f5
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/freebsd

  Log Message:
  -----------
  tests/vm: freebsd autoinstall, using serial console

Instead of fetching the prebuilt image from patchew download the install
iso and prepare the image locally.  Install to disk, using the serial
console.  Create qemu user, configure ssh login.  Install packages
needed for qemu builds.

Note that freebsd package downloads are delivered as non-cachable
content, so I had to configure squid with "ignore-no-store
ignore-private ignore-reload" for pkgmir.geo.freebsd.org to make the
caching actually work.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 60136e06ea5fcbae228921841a07882f080294c3
      
https://github.com/qemu/qemu/commit/60136e06ea5fcbae228921841a07882f080294c3
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/Makefile.include
    M tests/vm/basevm.py
    A tests/vm/fedora

  Log Message:
  -----------
  tests/vm: fedora autoinstall, using serial console

Download the install iso and prepare the image locally.  Install to
disk, using the serial console.  Create qemu user, configure ssh login.
Install packages needed for qemu builds.

Yes, we have docker images for fedora.  But for trouble-shooting it
might be helpful to have a vm too.  When vm builds fail you can use
it to figure whenever the vm setup or the guest os is the problem.

Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: c9b423d6d3fde0132ee6f31d69a1c1370a89ce1a
      
https://github.com/qemu/qemu/commit/c9b423d6d3fde0132ee6f31d69a1c1370a89ce1a
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M tests/vm/ubuntu.i386

  Log Message:
  -----------
  tests/vm: ubuntu.i386: apt proxy setup

Configure apt proxy so package downloads
can be cached and can pass firewalls.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: c3c1874a9978bb993c4cdf86a020f936e9ad9c61
      
https://github.com/qemu/qemu/commit/c3c1874a9978bb993c4cdf86a020f936e9ad9c61
  Author: Alex Bennée <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  .travis.yml: default the --disable-system build to --static

It's fairly common to build qemu-user binaries with --static linking
so the binary can be copied around without libraries. Enable --static
in the default qemu-user build to cover this.

There are other qemu-user builds that use dynamic linking so they
should catch any problems there.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 71451cff5e11befa1bd4640d9b3ed78600958653
      
https://github.com/qemu/qemu/commit/71451cff5e11befa1bd4640d9b3ed78600958653
  Author: Alex Bennée <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  .travis.yml: force a brew update for MacOS builds

It looks like the Travis image package databases are out of date
causing the build to error with:

  Error: Your Homebrew is outdated. Please run `brew update`.
  Error: Kernel.exit

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 4f2f62762f8119886fbb65920931613cd87840b3
      
https://github.com/qemu/qemu/commit/4f2f62762f8119886fbb65920931613cd87840b3
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M Makefile
    M docs/devel/testing.rst
    M tests/vm/Makefile.include

  Log Message:
  -----------
  Makefile: Rename the 'vm-test' target as 'vm-help'

We already have 'make check-help', use the 'make vm-help' form
to display helps about VM testing. Keep the old target to not
bother old customs.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 4cdf03e21ea9d00d988b210864f44cfef29d5919
      
https://github.com/qemu/qemu/commit/4cdf03e21ea9d00d988b210864f44cfef29d5919
  Author: Alex Bennée <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M target/i386/hyperv-stub.c

  Log Message:
  -----------
  target/i386: fix feature check in hyperv-stub.c

Commit 2d384d7c8 broken the build when built with:

  configure --without-default-devices --disable-user

The reason was the conversion of cpu->hyperv_synic to
cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
hyperv-stub to do the same feature check as in the real hyperv.c

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Roman Kagan <address@hidden>
Reviewed-by: Vitaly Kuznetsov <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>


  Commit: 1f4abd81f7dfeb9d622b37368bef22a6481ebc66
      
https://github.com/qemu/qemu/commit/1f4abd81f7dfeb9d622b37368bef22a6481ebc66
  Author: Alex Bennée <address@hidden>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M migration/rdma.c

  Log Message:
  -----------
  migration: move port_attr inside CONFIG_LINUX

Otherwise the FreeBSD compiler complains about an unused variable.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>


  Commit: 0050f9978e47182270c0536906abfd3e9fa91dea
      
https://github.com/qemu/qemu/commit/0050f9978e47182270c0536906abfd3e9fa91dea
  Author: Peter Maydell <address@hidden>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M .travis.yml
    M Makefile
    M docs/devel/testing.rst
    M migration/rdma.c
    M target/i386/hyperv-stub.c
    M tests/vm/Makefile.include
    M tests/vm/basevm.py
    M tests/vm/centos
    A tests/vm/fedora
    M tests/vm/freebsd
    M tests/vm/netbsd
    M tests/vm/openbsd
    M tests/vm/ubuntu.i386

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-testing-next-050719-3' into staging

Various testing fixes:

   - tests/vm updates and clean-ups
   - tests/vm serial autobuild on host (-netbsd v3)
   - ensure MacOS builds do "brew update"
   - ensure we test --static user builds
   - fix hyperv compile failure
   - fix missing var warning for OpenBSD (v2)

This brings my testing back to green on all CI services. Please note
the BSD installs will throw out some warnings during the setup phase.
They shouldn't re-occur once the images are built. NetBSD has been
dropped for now given slow install issues.

# gpg: Signature made Fri 05 Jul 2019 11:15:21 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) <address@hidden>" 
[full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-testing-next-050719-3:
  migration: move port_attr inside CONFIG_LINUX
  target/i386: fix feature check in hyperv-stub.c
  Makefile: Rename the 'vm-test' target as 'vm-help'
  .travis.yml: force a brew update for MacOS builds
  .travis.yml: default the --disable-system build to --static
  tests/vm: ubuntu.i386: apt proxy setup
  tests/vm: fedora autoinstall, using serial console
  tests/vm: freebsd autoinstall, using serial console
  tests/vm: openbsd autoinstall, using serial console
  tests/vm: serial console support helpers
  tests/vm: add vm-boot-{ssh,serial}-<guest> targets
  tests/vm: proper guest shutdown
  tests/vm: run test builds on snapshot
  tests/vm: use ssh with pty unconditionally
  tests/vm: send proxy environment variables over ssh
  tests/vm: add source repos on ubuntu.i386
  tests/vm: pin ubuntu.i386 image
  tests/vm: avoid image presence check and removal
  tests/vm: avoid extra compressed image copy

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c35d17cabc1e...0050f9978e47
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 676d1f: tests/vm: avoid extra compressed image copy, Peter Maydell <=
Prev by Date: [Qemu-commits] [qemu/qemu] 861dc7: pcie: don't skip multi-mask events
Next by Date: [Qemu-commits] [qemu/qemu] c799d2: ati-vga: Improve readability of ati_2d_blt function
Previous by thread: [Qemu-commits] [qemu/qemu] 861dc7: pcie: don't skip multi-mask events
Next by thread: [Qemu-commits] [qemu/qemu] c799d2: ati-vga: Improve readability of ati_2d_blt function
Index(es):
- Date
- Thread