[Qemu-commits] [qemu/qemu] 3412d8: vfio/pci: Hide Resizable BAR capability

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3412d8ec9810b819f8b79e8e0c6b87217c876e32
      
https://github.com/qemu/qemu/commit/3412d8ec9810b819f8b79e8e0c6b87217c876e32
  Author: Alex Williamson <address@hidden>
  Date:   2019-06-13 (Thu, 13 Jun 2019)

  Changed paths:
    M hw/vfio/pci.c

  Log Message:
  -----------
  vfio/pci: Hide Resizable BAR capability

The resizable BAR capability is currently exposed read-only from the
kernel and we don't yet implement a protocol for virtualizing it to
the VM.  Exposing it to the guest read-only introduces poor behavior
as the guest has no reason to test that a control register write is
accepted by the hardware.  This can lead to cases where the guest OS
assumes the BAR has been resized, but it hasn't.  This has been
observed when assigning AMD Vega GPUs.

Note, this does not preclude future enablement of resizable BARs, but
it's currently incorrect to expose this capability as read-only, so
better to not expose it at all.

Reported-by: James Courtier-Dutton <address@hidden>
Tested-by: James Courtier-Dutton <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: c60807dea5930a402b77172da17e79b26f1af48b
      
https://github.com/qemu/qemu/commit/c60807dea5930a402b77172da17e79b26f1af48b
  Author: Alex Williamson <address@hidden>
  Date:   2019-06-13 (Thu, 13 Jun 2019)

  Changed paths:
    M hw/vfio/pci.c

  Log Message:
  -----------
  vfio/pci: Allow MSI-X relocation to fixup bogus PBA

The MSI-X relocation code can sometimes be used to work around bogus
MSI-X capabilities, but this test for whether the PBA is outside of
the specified BAR causes the device to error before we can apply a
relocation.  Let it proceed if we intend to relocate MSI-X anyway.

Signed-off-by: Alex Williamson <address@hidden>


  Commit: 201a733145751aa691e7e3b9c0f263f0c92db0c5
      
https://github.com/qemu/qemu/commit/201a733145751aa691e7e3b9c0f263f0c92db0c5
  Author: Eric Auger <address@hidden>
  Date:   2019-06-13 (Thu, 13 Jun 2019)

  Changed paths:
    M hw/vfio/common.c
    M hw/vfio/pci.c
    M hw/vfio/platform.c
    M include/hw/vfio/vfio-common.h

  Log Message:
  -----------
  vfio/common: Introduce vfio_set_irq_signaling helper

The code used to assign an interrupt index/subindex to an
eventfd is duplicated many times. Let's introduce an helper that
allows to set/unset the signaling for an ACTION_TRIGGER,
ACTION_MASK or ACTION_UNMASK action.

In the error message, we now use errno in case of any
VFIO_DEVICE_SET_IRQS ioctl failure.

Signed-off-by: Eric Auger <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Li Qiang <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 5ec2eca83dc478ddf24077e02a8b34dd26cd3ff9
      
https://github.com/qemu/qemu/commit/5ec2eca83dc478ddf24077e02a8b34dd26cd3ff9
  Author: Peter Maydell <address@hidden>
  Date:   2019-06-14 (Fri, 14 Jun 2019)

  Changed paths:
    M hw/vfio/common.c
    M hw/vfio/pci.c
    M hw/vfio/platform.c
    M include/hw/vfio/vfio-common.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20190613.0' 
into staging

VFIO updates 2019-06-13

 - Hide resizable BAR capability to prevent false guest resizing
   (Alex Williamson)

 - Allow relocation to fix bogus MSI-X hardware (Alex Williamson)

 - Condense IRQ setup into a common helper (Eric Auger)

# gpg: Signature made Thu 13 Jun 2019 18:24:43 BST
# gpg:                using RSA key 239B9B6E3BB08B22
# gpg: Good signature from "Alex Williamson <address@hidden>" [full]
# gpg:                 aka "Alex Williamson <address@hidden>" [full]
# gpg:                 aka "Alex Williamson <address@hidden>" [full]
# gpg:                 aka "Alex Williamson <address@hidden>" [full]
# Primary key fingerprint: 42F6 C04E 540B D1A9 9E7B  8A90 239B 9B6E 3BB0 8B22

* remotes/awilliam/tags/vfio-updates-20190613.0:
  vfio/common: Introduce vfio_set_irq_signaling helper
  vfio/pci: Allow MSI-X relocation to fixup bogus PBA
  vfio/pci: Hide Resizable BAR capability

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d1bf88e56f46...5ec2eca83dc4