[Qemu-commits] [qemu/qemu] 4d2091: qdev: Delete unused LostTickPolicy "m

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 4d2091: qdev: Delete unused LostTickPolicy "m

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] 4d2091: qdev: Delete unused LostTickPolicy "merge"
Date:	Thu, 13 Jun 2019 04:56:32 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4d2091023a3475893b6145413cfc2dfc391e6d7d
      
https://github.com/qemu/qemu/commit/4d2091023a3475893b6145413cfc2dfc391e6d7d
  Author: Markus Armbruster <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M qapi/misc.json

  Log Message:
  -----------
  qdev: Delete unused LostTickPolicy "merge"

Commit 4e4fa398db6 "qdev: Introduce lost tick policy property"
(v1.1.0) created PropertyType PROP_TYPE_LOSTTICKPOLICY with values
"discard", "delay", "merge", and "slew".  Value "merge" has never been
used.  Delete it.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 64c7580c2e85072685cb3f97b429191db92ced2b
      
https://github.com/qemu/qemu/commit/64c7580c2e85072685cb3f97b429191db92ced2b
  Author: Stefano Garzarella <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M qapi/block-core.json

  Log Message:
  -----------
  qapi/block-core: update documentation of preallocation parameter

Add default and available values in the documentation block of
each block device or protocol that supports the 'preallocation'
parameter during the image creation.

Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Stefano Garzarella <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: abea00533fa48de89f211bf2e0cff334765ed58e
      
https://github.com/qemu/qemu/commit/abea00533fa48de89f211bf2e0cff334765ed58e
  Author: Stefano Garzarella <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M block/file-posix.c

  Log Message:
  -----------
  block/file-posix: update .help of BLOCK_OPT_PREALLOC option

Show 'falloc' among the allowed values of 'preallocation'
option, only when it is supported (if defined CONFIG_POSIX_FALLOCATE)

Signed-off-by: Stefano Garzarella <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 2ea8e96da2974512f27fab03758b301dff180b6d
      
https://github.com/qemu/qemu/commit/2ea8e96da2974512f27fab03758b301dff180b6d
  Author: Stefano Garzarella <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M block/gluster.c

  Log Message:
  -----------
  block/gluster: update .help of BLOCK_OPT_PREALLOC option

Add missing 'falloc' among the allowed values of 'preallocation'
option; show it and 'full' only when they are supported.
('falloc' is supported if defined CONFIG_GLUSTERFS_FALLOCATE,
'full' is supported if defined CONFIG_GLUSTERFS_ZEROFILL)

Signed-off-by: Stefano Garzarella <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 6a8c0b51025314cdb1a8b4be24d45e690f1217dd
      
https://github.com/qemu/qemu/commit/6a8c0b51025314cdb1a8b4be24d45e690f1217dd
  Author: Kevin Wolf <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M docs/devel/qapi-code-gen.txt
    M qapi/introspect.json
    M scripts/qapi/common.py
    M scripts/qapi/doc.py
    M scripts/qapi/introspect.py
    M scripts/qapi/types.py
    M scripts/qapi/visit.py
    M tests/qapi-schema/double-type.err
    M tests/qapi-schema/test-qapi.py
    M tests/qapi-schema/unknown-expr-key.err

  Log Message:
  -----------
  qapi: Add feature flags to struct types

Sometimes, the behaviour of QEMU changes without a change in the QMP
syntax (usually by allowing values or operations that previously
resulted in an error). QMP clients may still need to know whether
they can rely on the changed behavior.

Let's add feature flags to the QAPI schema language, so that we can make
such changes visible with schema introspection.

An example for a schema definition using feature flags looks like this:

    { 'struct': 'TestType',
      'data': { 'number': 'int' },
      'features': [ 'allow-negative-numbers' ] }

Introspection information then looks like this:

    { "name": "TestType", "meta-type": "object",
      "members": [
          { "name": "number", "type": "int" } ],
      "features": [ "allow-negative-numbers" ] }

This patch implements feature flags only for struct types. We'll
implement them more widely as needed.

Signed-off-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 8aa3a33e442fc49fd67e4c8df8869d257c41c77e
      
https://github.com/qemu/qemu/commit/8aa3a33e442fc49fd67e4c8df8869d257c41c77e
  Author: Kevin Wolf <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/qapi-schema/test-qapi.py
    M tests/test-qmp-cmds.c

  Log Message:
  -----------
  tests/qapi-schema: Test for good feature lists in structs

Signed-off-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: a00af404253729e025ccdca107c2bf2a4cff3bf9
      
https://github.com/qemu/qemu/commit/a00af404253729e025ccdca107c2bf2a4cff3bf9
  Author: Kevin Wolf <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M tests/Makefile.include
    A tests/qapi-schema/features-bad-type.err
    A tests/qapi-schema/features-bad-type.exit
    A tests/qapi-schema/features-bad-type.json
    A tests/qapi-schema/features-bad-type.out
    A tests/qapi-schema/features-duplicate-name.err
    A tests/qapi-schema/features-duplicate-name.exit
    A tests/qapi-schema/features-duplicate-name.json
    A tests/qapi-schema/features-duplicate-name.out
    A tests/qapi-schema/features-missing-name.err
    A tests/qapi-schema/features-missing-name.exit
    A tests/qapi-schema/features-missing-name.json
    A tests/qapi-schema/features-missing-name.out
    A tests/qapi-schema/features-name-bad-type.err
    A tests/qapi-schema/features-name-bad-type.exit
    A tests/qapi-schema/features-name-bad-type.json
    A tests/qapi-schema/features-name-bad-type.out
    A tests/qapi-schema/features-no-list.err
    A tests/qapi-schema/features-no-list.exit
    A tests/qapi-schema/features-no-list.json
    A tests/qapi-schema/features-no-list.out
    A tests/qapi-schema/features-unknown-key.err
    A tests/qapi-schema/features-unknown-key.exit
    A tests/qapi-schema/features-unknown-key.json
    A tests/qapi-schema/features-unknown-key.out

  Log Message:
  -----------
  tests/qapi-schema: Error case tests for features in structs

Signed-off-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 03bf06bdc13c066a4703ab16e767dd91214969e3
      
https://github.com/qemu/qemu/commit/03bf06bdc13c066a4703ab16e767dd91214969e3
  Author: Kevin Wolf <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M scripts/qapi/common.py

  Log Message:
  -----------
  qapi: Disentangle QAPIDoc code

Documentation comments follow a certain structure: First, we have a text
with a general description (called QAPIDoc.body). After this,
descriptions of the arguments follow. Finally, we have a part that
contains various named sections.

The code doesn't show this structure, but just checks various attributes
that indicate indirectly which part is being processed, so it happens to
do the right set of things in the right phase. This is hard to follow,
and adding support for documentation of features would be even harder.

This patch restructures the code so that the three parts are clearly
separated. The code becomes a bit longer, but easier to follow. The
resulting output remains unchanged.

Signed-off-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: f3ed93d545297afbf8c67092b84a14037ec380bd
      
https://github.com/qemu/qemu/commit/f3ed93d545297afbf8c67092b84a14037ec380bd
  Author: Kevin Wolf <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M scripts/qapi/common.py
    M scripts/qapi/doc.py

  Log Message:
  -----------
  qapi: Allow documentation for features

Features will be documented in a new part introduced by a "Features:"
line, after arguments and before named sections.

Signed-off-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: c9d4070991ee504bd674c77c3790ef7028b258bd
      
https://github.com/qemu/qemu/commit/c9d4070991ee504bd674c77c3790ef7028b258bd
  Author: Kevin Wolf <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M qapi/block-core.json

  Log Message:
  -----------
  file-posix: Add dynamic-auto-read-only QAPI feature

In commit 23dece19da4 ('file-posix: Make auto-read-only dynamic') ,
auto-read-only=on changed its behaviour in file-posix for the 4.0
release. This change cannot be detected through the usual mechanisms
like schema introspection. Add a new feature flag to the schema to
allow libvirt to detect the presence of the new behaviour.

Signed-off-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Comment tweaked on Eric Blake's advice]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 157dd363955b961ef378eb1f7817c31a7fa94d10
      
https://github.com/qemu/qemu/commit/157dd363955b961ef378eb1f7817c31a7fa94d10
  Author: Markus Armbruster <address@hidden>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M scripts/qapi/common.py

  Log Message:
  -----------
  qapi: Simplify how QAPIDoc implements its state machine

QAPIDoc uses a state machine to for processing of documentation lines.
Its state is encoded as an enum QAPIDoc._state (well, as enum-like
class actually, thanks to our infatuation with Python 2).

All we ever do with the state is calling the state's function to
process a line of documentation.  The enum values effectively serve as
handles for the functions.

Eliminate the rather wordy indirection: store the function to call in
QAPIDoc._append_line.  Update and improve comments.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
[Commit message typo fixed]


  Commit: 4747524f9f243ca5ff1f146d37e423c00e923ee1
      
https://github.com/qemu/qemu/commit/4747524f9f243ca5ff1f146d37e423c00e923ee1
  Author: Peter Maydell <address@hidden>
  Date:   2019-06-13 (Thu, 13 Jun 2019)

  Changed paths:
    M block/file-posix.c
    M block/gluster.c
    M docs/devel/qapi-code-gen.txt
    M qapi/block-core.json
    M qapi/introspect.json
    M qapi/misc.json
    M scripts/qapi/common.py
    M scripts/qapi/doc.py
    M scripts/qapi/introspect.py
    M scripts/qapi/types.py
    M scripts/qapi/visit.py
    M tests/Makefile.include
    M tests/qapi-schema/double-type.err
    A tests/qapi-schema/features-bad-type.err
    A tests/qapi-schema/features-bad-type.exit
    A tests/qapi-schema/features-bad-type.json
    A tests/qapi-schema/features-bad-type.out
    A tests/qapi-schema/features-duplicate-name.err
    A tests/qapi-schema/features-duplicate-name.exit
    A tests/qapi-schema/features-duplicate-name.json
    A tests/qapi-schema/features-duplicate-name.out
    A tests/qapi-schema/features-missing-name.err
    A tests/qapi-schema/features-missing-name.exit
    A tests/qapi-schema/features-missing-name.json
    A tests/qapi-schema/features-missing-name.out
    A tests/qapi-schema/features-name-bad-type.err
    A tests/qapi-schema/features-name-bad-type.exit
    A tests/qapi-schema/features-name-bad-type.json
    A tests/qapi-schema/features-name-bad-type.out
    A tests/qapi-schema/features-no-list.err
    A tests/qapi-schema/features-no-list.exit
    A tests/qapi-schema/features-no-list.json
    A tests/qapi-schema/features-no-list.out
    A tests/qapi-schema/features-unknown-key.err
    A tests/qapi-schema/features-unknown-key.exit
    A tests/qapi-schema/features-unknown-key.json
    A tests/qapi-schema/features-unknown-key.out
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/qapi-schema/test-qapi.py
    M tests/qapi-schema/unknown-expr-key.err
    M tests/test-qmp-cmds.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2019-06-12' into 
staging

QAPI patches for 2019-06-12

# gpg: Signature made Wed 12 Jun 2019 17:44:50 BST
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Markus Armbruster <address@hidden>" [full]
# gpg:                 aka "Markus Armbruster <address@hidden>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-qapi-2019-06-12:
  qapi: Simplify how QAPIDoc implements its state machine
  file-posix: Add dynamic-auto-read-only QAPI feature
  qapi: Allow documentation for features
  qapi: Disentangle QAPIDoc code
  tests/qapi-schema: Error case tests for features in structs
  tests/qapi-schema: Test for good feature lists in structs
  qapi: Add feature flags to struct types
  block/gluster: update .help of BLOCK_OPT_PREALLOC option
  block/file-posix: update .help of BLOCK_OPT_PREALLOC option
  qapi/block-core: update documentation of preallocation parameter
  qdev: Delete unused LostTickPolicy "merge"

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/8e23e34d989d...4747524f9f24
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 4d2091: qdev: Delete unused LostTickPolicy "merge", Peter Maydell <=
Prev by Date: [Qemu-commits] [qemu/qemu] 2044df: ui/cocoa: Fix absolute input device grabbing issue...
Next by Date: [Qemu-commits] [qemu/qemu] 899f08: tcg: Fix typos in helper_gvec_sar{8, 32, 64}v
Previous by thread: [Qemu-commits] [qemu/qemu] 2044df: ui/cocoa: Fix absolute input device grabbing issue...
Next by thread: [Qemu-commits] [qemu/qemu] 899f08: tcg: Fix typos in helper_gvec_sar{8, 32, 64}v
Index(es):
- Date
- Thread