qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] f2784e: hw: report invalid disable-legacy|mod


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] f2784e: hw: report invalid disable-legacy|modern usage for...
Date: Tue, 21 May 2019 07:56:27 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f2784eed306449c3d04a71a05ed6463b8289aedf
      
https://github.com/qemu/qemu/commit/f2784eed306449c3d04a71a05ed6463b8289aedf
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/core/machine.c
    M hw/display/virtio-gpu-pci.c
    M hw/display/virtio-vga.c
    M hw/virtio/virtio-crypto-pci.c
    M hw/virtio/virtio-input-pci.c
    M hw/virtio/virtio-pci.c
    M hw/virtio/virtio-pci.h

  Log Message:
  -----------
  hw: report invalid disable-legacy|modern usage for virtio-1-only devs

A number of virtio devices (gpu, crypto, mouse, keyboard, tablet) only
support the virtio-1 (aka modern) mode. Currently if the user launches
QEMU, setting those devices to enable legacy mode, QEMU will silently
create them in modern mode, ignoring the user's (mistaken) request.

This patch introduces proper data validation so that an attempt to
configure a virtio-1-only devices in legacy mode gets reported as an
error to the user.

Checking this required introduction of a new field to explicitly track
what operating model is to be used for a device, separately from the
disable_modern and disable_legacy fields that record the user's
requested configuration.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 8fa70dbd8bb478d9483c1da3e9976a2d86b3f9a0
      
https://github.com/qemu/qemu/commit/8fa70dbd8bb478d9483c1da3e9976a2d86b3f9a0
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M include/hw/qdev-core.h
    M qom/object.c

  Log Message:
  -----------
  Revert "globals: Allow global properties to be optional"

This reverts commit d7741743f4f3d2683d1bb6938f88dc0167c21afa.

Relying on setting properties on parents types which may not
be relevant to certain sub-classes had unexpected side-effects
causing bugs in device config defaults. It is preferrable to
be explicit about which devices get which properties, even if
this needs repetition.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: ed1be66bfc468236fb0c4328c89a873405c13926
      
https://github.com/qemu/qemu/commit/ed1be66bfc468236fb0c4328c89a873405c13926
  Author: Marc-André Lureau <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M MAINTAINERS
    M docs/interop/index.rst
    A docs/interop/vhost-user.rst
    R docs/interop/vhost-user.txt

  Log Message:
  -----------
  docs: reST-ify vhost-user documentation

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Jens Freimann <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: badaf79cfdbd32b22df00bca1a1797036063dc48
      
https://github.com/qemu/qemu/commit/badaf79cfdbd32b22df00bca1a1797036063dc48
  Author: Xie Yongji <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/virtio/virtio.c
    M include/hw/virtio/virtio.h

  Log Message:
  -----------
  virtio: Introduce started flag to VirtioDevice

The virtio 1.0 transitional devices support driver uses the device
before setting the DRIVER_OK status bit. So we introduce a started
flag to indicate whether driver has started the device or not.

Signed-off-by: Xie Yongji <address@hidden>
Signed-off-by: Zhang Yu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 7dc7f12297bcee93e0b1974262d18c51cb386e8e
      
https://github.com/qemu/qemu/commit/7dc7f12297bcee93e0b1974262d18c51cb386e8e
  Author: Xie Yongji <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: Use started flag in virtio_vmstate_change()

Currently, we use DRIVER_OK status bit to check whether guest
driver has started the device in virtio_vmstate_change(). But it's
not the case for virtio 1.0 transitional devices. If migration completes
between kicking virtqueue and setting VIRTIO_CONFIG_S_DRIVER_OK, guest
may be hung. So here we use started flag to check guest state instead.

Signed-off-by: Xie Yongji <address@hidden>
Signed-off-by: Zhang Yu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 96cb54981728f5f2af1706658ad44abfa9df24e7
      
https://github.com/qemu/qemu/commit/96cb54981728f5f2af1706658ad44abfa9df24e7
  Author: Xie Yongji <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/block/vhost-user-blk.c

  Log Message:
  -----------
  vhost-user-blk: Use started flag in vhost_user_blk_set_status()

Use started flag in vhost_user_blk_set_status() to decide if
starting vhost-user backend or not.

Signed-off-by: Xie Yongji <address@hidden>
Signed-off-by: Zhang Yu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: f3facbe67110089f075aba1091dbc8280304fbaf
      
https://github.com/qemu/qemu/commit/f3facbe67110089f075aba1091dbc8280304fbaf
  Author: Xie Yongji <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/block/vhost-user-blk.c

  Log Message:
  -----------
  vhost-user-blk: Only start vhost-user backend with the first kick

We should only start vhost-user backend at the first kick for
virtio 1.0 transitional devices.

Signed-off-by: Xie Yongji <address@hidden>
Signed-off-by: Zhang Yu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: a57f009108076d3c30f87be5d580c6344ad44971
      
https://github.com/qemu/qemu/commit/a57f009108076d3c30f87be5d580c6344ad44971
  Author: Xie Yongji <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/block/vhost-user-blk.c

  Log Message:
  -----------
  vhost-user-blk: Add return value for vhost_user_blk_start()

Add a return value for vhost_user_blk_start() to check whether
we start vhost-user backend successfully or not.

Signed-off-by: Xie Yongji <address@hidden>
Signed-off-by: Zhang Yu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 77542d431491788d1e8e79d93ce10172ef207775
      
https://github.com/qemu/qemu/commit/77542d431491788d1e8e79d93ce10172ef207775
  Author: Xie Yongji <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/block/vhost-user-blk.c
    M include/hw/virtio/vhost-user-blk.h

  Log Message:
  -----------
  vhost-user-blk: Add support to reconnect backend

Since we now support the message VHOST_USER_GET_INFLIGHT_FD
and VHOST_USER_SET_INFLIGHT_FD. The backend is able to restart
safely because it can track inflight I/O in shared memory.
This patch allows qemu to reconnect the backend after
connection closed.

Signed-off-by: Xie Yongji <address@hidden>
Signed-off-by: Ni Xun <address@hidden>
Signed-off-by: Zhang Yu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 6b8f9c6e15af38129452e2ae5c58f4a5c4585678
      
https://github.com/qemu/qemu/commit/6b8f9c6e15af38129452e2ae5c58f4a5c4585678
  Author: Xie Yongji <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M contrib/vhost-user-blk/vhost-user-blk.c

  Log Message:
  -----------
  contrib/vhost-user-blk: enable inflight I/O tracking

This patch enables inflight I/O tracking for
vhost-user-blk backend so that we could restart it safely.

Signed-off-by: Xie Yongji <address@hidden>
Signed-off-by: Zhang Yu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: b37d56ece9878f934126da7efbcbb9a512f191ad
      
https://github.com/qemu/qemu/commit/b37d56ece9878f934126da7efbcbb9a512f191ad
  Author: Markus Armbruster <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/acpi/piix4.c
    M hw/acpi/trace-events

  Log Message:
  -----------
  acpi/piix4: Convert debug printf()s to trace events

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: df93b19476850eda005b7ea008e356c92b4c15ab
      
https://github.com/qemu/qemu/commit/df93b19476850eda005b7ea008e356c92b4c15ab
  Author: Markus Armbruster <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/acpi/pcihp.c
    M hw/acpi/trace-events

  Log Message:
  -----------
  acpi/pcihp: Convert debug printf()s to trace events

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 03459ea3b3d95c7d2a01db3bd7bcccefee3db4ba
      
https://github.com/qemu/qemu/commit/03459ea3b3d95c7d2a01db3bd7bcccefee3db4ba
  Author: Markus Armbruster <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/acpi/pcihp.c
    M hw/acpi/trace-events

  Log Message:
  -----------
  acpi/pcihp: Add a few more trace points related to unplug

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: fe4970ad466dc14b919224d10179a8858130db43
      
https://github.com/qemu/qemu/commit/fe4970ad466dc14b919224d10179a8858130db43
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  q35: acpi: do not create dummy MCFG table

Dummy table (with signature "QEMU") creation came from original SeaBIOS
codebase. And QEMU would have to keep it around if there were Q35 machine
that depended on keeping ACPI tables blob constant size. Luckily there
were no versioned Q35 machine types before commit:
  (since 2.3) a1666142db acpi-build: make ROMs RAM blocks resizeable
which obsoleted need to keep ACPI tables blob the same size on 
source/destination.

Considering the 1st versioned machine is pc-q35-2.4, the dummy table
is not really necessary and it's safe to drop it without breaking
cross version migration in both directions unconditionally.

Signed-off-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 6ab79a20af3a7b3bf610ba9aebb446a9f0b05930
      
https://github.com/qemu/qemu/commit/6ab79a20af3a7b3bf610ba9aebb446a9f0b05930
  Author: Dan Streetman <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M net/vhost-user.c

  Log Message:
  -----------
  do not call vhost_net_cleanup() on running net from char user event

Buglink: https://launchpad.net/bugs/1823458

Currently, a user CHR_EVENT_CLOSED event will cause net_vhost_user_event()
to call vhost_user_cleanup(), which calls vhost_net_cleanup() for all
its queues.  However, vhost_net_cleanup() must never be called like
this for fully-initialized nets; when other code later calls
vhost_net_stop() - such as from virtio_net_vhost_status() - it will try
to access the already-cleaned-up fields and fail with assertion errors
or segfaults.

The vhost_net_cleanup() will eventually be called from
qemu_cleanup_net_client().

Signed-off-by: Dan Streetman <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: ccf0f0f2c200806e3ed6be6c5dfa7ee3abb2e7b7
      
https://github.com/qemu/qemu/commit/ccf0f0f2c200806e3ed6be6c5dfa7ee3abb2e7b7
  Author: Wei Yang <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/arm/virt-acpi-build.c

  Log Message:
  -----------
  hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start

mcfg_start points to the start of MCFG table and is used in
build_header. While this information could be derived from mcfg.

This patch removes the unnecessary variable mcfg_start.

Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: c309434ee97ff2ce46c97b0452bb0f83bfd4432b
      
https://github.com/qemu/qemu/commit/c309434ee97ff2ce46c97b0452bb0f83bfd4432b
  Author: Wei Yang <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members

This is obvious the member in AcpiMcfgInfo describe MCFG's property.

Remove the mcfg_ prefix.

Signed-off-by: Wei Yang <address@hidden>
Suggested-by: Igor Mammedov <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 48cefd94c748cf8d5bb3ffda53bdc8e503882a3f
      
https://github.com/qemu/qemu/commit/48cefd94c748cf8d5bb3ffda53bdc8e503882a3f
  Author: Wei Yang <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/arm/virt-acpi-build.c
    M hw/i386/acpi-build.c
    A include/hw/acpi/pci.h

  Log Message:
  -----------
  hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg()

To build MCFG, two information is necessary:

    * bus number
    * base address

Abstract these two information to AcpiMcfgInfo so that build_mcfg and
build_mcfg_q35 will have the same declaration.

Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: acbd487ddb36499108d3bc2fb0654f6892177633
      
https://github.com/qemu/qemu/commit/acbd487ddb36499108d3bc2fb0654f6892177633
  Author: Li Feng <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M contrib/libvhost-user/libvhost-user.c

  Log Message:
  -----------
  libvhost-user: fix bad vu_log_write

Mark dirty as page, the step of each call is 1.

Signed-off-by: Li Feng <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: c76efd7225d33b48f7a1dd4519620f0b50267612
      
https://github.com/qemu/qemu/commit/c76efd7225d33b48f7a1dd4519620f0b50267612
  Author: David Gibson <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/pci/pcie_host.c

  Log Message:
  -----------
  pcie: Remove redundant test in pcie_mmcfg_data_{read,write}()

These functions have an explicit test for accesses above the device's
config size.  But pci_host_config_{read,write}_common() which they're
about to call already have checks against the config space limit and
do the right thing.  So, remove the redundant tests.

Signed-off-by: David Gibson <address@hidden>
Message-Id: <address@hidden>


  Commit: b0e5196a52248d7e4eef709481c1c530c1bca6df
      
https://github.com/qemu/qemu/commit/b0e5196a52248d7e4eef709481c1c530c1bca6df
  Author: David Gibson <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M hw/pci-bridge/pci_expander_bridge.c
    M hw/pci/pci.c
    M hw/virtio/virtio-pci.c
    M include/hw/pci/pci.h
    M include/hw/pci/pci_bus.h

  Log Message:
  -----------
  pci: Simplify pci_bus_is_root()

pci_bus_is_root() currently relies on a method in the PCIBusClass.
But it's always known if a PCI bus is a root bus when we create it, so
using a dynamic method is overkill.

This replaces it with an IS_ROOT bit in a new flags field, which is set on
root buses and otherwise clear.  As a bonus this removes the special
is_root logic from pci_expander_bridge, since it already creates its bus
as a root bus.

Signed-off-by: David Gibson <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Message-Id: <address@hidden>


  Commit: 38fb3d7100b871eef3237cba2e4e1fed56d2bd1f
      
https://github.com/qemu/qemu/commit/38fb3d7100b871eef3237cba2e4e1fed56d2bd1f
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/acpi-utils.c
    M tests/acpi-utils.h
    M tests/bios-tables-test.c
    M tests/vmgenid-test.c

  Log Message:
  -----------
  tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

so name would reflect what the function does

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 4b14d543f3338985fd9c74ae6f6a6d3861c841dd
      
https://github.com/qemu/qemu/commit/4b14d543f3338985fd9c74ae6f6a6d3861c841dd
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/acpi-utils.c
    M tests/acpi-utils.h
    M tests/bios-tables-test.c
    M tests/vmgenid-test.c

  Log Message:
  -----------
  tests: acpi: make acpi_fetch_table() take size of fetched table pointer

Currently acpi_fetch_table() assumes 32 bit size of table pointer
in ACPI tables. However X_foo variants are 64 bit, prepare
acpi_fetch_table() to handle both by adding an argument
for addr_ptr pointed entry size. Follow up commits will use that
to read XSDT and X_foo entries in ACPI tables.

Signed-off-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: f2f616cea44018c8280795f40ce66b04a164dfa8
      
https://github.com/qemu/qemu/commit/f2f616cea44018c8280795f40ce66b04a164dfa8
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/acpi-utils.c
    M tests/acpi-utils.h
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: make RSDT test routine handle XSDT

If RSDP revision is more than 0 fetch table pointed by XSDT
and fallback to legacy RSDT table otherwise.

While at it drop unused acpi_get_xsdt_address().

Signed-off-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 9c0418852b6ed8fc677211767b11e4fdecc51a6e
      
https://github.com/qemu/qemu/commit/9c0418852b6ed8fc677211767b11e4fdecc51a6e
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/acpi-utils.c
    M tests/acpi-utils.h
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: make pointer to RSDP 64bit

In case of UEFI, RSDP doesn't have to be located in lowmem,
it could be placed at any address. Make sure that test won't
break if it is placed above the first 4Gb of address space.

PS:
While at it cleanup some local variables as we don't really
need them.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 55089fa2d74306d7732e485484efd65aa6e259b3
      
https://github.com/qemu/qemu/commit/55089fa2d74306d7732e485484efd65aa6e259b3
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: fetch X_DSDT if pointer to DSDT is 0

that way it would be possible to test a DSDT pointed by
64bit X_DSDT field in FADT.

PS:
it will allow to enable testing arm/virt board, which sets
only newer X_DSDT field.

Signed-off-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 40dfd0a8cd205a5c92219bde75002644c8e817ad
      
https://github.com/qemu/qemu/commit/40dfd0a8cd205a5c92219bde75002644c8e817ad
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: skip FACS table if board uses hw reduced ACPI profile

If FADT has HW_REDUCED_ACPI flag set, do not attempt to fetch
FACS as it's not provided by the board.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: d47a5d64455eb21f98743c3d624be40c97a63b5a
      
https://github.com/qemu/qemu/commit/d47a5d64455eb21f98743c3d624be40c97a63b5a
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: move boot_sector_init() into x86 tests branch

boot_sector_init() won't be used by arm/virt board, so move it from
global scope to x86 branch that uses it.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: a37d5472b3d3ae0d8dc47ed5371c4ac505b32996
      
https://github.com/qemu/qemu/commit/a37d5472b3d3ae0d8dc47ed5371c4ac505b32996
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/acpi-utils.c
    M tests/acpi-utils.h

  Log Message:
  -----------
  tests: acpi: add acpi_find_rsdp_address_uefi() helper

introduce UEFI specific counterpart to acpi_find_rsdp_address()
that will help to find RSDP address when [OA]VMF is used as
firmware. It requires guest firmware or other guest app to place
1Mb aligned UefiTestSupport structure (defined in this patch)
in RAM with UefiTestSupport::signature_guid set to
AB87A6B1-2034-BDA0-71BD-375007757785
For test app details see commit
  (09a274d82f tests: introduce "uefi-test-tools" with the BiosTablesTest UEFI 
app)

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 97256e799fedd47aee8ceb6bad69e6f3e6b339f3
      
https://github.com/qemu/qemu/commit/97256e799fedd47aee8ceb6bad69e6f3e6b339f3
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: add a way to start tests with UEFI firmware

For testcase to use UEFI firmware, one needs to provide and specify
firmware and varstore blob names in test_data { uefi_fl1, uefi_fl2 }
fields respectively and RAM start address plus size where to look for
test structure signature. Additionally testcase should specify
bootable cdrom image from uefi-boot-images with EFI test utility.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: ce513b46151398fc4dad853dbfc744ee3e2b7a35
      
https://github.com/qemu/qemu/commit/ce513b46151398fc4dad853dbfc744ee3e2b7a35
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: ignore SMBIOS tests when UEFI firmware is used

once FW provides a pointer to SMBIOS entry point like it does for
RSDP it should be possible to enable this one the same way.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Message-Id: <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 3dc018749d2942fdb81676ab2b5948984c961a01
      
https://github.com/qemu/qemu/commit/3dc018749d2942fdb81676ab2b5948984c961a01
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: allow to override default accelerator

By default test cases were run with 'kvm:tcg' accelerators to speed up
tests execution. While it works for x86, were change of accelerator
doesn't affect ACPI tables, the approach doesn't works for ARM usecase
though.

In arm/virt case, KVM mode requires using 'host' cpu model, which
isn't available in TCG mode. That could be worked around with 'max'
cpu model, which works both for KVM and TCG. However in KVM mode it
is necessary to specify matching GIC version, which also could use
'max' value to automatically pick GIC version suitable for host's CPU.
Depending on host cpu type, different GIC versions would be used,
which in turn leads to different ACPI tables (APIC) generated.
As result while comparing with reference blobs, test would fail if
host's GIC version won't match the version on the host where
reference blobs where generated.

Let's keep testing simple for now and allow ARM tests run in TCG only
mode. To do so introduce 'accel' parameter in test configuration, so
test case could override default "kvm:tcg" with accelerator of choice.

Signed-off-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: ae3c12a015522621931383f0ddbff8a6a00f7866
      
https://github.com/qemu/qemu/commit/ae3c12a015522621931383f0ddbff8a6a00f7866
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/data/acpi/rebuild-expected-aml.sh

  Log Message:
  -----------
  tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a 
specified list of targets

Make initial list contain x86_64.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: ba02ff90ee1dcaf7aa5645075217e555ae2c54ea
      
https://github.com/qemu/qemu/commit/ba02ff90ee1dcaf7aa5645075217e555ae2c54ea
  Author: Igor Mammedov <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/bios-tables-test.c

  Log Message:
  -----------
  tests: acpi: print error unable to dump ACPI table during rebuild

Instead of just asserting print the error that lead to assert first.
While at it move assert into rebuild branch, which removes redundant
check done in case of !rebuild branch is taken (the later is taken
care of by g_assert_no_error).

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Wei Yang <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 247ba27c528c52e4a41c233c1c9a699f40e4d2a5
      
https://github.com/qemu/qemu/commit/247ba27c528c52e4a41c233c1c9a699f40e4d2a5
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M MAINTAINERS
    M contrib/libvhost-user/libvhost-user.c
    M contrib/vhost-user-blk/vhost-user-blk.c
    M docs/interop/index.rst
    A docs/interop/vhost-user.rst
    R docs/interop/vhost-user.txt
    M hw/acpi/pcihp.c
    M hw/acpi/piix4.c
    M hw/acpi/trace-events
    M hw/arm/virt-acpi-build.c
    M hw/block/vhost-user-blk.c
    M hw/core/machine.c
    M hw/display/virtio-gpu-pci.c
    M hw/display/virtio-vga.c
    M hw/i386/acpi-build.c
    M hw/pci-bridge/pci_expander_bridge.c
    M hw/pci/pci.c
    M hw/pci/pcie_host.c
    M hw/virtio/virtio-crypto-pci.c
    M hw/virtio/virtio-input-pci.c
    M hw/virtio/virtio-pci.c
    M hw/virtio/virtio-pci.h
    M hw/virtio/virtio.c
    A include/hw/acpi/pci.h
    M include/hw/pci/pci.h
    M include/hw/pci/pci_bus.h
    M include/hw/qdev-core.h
    M include/hw/virtio/vhost-user-blk.h
    M include/hw/virtio/virtio.h
    M net/vhost-user.c
    M qom/object.c
    M tests/acpi-utils.c
    M tests/acpi-utils.h
    M tests/bios-tables-test.c
    M tests/data/acpi/rebuild-expected-aml.sh
    M tests/vmgenid-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

pci, pc, virtio: features, fixes

reconnect for vhost blk
tests for UEFI
misc other stuff

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Tue 21 May 2019 14:41:32 BST
# gpg:                using RSA key 281F0DB8D28D5469
# gpg: Good signature from "Michael S. Tsirkin <address@hidden>" [full]
# gpg:                 aka "Michael S. Tsirkin <address@hidden>" [full]
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* remotes/mst/tags/for_upstream: (34 commits)
  tests: acpi: print error unable to dump ACPI table during rebuild
  tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a 
specified list of targets
  tests: acpi: allow to override default accelerator
  tests: acpi: ignore SMBIOS tests when UEFI firmware is used
  tests: acpi: add a way to start tests with UEFI firmware
  tests: acpi: add acpi_find_rsdp_address_uefi() helper
  tests: acpi: move boot_sector_init() into x86 tests branch
  tests: acpi: skip FACS table if board uses hw reduced ACPI profile
  tests: acpi: fetch X_DSDT if pointer to DSDT is 0
  tests: acpi: make pointer to RSDP 64bit
  tests: acpi: make RSDT test routine handle XSDT
  tests: acpi: make acpi_fetch_table() take size of fetched table pointer
  tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()
  pci: Simplify pci_bus_is_root()
  pcie: Remove redundant test in pcie_mmcfg_data_{read,write}()
  libvhost-user: fix bad vu_log_write
  hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg()
  i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members
  hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start
  do not call vhost_net_cleanup() on running net from char user event
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/62516a0a18cd...247ba27c528c



reply via email to

[Prev in Thread] Current Thread [Next in Thread]