qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 1f0396: tests/libqtest: Remove unused global_

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 1f0396: tests/libqtest: Remove unused global_qtest-related...
Date: Tue, 21 May 2019 06:56:31 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1f0396db3863c958138b13e397390f0ff7135b9e
      
https://github.com/qemu/qemu/commit/1f0396db3863c958138b13e397390f0ff7135b9e
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/libqtest.c
    M tests/libqtest.h

  Log Message:
  -----------
  tests/libqtest: Remove unused global_qtest-related wrapper functions

A bunch of the wrapper functions that use global_qtest are not used
anymore. Remove them to avoid that they are used in new code again.

Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 00825d964a55756eb651b4deca560d835999065f
      
https://github.com/qemu/qemu/commit/00825d964a55756eb651b4deca560d835999065f
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/libqtest.h

  Log Message:
  -----------
  tests/libqtest: Fix description of qtest_vinitf() and qtest_initf()

These functions are convenience wrappers of qtest_init() and not of
qtest_start().

Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 8b898f59b109102faa5de8785e20c23a9445c0b1
      
https://github.com/qemu/qemu/commit/8b898f59b109102faa5de8785e20c23a9445c0b1
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/libqos/virtio-mmio.c
    M tests/libqos/virtio-pci.c
    M tests/libqos/virtio.c
    M tests/libqos/virtio.h

  Log Message:
  -----------
  tests/libqos: Get rid of global_qtest dependency in qvring_init()

Library functions should not depend on global_qtest functions like
writew() and writeq(), so that they can also be used in tests that
deal with multiple QTestStates at the same time (like migration tests).

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 41e99cbef8ac4e91d0675fd4c94c18bb7d71e71c
      
https://github.com/qemu/qemu/commit/41e99cbef8ac4e91d0675fd4c94c18bb7d71e71c
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/q35-test.c

  Log Message:
  -----------
  tests/q35-test: Make test independent of global_qtest

Use a local QTestState variable, so that we can finally get rid
of the undesired global_qtest variable in this file, too.

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 3d5e7087bd64b2bb4b9ae6bccf2b1fcd09ee4598
      
https://github.com/qemu/qemu/commit/3d5e7087bd64b2bb4b9ae6bccf2b1fcd09ee4598
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/numa-test.c

  Log Message:
  -----------
  tests/numa-test: Use qtest_init() instead of qtest_start()

qtest_start() + qtest_end() should be avoided, since they use the
global_qtest variable that we want to get rid of in the long run.
Use qtest_init() and qtest_quit() instead.

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 9266ebc97b8d07117367d0c5a8eb9ab77a69b7c9
      
https://github.com/qemu/qemu/commit/9266ebc97b8d07117367d0c5a8eb9ab77a69b7c9
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/qom-test.c

  Log Message:
  -----------
  tests/qom-test: Use qtest_init() instead of qtest_start()

qtest_start() + qtest_end() should be avoided, since they use the
global_qtest variable that we want to get rid of in the long run.
Use qtest_init() and qtest_quit() instead.

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 39fb795a87608c621fa2cb11b2b1509299b5be50
      
https://github.com/qemu/qemu/commit/39fb795a87608c621fa2cb11b2b1509299b5be50
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/device-introspect-test.c

  Log Message:
  -----------
  tests/device-introspect: Use qtest_init() instead of qtest_start()

qtest_start() + qtest_end() should be avoided, since they use the
global_qtest variable that we want to get rid of in the long run.
Use qtest_init() and qtest_quit() instead.

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 44c2364aaa5e366c44b07714c22e874f547883a5
      
https://github.com/qemu/qemu/commit/44c2364aaa5e366c44b07714c22e874f547883a5
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/hd-geo-test.c

  Log Message:
  -----------
  tests/hd-geo-test: Use qtest_init() instead of qtest_start()

qtest_start() + qtest_end() should be avoided, since they use the
global_qtest variable that we want to get rid of in the long run.
Use qtest_init() and qtest_quit() instead.

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: b807a99369ef534b9e7c10f34f8c64ce708332f3
      
https://github.com/qemu/qemu/commit/b807a99369ef534b9e7c10f34f8c64ce708332f3
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/qemu-iotests/005

  Log Message:
  -----------
  tests/qemu-iotests/005: Add a sanity check for large sparse file support

"check -raw 005" fails when running on certain filesystems - these do not
support such large sparse files. Use the same check as in test 220 to
skip the test in this case.

Suggested-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 4a715461c8eab628e79b1e6889d650455e043b88
      
https://github.com/qemu/qemu/commit/4a715461c8eab628e79b1e6889d650455e043b88
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/qemu-iotests/check

  Log Message:
  -----------
  tests/qemu-iotests/check: Pick a default machine if necessary

qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have
a default machine, so when running the qemu-iotests with such a binary,
lots of tests are failing. Fix it by picking a default machine in the
"check" script instead.

Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: f3d07ce8f449986e9a5c30f2a9f124e2ad8b7c22
      
https://github.com/qemu/qemu/commit/f3d07ce8f449986e9a5c30f2a9f124e2ad8b7c22
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/qemu-iotests/239
    M tests/qemu-iotests/240
    M tests/qemu-iotests/241
    M tests/qemu-iotests/243
    M tests/qemu-iotests/244

  Log Message:
  -----------
  tests/qemu-iotests: Do not hard-code the path to bash

bash is installed in a different directory on non-Linux systems like
FreeBSD. Do not hard-code /bin/bash here so that the tests can run
there, too.

Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: db2b95d56434bb4afcd979fe2f585bfe5acdf206
      
https://github.com/qemu/qemu/commit/db2b95d56434bb4afcd979fe2f585bfe5acdf206
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M .cirrus.yml
    M .travis.yml

  Log Message:
  -----------
  cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

We are going to enable the qemu-iotests during "make check" again,
and for running the iotests, we need bash and gnu-sed.

Reviewed-by: Li-Wen Hsu <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: b3763a195cc167152df1f762b3c3a73f7db7677b
      
https://github.com/qemu/qemu/commit/b3763a195cc167152df1f762b3c3a73f7db7677b
  Author: Thomas Huth <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M tests/qemu-iotests/001
    M tests/qemu-iotests/002
    M tests/qemu-iotests/003
    M tests/qemu-iotests/004
    M tests/qemu-iotests/007
    M tests/qemu-iotests/008
    M tests/qemu-iotests/009
    M tests/qemu-iotests/010
    M tests/qemu-iotests/011
    M tests/qemu-iotests/012
    M tests/qemu-iotests/015
    M tests/qemu-iotests/017
    M tests/qemu-iotests/020
    M tests/qemu-iotests/021
    M tests/qemu-iotests/022
    M tests/qemu-iotests/025
    M tests/qemu-iotests/026
    M tests/qemu-iotests/027
    M tests/qemu-iotests/029
    M tests/qemu-iotests/031
    M tests/qemu-iotests/032
    M tests/qemu-iotests/033
    M tests/qemu-iotests/035
    M tests/qemu-iotests/036
    M tests/qemu-iotests/037
    M tests/qemu-iotests/042
    M tests/qemu-iotests/043
    M tests/qemu-iotests/046
    M tests/qemu-iotests/047
    M tests/qemu-iotests/049
    M tests/qemu-iotests/050
    M tests/qemu-iotests/051
    M tests/qemu-iotests/052
    M tests/qemu-iotests/053
    M tests/qemu-iotests/054
    M tests/qemu-iotests/062
    M tests/qemu-iotests/063
    M tests/qemu-iotests/066
    M tests/qemu-iotests/067
    M tests/qemu-iotests/068
    M tests/qemu-iotests/069
    M tests/qemu-iotests/071
    M tests/qemu-iotests/072
    M tests/qemu-iotests/073
    M tests/qemu-iotests/079
    M tests/qemu-iotests/082
    M tests/qemu-iotests/085
    M tests/qemu-iotests/089
    M tests/qemu-iotests/090
    M tests/qemu-iotests/094
    M tests/qemu-iotests/095
    M tests/qemu-iotests/098
    M tests/qemu-iotests/102
    M tests/qemu-iotests/103
    M tests/qemu-iotests/104
    M tests/qemu-iotests/105
    M tests/qemu-iotests/107
    M tests/qemu-iotests/110
    M tests/qemu-iotests/111
    M tests/qemu-iotests/112
    M tests/qemu-iotests/114
    M tests/qemu-iotests/115
    M tests/qemu-iotests/117
    M tests/qemu-iotests/120
    M tests/qemu-iotests/125
    M tests/qemu-iotests/126
    M tests/qemu-iotests/127
    M tests/qemu-iotests/133
    M tests/qemu-iotests/134
    M tests/qemu-iotests/142
    M tests/qemu-iotests/143
    M tests/qemu-iotests/144
    M tests/qemu-iotests/145
    M tests/qemu-iotests/153
    M tests/qemu-iotests/156
    M tests/qemu-iotests/157
    M tests/qemu-iotests/158
    M tests/qemu-iotests/159
    M tests/qemu-iotests/162
    M tests/qemu-iotests/170
    M tests/qemu-iotests/173
    M tests/qemu-iotests/182
    M tests/qemu-iotests/183
    M tests/qemu-iotests/186
    M tests/qemu-iotests/187
    M tests/qemu-iotests/190
    M tests/qemu-iotests/191
    M tests/qemu-iotests/192
    M tests/qemu-iotests/195
    M tests/qemu-iotests/197
    M tests/qemu-iotests/200
    M tests/qemu-iotests/214
    M tests/qemu-iotests/215
    M tests/qemu-iotests/217
    M tests/qemu-iotests/227
    M tests/qemu-iotests/231
    M tests/qemu-iotests/233
    M tests/qemu-iotests/240
    M tests/qemu-iotests/247

  Log Message:
  -----------
  tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests

A lot of tests run fine on FreeBSD and macOS, too - the limitation
to Linux here was likely just copied-and-pasted from other tests.
Thus remove the "_supported_os Linux" line from tests that run
successful in our CI pipelines on FreeBSD and macOS.

Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 62516a0a18cd156d913dd625baca52c46743223b
      
https://github.com/qemu/qemu/commit/62516a0a18cd156d913dd625baca52c46743223b
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-21 (Tue, 21 May 2019)

  Changed paths:
    M .cirrus.yml
    M .travis.yml
    M tests/device-introspect-test.c
    M tests/hd-geo-test.c
    M tests/libqos/virtio-mmio.c
    M tests/libqos/virtio-pci.c
    M tests/libqos/virtio.c
    M tests/libqos/virtio.h
    M tests/libqtest.c
    M tests/libqtest.h
    M tests/numa-test.c
    M tests/q35-test.c
    M tests/qemu-iotests/001
    M tests/qemu-iotests/002
    M tests/qemu-iotests/003
    M tests/qemu-iotests/004
    M tests/qemu-iotests/005
    M tests/qemu-iotests/007
    M tests/qemu-iotests/008
    M tests/qemu-iotests/009
    M tests/qemu-iotests/010
    M tests/qemu-iotests/011
    M tests/qemu-iotests/012
    M tests/qemu-iotests/015
    M tests/qemu-iotests/017
    M tests/qemu-iotests/020
    M tests/qemu-iotests/021
    M tests/qemu-iotests/022
    M tests/qemu-iotests/025
    M tests/qemu-iotests/026
    M tests/qemu-iotests/027
    M tests/qemu-iotests/029
    M tests/qemu-iotests/031
    M tests/qemu-iotests/032
    M tests/qemu-iotests/033
    M tests/qemu-iotests/035
    M tests/qemu-iotests/036
    M tests/qemu-iotests/037
    M tests/qemu-iotests/042
    M tests/qemu-iotests/043
    M tests/qemu-iotests/046
    M tests/qemu-iotests/047
    M tests/qemu-iotests/049
    M tests/qemu-iotests/050
    M tests/qemu-iotests/051
    M tests/qemu-iotests/052
    M tests/qemu-iotests/053
    M tests/qemu-iotests/054
    M tests/qemu-iotests/062
    M tests/qemu-iotests/063
    M tests/qemu-iotests/066
    M tests/qemu-iotests/067
    M tests/qemu-iotests/068
    M tests/qemu-iotests/069
    M tests/qemu-iotests/071
    M tests/qemu-iotests/072
    M tests/qemu-iotests/073
    M tests/qemu-iotests/079
    M tests/qemu-iotests/082
    M tests/qemu-iotests/085
    M tests/qemu-iotests/089
    M tests/qemu-iotests/090
    M tests/qemu-iotests/094
    M tests/qemu-iotests/095
    M tests/qemu-iotests/098
    M tests/qemu-iotests/102
    M tests/qemu-iotests/103
    M tests/qemu-iotests/104
    M tests/qemu-iotests/105
    M tests/qemu-iotests/107
    M tests/qemu-iotests/110
    M tests/qemu-iotests/111
    M tests/qemu-iotests/112
    M tests/qemu-iotests/114
    M tests/qemu-iotests/115
    M tests/qemu-iotests/117
    M tests/qemu-iotests/120
    M tests/qemu-iotests/125
    M tests/qemu-iotests/126
    M tests/qemu-iotests/127
    M tests/qemu-iotests/133
    M tests/qemu-iotests/134
    M tests/qemu-iotests/142
    M tests/qemu-iotests/143
    M tests/qemu-iotests/144
    M tests/qemu-iotests/145
    M tests/qemu-iotests/153
    M tests/qemu-iotests/156
    M tests/qemu-iotests/157
    M tests/qemu-iotests/158
    M tests/qemu-iotests/159
    M tests/qemu-iotests/162
    M tests/qemu-iotests/170
    M tests/qemu-iotests/173
    M tests/qemu-iotests/182
    M tests/qemu-iotests/183
    M tests/qemu-iotests/186
    M tests/qemu-iotests/187
    M tests/qemu-iotests/190
    M tests/qemu-iotests/191
    M tests/qemu-iotests/192
    M tests/qemu-iotests/195
    M tests/qemu-iotests/197
    M tests/qemu-iotests/200
    M tests/qemu-iotests/214
    M tests/qemu-iotests/215
    M tests/qemu-iotests/217
    M tests/qemu-iotests/227
    M tests/qemu-iotests/231
    M tests/qemu-iotests/233
    M tests/qemu-iotests/239
    M tests/qemu-iotests/240
    M tests/qemu-iotests/241
    M tests/qemu-iotests/243
    M tests/qemu-iotests/244
    M tests/qemu-iotests/247
    M tests/qemu-iotests/check
    M tests/qom-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2019-05-21' into staging

- qtest patches to get rid of the global_qtest variable in more tests
- some iotests patches that have multiple reviews and thus are ready to go

# gpg: Signature made Tue 21 May 2019 11:40:31 BST
# gpg:                using RSA key 2ED9D774FE702DB5
# gpg: Good signature from "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2019-05-21:
  tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests
  cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD
  tests/qemu-iotests: Do not hard-code the path to bash
  tests/qemu-iotests/check: Pick a default machine if necessary
  tests/qemu-iotests/005: Add a sanity check for large sparse file support
  tests/hd-geo-test: Use qtest_init() instead of qtest_start()
  tests/device-introspect: Use qtest_init() instead of qtest_start()
  tests/qom-test: Use qtest_init() instead of qtest_start()
  tests/numa-test: Use qtest_init() instead of qtest_start()
  tests/q35-test: Make test independent of global_qtest
  tests/libqos: Get rid of global_qtest dependency in qvring_init()
  tests/libqtest: Fix description of qtest_vinitf() and qtest_initf()
  tests/libqtest: Remove unused global_qtest-related wrapper functions

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/293c76cb4833...62516a0a18cd
reply via email to
[Prev in Thread] Current Thread [Next in Thread]