qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 715980: fsdev: Drop unused extern declaration


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 715980: fsdev: Drop unused extern declaration
Date: Mon, 20 May 2019 03:37:14 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7159804d0be470da876ed856ee81d2dfeefedd97
      
https://github.com/qemu/qemu/commit/7159804d0be470da876ed856ee81d2dfeefedd97
  Author: Greg Kurz <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M fsdev/qemu-fsdev.h

  Log Message:
  -----------
  fsdev: Drop unused extern declaration

This is a leftover of the handle backend, removed in QEMU 4.0.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>


  Commit: 778f0fad5f93224b8657831cf82fa3bb644f21e7
      
https://github.com/qemu/qemu/commit/778f0fad5f93224b8657831cf82fa3bb644f21e7
  Author: Greg Kurz <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M fsdev/file-op-9p.h

  Log Message:
  -----------
  fsdev: Drop unused opaque field

This was introduced along with -fsdev but it never got used.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>


  Commit: 202324357397435bb572734e3fd4e1eed86b04f9
      
https://github.com/qemu/qemu/commit/202324357397435bb572734e3fd4e1eed86b04f9
  Author: Greg Kurz <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M fsdev/qemu-fsdev.c
    M fsdev/qemu-fsdev.h

  Log Message:
  -----------
  fsdev: Move some types definition to qemu-fsdev.c

It would make sense for these types to be defined in a header file if
we had an API for fsdrivers to register themselves. In practice, we
only have three of them and it is very unlikely we add new ones since
the future of file sharing between host and guest is the upcoming
virtio-fs.

Move the types to qemu-fsdev.c instead since they are only used there.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>


  Commit: aee7f3ecd8b7c3f761fde2ca5d2b4d8c45b6dfa0
      
https://github.com/qemu/qemu/commit/aee7f3ecd8b7c3f761fde2ca5d2b4d8c45b6dfa0
  Author: Greg Kurz <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M fsdev/qemu-fsdev.c

  Log Message:
  -----------
  fsdev: Error out when unsupported option is passed

Each fsdriver only supports a subset of the options that can be passed
to -fsdev. Unsupported options are simply ignored. This could cause the
user to erroneously think QEMU has a bug.

Enforce strict checking of supported options for all fsdrivers. This
shouldn't impact libvirt, since it doesn't know about the synth and
proxy fsdrivers.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 6e4199af73a5f4d03b9d9b3ab005cae33c5c6666
      
https://github.com/qemu/qemu/commit/6e4199af73a5f4d03b9d9b3ab005cae33c5c6666
  Author: Greg Kurz <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M qemu-deprecated.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  vl: Deprecate -virtfs_synth

The synth fsdriver never got used for anything else but the QTest
testcase for VirtIO 9P. And even there, QTest uses -fsdev synth and
-device virtio-9p-... directly.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>


  Commit: b44a6b09705e9e8a3005229b58de36d176020548
      
https://github.com/qemu/qemu/commit/b44a6b09705e9e8a3005229b58de36d176020548
  Author: Greg Kurz <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  virtfs: Fix documentation of -fsdev and -virtfs

This fixes several things:
- add "id" description to -virtfs documentation
- split the description into several lines in both usage and documentation
  for accurateness and clarity
- add documentation and usage of the synth fsdriver
- add "throttling.*" description to -fsdev local
- add some missing periods
- add proper reference to the virtfs-proxy-helper(1) manual page
- document that the virtio device may be either virtio-9p-pci, virtio-9p-ccw
  or virtio-9p-device, depending on the machine type

Buglink: https://bugs.launchpad.net/qemu/+bug/1581976
Signed-off-by: Greg Kurz <address@hidden>
Acked-by: Thomas Huth <address@hidden>


  Commit: 76c759e0335a4976e4c35c85a2a34ac6dab89034
      
https://github.com/qemu/qemu/commit/76c759e0335a4976e4c35c85a2a34ac6dab89034
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-20 (Mon, 20 May 2019)

  Changed paths:
    M fsdev/file-op-9p.h
    M fsdev/qemu-fsdev.c
    M fsdev/qemu-fsdev.h
    M qemu-deprecated.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging

This fixes the virtfs documentation (LP 1581976), deprecates the
-virtfs_synth command line option, along with some assorted cleanups.

# gpg: Signature made Fri 17 May 2019 19:29:40 BST
# gpg:                using RSA key B4828BAF943140CEF2A3491071D4D5E5822F73D6
# gpg: Good signature from "Greg Kurz <address@hidden>" [full]
# gpg:                 aka "Gregory Kurz <address@hidden>" [full]
# gpg:                 aka "[jpeg image of size 3330]" [full]
# Primary key fingerprint: B482 8BAF 9431 40CE F2A3  4910 71D4 D5E5 822F 73D6

* remotes/gkurz/tags/for-upstream:
  virtfs: Fix documentation of -fsdev and -virtfs
  vl: Deprecate -virtfs_synth
  fsdev: Error out when unsupported option is passed
  fsdev: Move some types definition to qemu-fsdev.c
  fsdev: Drop unused opaque field
  fsdev: Drop unused extern declaration

Signed-off-by: Peter Maydell <address@hidden>

# Conflicts:
#       qemu-deprecated.texi


Compare: https://github.com/qemu/qemu/compare/1b46b4daa6fb...76c759e0335a



reply via email to

[Prev in Thread] Current Thread [Next in Thread]