[Qemu-commits] [qemu/qemu] f80b55: target/m68k: In dump_address_map() check for memor...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f80b551ddc8b2d3ffc358f6fc7351e4100ab3dff
      
https://github.com/qemu/qemu/commit/f80b551ddc8b2d3ffc358f6fc7351e4100ab3dff
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-16 (Thu, 16 May 2019)

  Changed paths:
    M target/m68k/helper.c

  Log Message:
  -----------
  target/m68k: In dump_address_map() check for memory access failures

In dump_address_map(), use address_space_ldl() instead of ldl_phys().
This allows us to check whether the memory access failed.

Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: adcf0bf017351776510121e47b9226095836023c
      
https://github.com/qemu/qemu/commit/adcf0bf017351776510121e47b9226095836023c
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-16 (Thu, 16 May 2019)

  Changed paths:
    M target/m68k/helper.c

  Log Message:
  -----------
  target/m68k: In get_physical_address() check for memory access failures

In get_physical_address(), use address_space_ldl() and
address_space_stl() instead of ldl_phys() and stl_phys().
This allows us to check whether the memory access failed.
For the moment, we simply return -1 in this case;
add a TODO comment that we should ideally generate the
appropriate kind of fault.

Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: e1aaf3a88e95ab007445281e2b2f6e3c8da47f22
      
https://github.com/qemu/qemu/commit/e1aaf3a88e95ab007445281e2b2f6e3c8da47f22
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-16 (Thu, 16 May 2019)

  Changed paths:
    M target/m68k/cpu.c
    M target/m68k/cpu.h
    M target/m68k/op_helper.c

  Log Message:
  -----------
  target/m68k: Switch to transaction_failed hook

Switch the m68k target from the old unassigned_access hook
to the transaction_failed hook.

The notable difference is that rather than it being called
for all physical memory accesses which fail (including
those made by DMA devices or by the gdbstub), it is only
called for those made by the CPU via its MMU. (In previous
commits we put in explicit checks for the direct physical
loads made by the target/m68k code which will no longer
be handled by calling the unassigned_access hook.)

Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 89fa312be0dfd8b4c539c8763796e785c6b00b46
      
https://github.com/qemu/qemu/commit/89fa312be0dfd8b4c539c8763796e785c6b00b46
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M target/m68k/translate.c

  Log Message:
  -----------
  target/m68k: Reduce the l1 TCGLabel scope

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 44c64e90950adf9efe7f4235a32eb868d1290ebb
      
https://github.com/qemu/qemu/commit/44c64e90950adf9efe7f4235a32eb868d1290ebb
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M target/m68k/translate.c

  Log Message:
  -----------
  target/m68k: Fix a tcg_temp leak

The function gen_get_ccr() returns a tcg_temp created with
tcg_temp_new(). Free it with tcg_temp_free().

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 60d3d0cfeb1658d2827d6a4f0df27252bb36baba
      
https://github.com/qemu/qemu/commit/60d3d0cfeb1658d2827d6a4f0df27252bb36baba
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M target/m68k/translate.c

  Log Message:
  -----------
  target/m68k: Optimize rotate_x() using extract_i32()

Optimize rotate_x() using tcg_gen_extract_i32(). We can now free the
'sz' tcg_temp earlier. Since it is allocated with tcg_const_i32(),
free it with tcg_temp_free_i32().

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: b0f9690e78827d55a508c73432c73f057f59fd41
      
https://github.com/qemu/qemu/commit/b0f9690e78827d55a508c73432c73f057f59fd41
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-17 (Fri, 17 May 2019)

  Changed paths:
    M target/m68k/cpu.c
    M target/m68k/cpu.h
    M target/m68k/helper.c
    M target/m68k/op_helper.c
    M target/m68k/translate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/vivier/tags/m68k-staging-pull-request' 
into staging

code cleanup, switch to transaction_failed hook

# gpg: Signature made Thu 16 May 2019 23:33:00 BST
# gpg:                using RSA key F30C38BD3F2FBE3C
# gpg: Good signature from "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier/tags/m68k-staging-pull-request:
  target/m68k: Optimize rotate_x() using extract_i32()
  target/m68k: Fix a tcg_temp leak
  target/m68k: Reduce the l1 TCGLabel scope
  target/m68k: Switch to transaction_failed hook
  target/m68k: In get_physical_address() check for memory access failures
  target/m68k: In dump_address_map() check for memory access failures

Signed-off-by: Peter Maydell <address@hidden>

# Conflicts:
#       target/m68k/cpu.h


Compare: https://github.com/qemu/qemu/compare/d8276573da58...b0f9690e7882