qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 2467f9: util/readline: add a space to fix err

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 2467f9: util/readline: add a space to fix errors by checkp...
Date: Fri, 10 May 2019 07:24:37 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2467f95ab3c0a3076014a4548e4e769edfd9a0ee
      
https://github.com/qemu/qemu/commit/2467f95ab3c0a3076014a4548e4e769edfd9a0ee
  Author: Jules Irenge <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M util/readline.c

  Log Message:
  -----------
  util/readline: add a space to fix errors by checkpatch tool

util/readline: add a space to fix errors reported by checkpatch.pl tool
"ERROR: space required before the open parenthesis"
"ERROR: space required after that ..."
within "util/redline.c" file

Signed-off-by: Jules Irenge <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: c95d4a29c34461619f3dcdcbb429f83e1ec52cbb
      
https://github.com/qemu/qemu/commit/c95d4a29c34461619f3dcdcbb429f83e1ec52cbb
  Author: Jules Irenge <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M util/readline.c

  Log Message:
  -----------
  util: readline: replace tab indent by four spaces to fix checkpatch errors

Replace tab indent by four spaces to fix errors issued by checkpatch.pl tool
"ERROR: code indent should never use tabs" within "util/readline.c" file.

Signed-off-by: Jules Irenge <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: e238a99e89e6304a21ea4bf8f4ec3c296624199b
      
https://github.com/qemu/qemu/commit/e238a99e89e6304a21ea4bf8f4ec3c296624199b
  Author: Jules Irenge <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M util/readline.c

  Log Message:
  -----------
  util/readline: Add braces to fix checkpatch errors

Add braces to fix errors issued by checkpatch.pl tool
"ERROR: braces {} are necessary for all arms of this statement"
Within "util/readline.c" file
Message-Id: <address@hidden>

Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 66a5bdf3096cf8bc8c41eb7adcc9d10edef07a9d
      
https://github.com/qemu/qemu/commit/66a5bdf3096cf8bc8c41eb7adcc9d10edef07a9d
  Author: Nikita Alekseev <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M block.c

  Log Message:
  -----------
  block: Add coroutine_fn to bdrv_check_co_entry

bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function.
Thus, it also needs to be marked as a coroutine.

Signed-off-by: Nikita Alekseev <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 118f99442d3a8ce47836978cddd9206ac2d2b001
      
https://github.com/qemu/qemu/commit/118f99442d3a8ce47836978cddd9206ac2d2b001
  Author: Andrey Shinkevich <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M block/io.c

  Log Message:
  -----------
  block/io.c: fix for the allocation failure

On a file system used by the customer, fallocate() returns an error
if the block is not properly aligned. So, bdrv_co_pwrite_zeroes()
fails. We can handle that case the same way as it is done for the
unsupported cases, namely, call to bdrv_driver_pwritev() that writes
zeroes to an image for the unaligned chunk of the block.

Suggested-by: Denis V. Lunev <address@hidden>
Signed-off-by: Andrey Shinkevich <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 993ed89f35bf2b2250727667f2a640b3c232259f
      
https://github.com/qemu/qemu/commit/993ed89f35bf2b2250727667f2a640b3c232259f
  Author: Paolo Bonzini <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M util/aio-posix.c

  Log Message:
  -----------
  aio-posix: ensure poll mode is left when aio_notify is called

With aio=thread, adaptive polling makes latency worse rather than
better, because it delays the execution of the ThreadPool's
completion bottom half.

event_notifier_poll() does run while polling, detecting that
a bottom half was scheduled by a worker thread, but because
ctx->notifier is explicitly ignored in run_poll_handlers_once(),
scheduling the BH does not count as making progress and
run_poll_handlers() keeps running.  Fix this by recomputing
the deadline after *timeout could have changed.

With this change, ThreadPool still cannot participate in polling
but at least it does not suffer from extra latency.

Reported-by: Sergio Lopez <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Cc: Stefan Hajnoczi <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: e9d95d0163f14c487f51ffdaa12990f77018dcaa
      
https://github.com/qemu/qemu/commit/e9d95d0163f14c487f51ffdaa12990f77018dcaa
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M docs/devel/index.rst
    A docs/devel/secure-coding-practices.rst

  Log Message:
  -----------
  docs: add Secure Coding Practices to developer docs

At KVM Forum 2018 I gave a presentation on security in QEMU:
https://www.youtube.com/watch?v=YAdRf_hwxU8 (video)
https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides)

This patch adds a guide to secure coding practices.  This document
covers things that developers should know about security in QEMU.  It is
just a starting point that we can expand on later.  I hope it will be
useful as a resource for new contributors and will save code reviewers
from explaining the same concepts many times.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Acked-by: Stefano Garzarella <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Li Qiang <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: e84125761f78919fe63616d9888ea45e72dc956f
      
https://github.com/qemu/qemu/commit/e84125761f78919fe63616d9888ea45e72dc956f
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M Makefile
    A docs/security.texi
    M qemu-doc.texi

  Log Message:
  -----------
  docs: add Security chapter to the documentation

This new chapter in the QEMU documentation covers the security
requirements that QEMU is designed to meet and principles for securely
deploying QEMU.

It is just a starting point that can be extended in the future with more
information.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Acked-by: Stefano Garzarella <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Li Qiang <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: efb4f3b62c69383a7308d7b739a3193e7c0ccae8
      
https://github.com/qemu/qemu/commit/efb4f3b62c69383a7308d7b739a3193e7c0ccae8
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M Makefile
    M block.c
    M block/io.c
    M docs/devel/index.rst
    A docs/devel/secure-coding-practices.rst
    A docs/security.texi
    M qemu-doc.texi
    M util/aio-posix.c
    M util/readline.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

Pull request

# gpg: Signature made Fri 10 May 2019 14:02:22 BST
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>" [full]
# gpg:                 aka "Stefan Hajnoczi <address@hidden>" [full]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/block-pull-request:
  docs: add Security chapter to the documentation
  docs: add Secure Coding Practices to developer docs
  aio-posix: ensure poll mode is left when aio_notify is called
  block/io.c: fix for the allocation failure
  block: Add coroutine_fn to bdrv_check_co_entry
  util/readline: Add braces to fix checkpatch errors
  util: readline: replace tab indent by four spaces to fix checkpatch errors
  util/readline: add a space to fix errors by checkpatch tool

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/5f022626c880...efb4f3b62c69
reply via email to
[Prev in Thread] Current Thread [Next in Thread]