[Qemu-commits] [qemu/qemu] 08f7ad: tests/libqos: fix usage of bool in pci-pc.c

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 08f7ad1b00a00eeb6c8f499b138f41d3b59f0ece
      
https://github.com/qemu/qemu/commit/08f7ad1b00a00eeb6c8f499b138f41d3b59f0ece
  Author: Jafar Abdi <address@hidden>
  Date:   2019-04-08 (Mon, 08 Apr 2019)

  Changed paths:
    M tests/libqos/pci-pc.c

  Log Message:
  -----------
  tests/libqos: fix usage of bool in pci-pc.c

Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.

FALSE and TRUE (with capital letters) are the constants defined by glib for
being used with the "gboolean" type of glib. But some parts of the code also use
TRUE and FALSE for variables that are declared as "bool" (the type from 
<stdbool.h>).

Signed-off-by: Jafar Abdi <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: c098aac7dcc6f7c359be15c88ee26a1da8735f3f
      
https://github.com/qemu/qemu/commit/c098aac7dcc6f7c359be15c88ee26a1da8735f3f
  Author: Jafar Abdi <address@hidden>
  Date:   2019-04-08 (Mon, 08 Apr 2019)

  Changed paths:
    M tests/libqos/pci-spapr.c

  Log Message:
  -----------
  tests/libqos: fix usage of bool in pci-spapr.c

Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.

FALSE and TRUE (with capital letters) are the constants defined by glib for
being used with the "gboolean" type of glib. But some parts of the code also use
TRUE and FALSE for variables that are declared as "bool" (the type from 
<stdbool.h>).

Signed-off-by: Jafar Abdi <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Acked-by: David Gibson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: c19f2b711e15dac4c2cdbace2f8fb3a45fbed0d2
      
https://github.com/qemu/qemu/commit/c19f2b711e15dac4c2cdbace2f8fb3a45fbed0d2
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2019-04-08 (Mon, 08 Apr 2019)

  Changed paths:
    M tests/libqos/qgraph.c

  Log Message:
  -----------
  test qgraph.c: Fix segs due to out of scope default

The test uses the trick:
   if (!opts) {
     opts = &(QOSGraph...Options) { };
   }

  in a couple of places, however the temporary created
by the &() {}  goes out of scope at the bottom of the if,
and results in a seg or assert when opts-> fields are
used (on fedora 30's gcc 9).

Fixes: fc281c802022cb3a73a5
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 2c573106279495795449b0d0373464b597dfe316
      
https://github.com/qemu/qemu/commit/2c573106279495795449b0d0373464b597dfe316
  Author: Peter Maydell <address@hidden>
  Date:   2019-04-08 (Mon, 08 Apr 2019)

  Changed paths:
    M tests/libqos/pci-pc.c
    M tests/libqos/pci-spapr.c
    M tests/libqos/qgraph.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2019-04-08' into staging

- Fix a crash in libqos with GCC 9
- Fix usage of wrong boolean types in libqos

# gpg: Signature made Mon 08 Apr 2019 11:48:56 BST
# gpg:                using RSA key 2ED9D774FE702DB5
# gpg: Good signature from "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2019-04-08:
  test qgraph.c: Fix segs due to out of scope default
  tests/libqos: fix usage of bool in pci-spapr.c
  tests/libqos: fix usage of bool in pci-pc.c

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/f55a585d1037...2c5731062794