[Qemu-commits] [qemu/qemu] fd9858: trace: handle tracefs path truncation

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] fd9858: trace: handle tracefs path truncation

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] fd9858: trace: handle tracefs path truncation
Date:	Mon, 25 Mar 2019 18:08:52 +0000 (UTC)
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: fd9858317a3d06c94ad8c1c420e6b5c376f5a92e
      
https://github.com/qemu/qemu/commit/fd9858317a3d06c94ad8c1c420e6b5c376f5a92e
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2019-03-22 (Fri, 22 Mar 2019)

  Changed paths:
    M trace/ftrace.c

  Log Message:
  -----------
  trace: handle tracefs path truncation

If the tracefs mountpoint has a very long path we may exceed PATH_MAX.
This is a system misconfiguration and the user must resolve it so that
applications can perform path-based system calls successfully.

This issue does not occur on real-world systems since tracefs is mounted
on /sys/kernel/debug/tracing/, but the compiler is smart enough to
foresee the possibility and warn about the unchecked snprintf(3) return
value.  This patch fixes the compiler warning.

Reported-by: Markus Armbruster <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Liam Merwick <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: b33b890cd07eca1d05cd8c4f5f03790f0585423f
      
https://github.com/qemu/qemu/commit/b33b890cd07eca1d05cd8c4f5f03790f0585423f
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2019-03-22 (Fri, 22 Mar 2019)

  Changed paths:
    M scripts/tracetool/format/d.py

  Log Message:
  -----------
  trace: avoid SystemTap dtrace(1) warnings on empty files

target/hppa/trace-events only contains disabled events, resulting in a
trace-dtrace.dtrace file that says "provider qemu {}".  SystemTap's
dtrace(1) tool prints a warning when processing this input file.

This patch avoids the error by emitting an empty file instead of
"provider qemu {}" when there are no enabled trace events.

Fixes: 23c3d569f44284066714ff7c46bc4f19e630583f ("target/hppa: add TLB trace 
events")
Reported-by: Markus Armbruster <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Liam Merwick <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: e68b3baa25c91760ad176ace4f394c2db9240783
      
https://github.com/qemu/qemu/commit/e68b3baa25c91760ad176ace4f394c2db9240783
  Author: Markus Armbruster <address@hidden>
  Date:   2019-03-22 (Fri, 22 Mar 2019)

  Changed paths:
    M accel/kvm/trace-events
    M accel/tcg/trace-events
    M hw/i386/xen/trace-events
    M nbd/trace-events
    M qapi/trace-events
    M scsi/trace-events
    M trace-events

  Log Message:
  -----------
  trace-events: Consistently point to docs/devel/tracing.txt

Almost all trace-events point to docs/devel/tracing.txt in a comment
right at the beginning.  Touch up the ones that don't.

[Updated with Markus' new commit description wording.
--Stefan]

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 500016e5db5826fbcc5db17f9992b22d936acb83
      
https://github.com/qemu/qemu/commit/500016e5db5826fbcc5db17f9992b22d936acb83
  Author: Markus Armbruster <address@hidden>
  Date:   2019-03-22 (Fri, 22 Mar 2019)

  Changed paths:
    M audio/trace-events
    M authz/trace-events
    M block/trace-events
    M chardev/trace-events
    M crypto/trace-events
    M hw/9pfs/trace-events
    M hw/acpi/trace-events
    M hw/alpha/trace-events
    M hw/arm/trace-events
    M hw/audio/trace-events
    M hw/block/dataplane/trace-events
    M hw/block/trace-events
    M hw/char/trace-events
    M hw/display/trace-events
    M hw/dma/trace-events
    M hw/gpio/trace-events
    M hw/hppa/trace-events
    M hw/i2c/trace-events
    M hw/i386/trace-events
    M hw/i386/xen/trace-events
    M hw/ide/trace-events
    M hw/input/trace-events
    M hw/intc/trace-events
    M hw/isa/trace-events
    M hw/mem/trace-events
    M hw/misc/macio/trace-events
    M hw/misc/trace-events
    M hw/net/trace-events
    M hw/nvram/trace-events
    M hw/pci-host/trace-events
    M hw/pci/trace-events
    M hw/ppc/trace-events
    M hw/rdma/trace-events
    M hw/rdma/vmw/trace-events
    M hw/s390x/trace-events
    M hw/scsi/trace-events
    M hw/sd/trace-events
    M hw/sparc/trace-events
    M hw/sparc64/trace-events
    M hw/timer/trace-events
    M hw/tpm/trace-events
    M hw/usb/trace-events
    M hw/vfio/trace-events
    M hw/virtio/trace-events
    M hw/watchdog/trace-events
    M hw/xen/trace-events
    M io/trace-events
    M linux-user/trace-events
    M migration/trace-events
    M nbd/trace-events
    M net/trace-events
    M qapi/trace-events
    M qom/trace-events
    M scsi/trace-events
    M target/arm/trace-events
    M target/hppa/trace-events
    M target/i386/trace-events
    M target/mips/trace-events
    M target/ppc/trace-events
    M target/s390x/trace-events
    M target/sparc/trace-events
    M ui/trace-events
    M util/trace-events

  Log Message:
  -----------
  trace-events: Shorten file names in comments

We spell out sub/dir/ in sub/dir/trace-events' comments pointing to
source files.  That's because when trace-events got split up, the
comments were moved verbatim.

Delete the sub/dir/ part from these comments.  Gets rid of several
misspellings.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: a44cf524f823a6155909ea541a3b0d57eac41234
      
https://github.com/qemu/qemu/commit/a44cf524f823a6155909ea541a3b0d57eac41234
  Author: Markus Armbruster <address@hidden>
  Date:   2019-03-22 (Fri, 22 Mar 2019)

  Changed paths:
    M scripts/cleanup-trace-events.pl

  Log Message:
  -----------
  scripts/cleanup-trace-events: Update for current practice

Emit comments with shortened file names (previous commit).

Limit search to the input file's directory.

Cope with properties tcg (commit b2b36c22bd8) and vcpu (commit
3d211d9f4db).

Cope with capital letters in function names.

Signed-off-by: Markus Armbruster <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: a9779a3ab0c616ef3e0423f218145bc7d1de03f2
      
https://github.com/qemu/qemu/commit/a9779a3ab0c616ef3e0423f218145bc7d1de03f2
  Author: Markus Armbruster <address@hidden>
  Date:   2019-03-22 (Fri, 22 Mar 2019)

  Changed paths:
    M block/trace-events
    M hw/arm/trace-events
    M hw/block/trace-events
    M hw/display/trace-events
    M hw/i386/trace-events
    M hw/ide/trace-events
    M hw/intc/trace-events
    M hw/misc/macio/trace-events
    M hw/misc/trace-events
    M hw/ppc/trace-events
    M hw/sd/trace-events
    M hw/vfio/trace-events
    M nbd/trace-events
    M util/trace-events

  Log Message:
  -----------
  trace-events: Delete unused trace points

Tracked down with cleanup-trace-events.pl.  Funnies requiring manual
post-processing:

* block.c and blockdev.c trace points are in block/trace-events.

* hw/block/nvme.c uses the preprocessor to hide its trace point use
  from cleanup-trace-events.pl.

* include/hw/xen/xen_common.h trace points are in hw/xen/trace-events.

* net/colo-compare and net/filter-rewriter.c use pseudo trace points
  colo_compare_udp_miscompare and colo_filter_rewriter_debug to guard
  debug code.

Signed-off-by: Markus Armbruster <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: dec9776049e32d6c830127b286530c5f53267eff
      
https://github.com/qemu/qemu/commit/dec9776049e32d6c830127b286530c5f53267eff
  Author: Markus Armbruster <address@hidden>
  Date:   2019-03-22 (Fri, 22 Mar 2019)

  Changed paths:
    M authz/trace-events
    M hw/9pfs/trace-events
    M hw/arm/trace-events
    M hw/block/trace-events
    M hw/char/trace-events
    M hw/display/trace-events
    M hw/ide/trace-events
    M hw/input/trace-events
    M hw/misc/trace-events
    M hw/net/trace-events
    M hw/ppc/trace-events
    M hw/timer/trace-events
    M hw/vfio/trace-events
    M hw/watchdog/trace-events
    M linux-user/trace-events
    M migration/trace-events
    M trace-events
    M ui/trace-events
    M util/trace-events

  Log Message:
  -----------
  trace-events: Fix attribution of trace points to source

Some trace points are attributed to the wrong source file.  Happens
when we neglect to update trace-events for code motion, or add events
in the wrong place, or misspell the file name.

Clean up with help of cleanup-trace-events.pl.  Same funnies as in the
previous commit, of course.  Manually shorten its change to
linux-user/trace-events to */signal.c.

Signed-off-by: Markus Armbruster <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: d132baa05ed7a647067c807fd452ec794cc2ecb7
      
https://github.com/qemu/qemu/commit/d132baa05ed7a647067c807fd452ec794cc2ecb7
  Author: Peter Maydell <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M accel/kvm/trace-events
    M accel/tcg/trace-events
    M audio/trace-events
    M authz/trace-events
    M block/trace-events
    M chardev/trace-events
    M crypto/trace-events
    M hw/9pfs/trace-events
    M hw/acpi/trace-events
    M hw/alpha/trace-events
    M hw/arm/trace-events
    M hw/audio/trace-events
    M hw/block/dataplane/trace-events
    M hw/block/trace-events
    M hw/char/trace-events
    M hw/display/trace-events
    M hw/dma/trace-events
    M hw/gpio/trace-events
    M hw/hppa/trace-events
    M hw/i2c/trace-events
    M hw/i386/trace-events
    M hw/i386/xen/trace-events
    M hw/ide/trace-events
    M hw/input/trace-events
    M hw/intc/trace-events
    M hw/isa/trace-events
    M hw/mem/trace-events
    M hw/misc/macio/trace-events
    M hw/misc/trace-events
    M hw/net/trace-events
    M hw/nvram/trace-events
    M hw/pci-host/trace-events
    M hw/pci/trace-events
    M hw/ppc/trace-events
    M hw/rdma/trace-events
    M hw/rdma/vmw/trace-events
    M hw/s390x/trace-events
    M hw/scsi/trace-events
    M hw/sd/trace-events
    M hw/sparc/trace-events
    M hw/sparc64/trace-events
    M hw/timer/trace-events
    M hw/tpm/trace-events
    M hw/usb/trace-events
    M hw/vfio/trace-events
    M hw/virtio/trace-events
    M hw/watchdog/trace-events
    M hw/xen/trace-events
    M io/trace-events
    M linux-user/trace-events
    M migration/trace-events
    M nbd/trace-events
    M net/trace-events
    M qapi/trace-events
    M qom/trace-events
    M scripts/cleanup-trace-events.pl
    M scripts/tracetool/format/d.py
    M scsi/trace-events
    M target/arm/trace-events
    M target/hppa/trace-events
    M target/i386/trace-events
    M target/mips/trace-events
    M target/ppc/trace-events
    M target/s390x/trace-events
    M target/sparc/trace-events
    M trace-events
    M trace/ftrace.c
    M ui/trace-events
    M util/trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' 
into staging

Pull request

Compilation fixes and cleanups for QEMU 4.0.0.

# gpg: Signature made Mon 25 Mar 2019 15:58:28 GMT
# gpg:                using RSA key 9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>" [full]
# gpg:                 aka "Stefan Hajnoczi <address@hidden>" [full]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/tracing-pull-request:
  trace-events: Fix attribution of trace points to source
  trace-events: Delete unused trace points
  scripts/cleanup-trace-events: Update for current practice
  trace-events: Shorten file names in comments
  trace-events: Consistently point to docs/devel/tracing.txt
  trace: avoid SystemTap dtrace(1) warnings on empty files
  trace: handle tracefs path truncation

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/50ccc488b0d4...d132baa05ed7
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] fd9858: trace: handle tracefs path truncation, Peter Maydell <=
Prev by Date: [Qemu-commits] [qemu/qemu] a036f5: target/arm: Fix non-parallel expansion of CASP
Next by Date: [Qemu-commits] [qemu/qemu] ad24c7: multifd: Only send pages when packet are not empty
Previous by thread: [Qemu-commits] [qemu/qemu] a036f5: target/arm: Fix non-parallel expansion of CASP
Next by thread: [Qemu-commits] [qemu/qemu] ad24c7: multifd: Only send pages when packet are not empty
Index(es):
- Date
- Thread