[Qemu-commits] [qemu/qemu] bb6c8d: qga: update docs with systemd suspend support info

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bb6c8d407e49d7b805ac52fe46abf4d8d5262046
      
https://github.com/qemu/qemu/commit/bb6c8d407e49d7b805ac52fe46abf4d8d5262046
  Author: Daniel Henrique Barboza <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: update docs with systemd suspend support info

Commit 067927d62e ("qga: systemd hibernate/suspend/hybrid-sleep
support") failed to update qapi-schema.json after adding systemd
hibernate/suspend/hybrid-sleep capabilities to guest-suspend-* QGA
commands.

Signed-off-by: Daniel Henrique Barboza <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: bd586a91338a653082fae7886e0c2dd2f65ca099
      
https://github.com/qemu/qemu/commit/bd586a91338a653082fae7886e0c2dd2f65ca099
  Author: Bishara AbuHattoum <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M qga/commands-win32.c

  Log Message:
  -----------
  qga-win: Adding support for Windows Server 2019 get-osinfo command

Since Windows Server 2016, Microsoft stopped upgrading the major and minor
versions of their new Windows Server product, so, the current functionality
of checking major and minor version numbers to determine the Windows Server
version wont work as expected.
The implemented solution here is to use the build number in addition to the
major and minor version numbers of the product to determine the Windows
Server product version.
The final build number of Windows Server 2016 is 14939, and
the final build number of Windows Server 2019 is 17764, so any Windows
Server product that has the major version of 10 and minor version of 0
with a build number lower or equal to 14939 will resemble 2016 and if the
build number is lower or equal to 17763 will resemble 2019.

Reference:
https://techcommunity.microsoft.com/t5/Windows-Server-Insiders/Windows-Server-2019-version-info/m-p/293112/highlight/true#M859

Signed-off-by: Bishara AbuHattoum <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 82a58d270c6fbbe2f2381224946340fd3814a273
      
https://github.com/qemu/qemu/commit/82a58d270c6fbbe2f2381224946340fd3814a273
  Author: Michael Roth <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M qga/vss-win32/Makefile.objs

  Log Message:
  -----------
  qga-win: include glib when building VSS DLL

Commit 3ebee3b191e defined assert() as g_assert(), but when we build
the VSS DLL component of QGA (to handle fsfreeze) we do not include
glib, which results in breakage when building with VSS support enabled.

Fix this by including glib (along with the -lintl and -lws2_32
dependencies it brings).

Since the VSS DLL is built statically, this introduces an additional
dependency on static glib and supporting libs for the mingw environment
(possibly why we didn't include glib originally), but VSS support
already has very specific prerequisites so it shouldn't affect too many
build environments.

Since the VSS DLL code does use qemu/osdep.h, this should also help
avoid future breakages and possibly allow for some clean ups in current
VSS code.

Suggested-by: Daniel P. Berrangé <address@hidden>
Cc: Daniel P. Berrangé <address@hidden>
Cc: address@hidden
Signed-off-by: Michael Roth <address@hidden>


  Commit: 40cebc58117dbc6275a5d7c4e3ba6611964d9e6e
      
https://github.com/qemu/qemu/commit/40cebc58117dbc6275a5d7c4e3ba6611964d9e6e
  Author: Michael Roth <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M qga/vss-win32/Makefile.objs

  Log Message:
  -----------
  qga-win: fix VSS build breakage due to unintended gnu99 C++ flag

Commit 7be41675f7c set -std=gnu99 for C code via QEMU_CFLAGS. Currently
we generate a "custom" QEMU_CXXFLAGS for VSS DLL C++ build by
filtering out some options from QEMU_CFLAGS and adding some others.
Since we don't filter out -std=gnu99 currently this breaks builds when
VSS support is enabled.

We could keep the existing approach, filter out -std=gnu99 from
QEMU_CFLAGS, and add -std=gnu++98, like configure currently does for
QEMU_CXXFLAGS, but as it turns out our resulting QEMU_CXXFLAGS would
be exactly what configure already generates, just with these filtered
out:

  -fstack-protector-all -fstack-protector-strong

and these added:

  -Wno-unknown-pragmas -Wno-delete-non-virtual-dtor

So fix the issue by re-using configure-generated QEMU_CXXFLAGS and
just handling these specific changes.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: 996b9cdc2f190a173e48f4c8d64de3d50e570b7b
      
https://github.com/qemu/qemu/commit/996b9cdc2f190a173e48f4c8d64de3d50e570b7b
  Author: Matt Hines <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M configure
    M qga/commands-win32.c

  Log Message:
  -----------
  qga: Fix guest-get-fsinfo PCI address collection in Windows

The Windows QEMU guest agent erroneously tries to collect PCI information
directly from the physical drive. However, windows stores SCSI/IDE information
with the drive and PCI information with the underlying storage controller
This changes get_pci_info to use the physical drive's underlying storage
controller to get PCI information.

* Additionally Fixes incorrect size being passed to DeviceIoControl
  when getting volume extents. Can occasionally crash the guest agent

Signed-off-by: Matt Hines <address@hidden>
*fix up some checkpatch warnings
*fix domain reporting and add some sanity checks for debug
Signed-off-by: Michael Roth <address@hidden>


  Commit: 781f2b3d1e5ef389b44016a897fd55e7a780bf35
      
https://github.com/qemu/qemu/commit/781f2b3d1e5ef389b44016a897fd55e7a780bf35
  Author: Marc-André Lureau <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M qga/main.c

  Log Message:
  -----------
  qga: process_event() simplification

Simplify the code around qmp_dispatch():
- rely on qmp_dispatch/check_obj() for message checking
- have a single send_response() point
- constify send_response() argument

It changes a couple of error messages:

* When @req isn't a dictionary, from
    Invalid JSON syntax
  to
    QMP input must be a JSON object

* When @req lacks member "execute", from
    this feature or command is not currently supported
  to
    QMP input lacks member 'execute'

CC: Michael Roth <address@hidden>
Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 4eaca8de268d74ac5daaf8938abcb69d37ba2889
      
https://github.com/qemu/qemu/commit/4eaca8de268d74ac5daaf8938abcb69d37ba2889
  Author: Marc-André Lureau <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M monitor.c
    M qapi/qmp-dispatch.c
    M tests/test-qga.c

  Log Message:
  -----------
  qmp: common 'id' handling & make QGA conform to QMP spec

Let qmp_dispatch() copy the 'id' field. That way any qmp client will
conform to the specification, including QGA. Furthermore, it
simplifies the work for qemu monitor.

CC: Michael Roth <address@hidden>
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 54281eefc2597d5452720ca88a9b9c96574e1195
      
https://github.com/qemu/qemu/commit/54281eefc2597d5452720ca88a9b9c96574e1195
  Author: Peter Maydell <address@hidden>
  Date:   2019-03-19 (Tue, 19 Mar 2019)

  Changed paths:
    M configure
    M monitor.c
    M qapi/qmp-dispatch.c
    M qga/commands-win32.c
    M qga/main.c
    M qga/qapi-schema.json
    M qga/vss-win32/Makefile.objs
    M tests/test-qga.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2019-03-18-tag' 
into staging

qemu-ga patch queue for 4.0

* fix w32 build breakages with VSS enabled
* fix PCI topology reporting for Windows
* fix OS version reporting for Windows
* add systemd info to qga schema documentation
* add proper 'id' handling to QGA so it conforms to QMP spec

# gpg: Signature made Mon 18 Mar 2019 16:20:32 GMT
# gpg:                using RSA key CEACC9E15534EBABB82D3FA03353C9CEF108B584
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Michael Roth <address@hidden>" [full]
# gpg:                 aka "Michael Roth <address@hidden>" [full]
# gpg:                 aka "Michael Roth <address@hidden>" [full]
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* remotes/mdroth/tags/qga-pull-2019-03-18-tag:
  qmp: common 'id' handling & make QGA conform to QMP spec
  qga: process_event() simplification
  qga: Fix guest-get-fsinfo PCI address collection in Windows
  qga-win: fix VSS build breakage due to unintended gnu99 C++ flag
  qga-win: include glib when building VSS DLL
  qga-win: Adding support for Windows Server 2019 get-osinfo command
  qga: update docs with systemd suspend support info

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/082c0543baa6...54281eefc259