[Qemu-commits] [qemu/qemu] 71f287: audio: Use g_strdup_printf instead of manual build...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 71f2874fc10cfd0c0dbbe560d250d0cafa9fe220
      
https://github.com/qemu/qemu/commit/71f2874fc10cfd0c0dbbe560d250d0cafa9fe220
  Author: Frediano Ziglio <address@hidden>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: Use g_strdup_printf instead of manual building a string

Instead of using lot of low level function and manually allocate
the temporary string in audio_process_options use more high
level GLib function. The function is not used in hot path but to
read some initial setting.

Signed-off-by: Frediano Ziglio <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e8d8544402c950a82fdd125d1cc73170e2e21bdc
      
https://github.com/qemu/qemu/commit/e8d8544402c950a82fdd125d1cc73170e2e21bdc
  Author: Frediano Ziglio <address@hidden>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: Do not check for audio_calloc failure

audio_calloc uses g_malloc0 which never returns in case of
memory failure.

Signed-off-by: Frediano Ziglio <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 7183834a29fbaf422a62cfbe166b719393fafa67
      
https://github.com/qemu/qemu/commit/7183834a29fbaf422a62cfbe166b719393fafa67
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M configure

  Log Message:
  -----------
  audio: don't build alsa and sdl by default on linux

In case no sound hardware is present both alsa and sdl drivers
initialize successfully and throw errors later on, i.e. effectively
the automatic probing doesn't work.  Drop them from the list of
default audio drivers for linux because of that.

Fixes: 6a48541873 audio: probe audio drivers by default
Buglink: https://bugs.launchpad.net/qemu/+bug/1816052
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Tested-by: David Hildenbrand <address@hidden>
Message-id: address@hidden


  Commit: 8a7816c4ac13e6ba61de2be1e4e93ed71bc26266
      
https://github.com/qemu/qemu/commit/8a7816c4ac13e6ba61de2be1e4e93ed71bc26266
  Author: Thomas Huth <address@hidden>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  audio/sdlaudio: Remove the semaphore code

The semaphore code was only working with SDL1.2 - with SDL2, it causes
a deadlock. Since we've removed support for SDL1.2 recently, we can
now completely remove the semaphore code from sdlaudio.c.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 9399ef168377d9e7f2e33b1c2eb61751aa1b72fa
      
https://github.com/qemu/qemu/commit/9399ef168377d9e7f2e33b1c2eb61751aa1b72fa
  Author: Thomas Huth <address@hidden>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  audio/sdlaudio: Simplify the sdl_callback function

At the end of the while-loop, either "samples" or "sdl->live" is zero, so
now that we've removed the semaphore code, the content of the while-loop
is always only executed once. Thus we can remove the while-loop now to
get rid of one indentation level here.

Signed-off-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 21ee7686d7b63c3e58a7ccab33315a8c543c7171
      
https://github.com/qemu/qemu/commit/21ee7686d7b63c3e58a7ccab33315a8c543c7171
  Author: Peter Maydell <address@hidden>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M audio/audio.c
    M audio/sdlaudio.c
    M configure

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/audio-20190228-pull-request' into staging

audio: fixes and cleanups.

# gpg: Signature made Thu 28 Feb 2019 10:08:44 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/audio-20190228-pull-request:
  audio/sdlaudio: Simplify the sdl_callback function
  audio/sdlaudio: Remove the semaphore code
  audio: don't build alsa and sdl by default on linux
  audio: Do not check for audio_calloc failure
  audio: Use g_strdup_printf instead of manual building a string

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/711d13d5e2e1...21ee7686d7b6