[Qemu-commits] [qemu/qemu] f67cf6: dirty-bitmap: Expose persistent flag to 'query-block'

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f67cf661f8b88afe8a5ea2f120583924cba9087f
      
https://github.com/qemu/qemu/commit/f67cf661f8b88afe8a5ea2f120583924cba9087f
  Author: Eric Blake <address@hidden>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M block/dirty-bitmap.c
    M qapi/block-core.json
    M tests/qemu-iotests/124
    M tests/qemu-iotests/236.out

  Log Message:
  -----------
  dirty-bitmap: Expose persistent flag to 'query-block'

Since qemu currently doesn't flush persistent bitmaps to disk until
shutdown (which might be MUCH later), it's useful if 'query-block'
at least shows WHICH bitmaps will (eventually) make it to persistent
storage.  Update affected iotests.

Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 73ab5d601c8b4311090a70e525f5970f70b8b2a0
      
https://github.com/qemu/qemu/commit/73ab5d601c8b4311090a70e525f5970f70b8b2a0
  Author: John Snow <address@hidden>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M block/dirty-bitmap.c
    M qapi/block-core.json

  Log Message:
  -----------
  block/dirty-bitmap: Documentation and Comment fixups

The meaning of the states has changed subtly over time,
this should bring the understanding more in-line with the
current, actual usages.

Reported-by: Eric Blake <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 0a6c86d024c52b1e66d4f7ec01a3bb8ea2600145
      
https://github.com/qemu/qemu/commit/0a6c86d024c52b1e66d4f7ec01a3bb8ea2600145
  Author: John Snow <address@hidden>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M blockdev.c

  Log Message:
  -----------
  blockdev: acquire aio_context for bitmap add/remove

When bitmaps are persistent, they may incur a disk read or write when bitmaps
are added or removed. For configurations like virtio-dataplane, failing to
acquire this lock will abort QEMU when disk IO occurs.

We used to acquire aio_context as part of the bitmap lookup, so re-introduce
the lock for just the cases that have an IO penalty. Commit 2119882c removed
these locks, and I failed to notice this when we committed fd5ae4cc, so this
has been broken since persistent bitmaps were introduced.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1672010
Reported-By: Aihua Liang <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9
      
https://github.com/qemu/qemu/commit/fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9
  Author: Peter Maydell <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M block/dirty-bitmap.c
    M blockdev.c
    M qapi/block-core.json
    M tests/qemu-iotests/124
    M tests/qemu-iotests/236.out

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into 
staging

Pull request

# gpg: Signature made Wed 20 Feb 2019 18:01:00 GMT
# gpg:                using RSA key F9B7ABDBBCACDF95BE76CBD07DEF8106AAFC390E
# gpg: Good signature from "John Snow (John Huston) <address@hidden>" [full]
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* remotes/jnsnow/tags/bitmaps-pull-request:
  blockdev: acquire aio_context for bitmap add/remove
  block/dirty-bitmap: Documentation and Comment fixups
  dirty-bitmap: Expose persistent flag to 'query-block'

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/039e40660385...fc3dbb90f2eb