qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a8260d: ui: install logo icons to $prefix/sha


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] a8260d: ui: install logo icons to $prefix/share/icons
Date: Wed, 23 Jan 2019 13:49:55 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a8260d3876389eb52ca5c62ed4d80cdb7e025c85
      
https://github.com/qemu/qemu/commit/a8260d3876389eb52ca5c62ed4d80cdb7e025c85
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M Makefile
    M configure
    R pc-bios/qemu-icon.bmp
    R pc-bios/qemu_logo_no_text.svg
    M ui/gtk.c
    A ui/icons/Makefile
    A ui/icons/qemu.svg
    A ui/icons/qemu_128x128.png
    A ui/icons/qemu_16x16.png
    A ui/icons/qemu_24x24.png
    A ui/icons/qemu_256x256.png
    A ui/icons/qemu_32x32.bmp
    A ui/icons/qemu_32x32.png
    A ui/icons/qemu_48x48.png
    A ui/icons/qemu_512x512.png
    A ui/icons/qemu_64x64.png
    M ui/sdl2.c

  Log Message:
  -----------
  ui: install logo icons to $prefix/share/icons

QEMU currently installs logos to $prefix/share/qemu/ which means no GUI
toolkit or applications can find them by default.

The accepted standards for desktop applications declare that application
logos / icons should be installed under $prefix/share/icons, so use this
directory location.

Pre-rendered icons are provided at the standard sizes expected for GUI
applications, along with the scalable SVG, to ensure maximum portability.

The PNGs are rendered from the SVG using inkscape, however, this is not
wired up into the default make rules to avoid requiring inkscape as a
mandatory tool in build systems / developer workstations.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 67ea95468230fd1619235bf54b63c384cb3a9c51
      
https://github.com/qemu/qemu/commit/67ea95468230fd1619235bf54b63c384cb3a9c51
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M Makefile
    M configure
    M ui/gtk.c
    A ui/qemu.desktop

  Log Message:
  -----------
  ui: fix icon display for GTK frontend under GNOME Shell with Wayland

The icon associated with a GtkWindow is just a hint to window managers
and not all of them will honour it. Some will instead want to show the
icon listed by the .desktop file. The desktop file is located based on
the application ID, which is set using g_set_prgname. QEMU has not
historically provided a desktop file or set its app ID, so it got a
broken icon in GNOME shell, which is now fixed.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: a442fe2f2b2f20e7be0934277e9400b844b11999
      
https://github.com/qemu/qemu/commit/a442fe2f2b2f20e7be0934277e9400b844b11999
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M configure
    M include/ui/sdl2.h
    M ui/sdl2.c

  Log Message:
  -----------
  sdl: add support for high resolution window icon

Modern desktop environments can render icons at very large sizes,
especially with high DPI screens. Providing a 32x32 pixel bitmap is
nowhere near sufficient anymore.

When displayed in GNOME shell the QEMU icon looks awful, having been
scaled up to at least x4 its base size. This is compounded by the fact
that the BMP file doesn't do transparency, so while we've removed white
pixels, we still have anti-aliased nearly-white pixels which make the
logo look appalling on black backgrounds.

Loading a high resolution PNG icon addresses both problems, but requires
use of the extra SDL2_image library.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 61e77a5f0c788495566aecb437bcf6b2cf9cda97
      
https://github.com/qemu/qemu/commit/61e77a5f0c788495566aecb437bcf6b2cf9cda97
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: detect and optimize pageflips

When size and format of the display surface stays the same we can just
tag the guest display as dirty and be done with it.

There is no need need to resize the vnc server display or to touch the
vnc client dirty bits.  On the next refresh cycle
vnc_refresh_server_surface() will check for actual display content
changes and update the client dirty bits as needed.

The desktop resize and framebuffer format notifications to the vnc
client will be skipped too.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden


  Commit: fbd57c754f32804a63295f70f271d1ef128ee590
      
https://github.com/qemu/qemu/commit/fbd57c754f32804a63295f70f271d1ef128ee590
  Author: Alexander Kanavin <address@hidden>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M include/ui/egl-helpers.h
    M ui/egl-helpers.c
    M ui/gtk-egl.c

  Log Message:
  -----------
  egl-helpers.h: do not depend on X11 Window type, use EGLNativeWindowType

It was assumed that mesa provides the necessary X11 includes,
but it is not always the case, as it can be configured without x11 support.

Signed-off-by: Alexander Kanavin <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden

[ kraxel: codestyle fix (long line) ]

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f6b06fcceef465de0cf2514c9f76fe0192896781
      
https://github.com/qemu/qemu/commit/f6b06fcceef465de0cf2514c9f76fe0192896781
  Author: Peter Maydell <address@hidden>
  Date:   2019-01-23 (Wed, 23 Jan 2019)

  Changed paths:
    M Makefile
    M configure
    M include/ui/egl-helpers.h
    M include/ui/sdl2.h
    R pc-bios/qemu-icon.bmp
    R pc-bios/qemu_logo_no_text.svg
    M ui/egl-helpers.c
    M ui/gtk-egl.c
    M ui/gtk.c
    A ui/icons/Makefile
    A ui/icons/qemu.svg
    A ui/icons/qemu_128x128.png
    A ui/icons/qemu_16x16.png
    A ui/icons/qemu_24x24.png
    A ui/icons/qemu_256x256.png
    A ui/icons/qemu_32x32.bmp
    A ui/icons/qemu_32x32.png
    A ui/icons/qemu_48x48.png
    A ui/icons/qemu_512x512.png
    A ui/icons/qemu_64x64.png
    A ui/qemu.desktop
    M ui/sdl2.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190121-pull-request' 
into staging

ui: highres logo for sdl and gtk, bugfixes for vnc and egl.

# gpg: Signature made Mon 21 Jan 2019 14:11:39 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20190121-pull-request:
  egl-helpers.h: do not depend on X11 Window type, use EGLNativeWindowType
  vnc: detect and optimize pageflips
  sdl: add support for high resolution window icon
  ui: fix icon display for GTK frontend under GNOME Shell with Wayland
  ui: install logo icons to $prefix/share/icons

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/fcb700b72989...f6b06fcceef4
      **NOTE:** GitHub Services has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      We will provide an alternative path for the email notifications by 
January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]