qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5a301b: docs/pvrdma: Update rdmacm-mux docume

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 5a301b: docs/pvrdma: Update rdmacm-mux documentation
Date: Tue, 22 Jan 2019 01:47:41 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5a301bb9f1b33764384f25b749e30091a5abefce
      
https://github.com/qemu/qemu/commit/5a301bb9f1b33764384f25b749e30091a5abefce
  Author: Kamal Heib <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M docs/pvrdma.txt

  Log Message:
  -----------
  docs/pvrdma: Update rdmacm-mux documentation

Before running the rdmacm-mux need to make sure that both the ib_cm
and rdma_cm kernel modules are unloaded.

Reviewed-by: Yuval Shaia <address@hidden>
Signed-off-by: Kamal Heib <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: ffef47754a1fdae2fdcea267bd98172dc5a877c5
      
https://github.com/qemu/qemu/commit/ffef47754a1fdae2fdcea267bd98172dc5a877c5
  Author: Yuval Shaia <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M docs/pvrdma.txt
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_backend.h
    M hw/rdma/vmw/pvrdma_main.c
    M hw/rdma/vmw/pvrdma_qp_ops.c

  Log Message:
  -----------
  hw/pvrdma: Remove max-sge command-line param

This parameter has no effect, fix it.

The function init_dev_caps sets the front-end's max-sge to MAX_SGE. Then
it checks backend's max-sge and adjust it accordingly (we can't send
more than what the device supports).

On send and recv we need to make sure the num_sge in the WQE does not
exceeds the backend device capability.
This check is done in pvrdma level so check on rdma level is deleted.

Signed-off-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marcel Apfelbaum<address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 732d948ca52d1a91a0930acfd7610598d4e78903
      
https://github.com/qemu/qemu/commit/732d948ca52d1a91a0930acfd7610598d4e78903
  Author: Yuval Shaia <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_backend_defs.h

  Log Message:
  -----------
  hw/rdma: Delete unused struct member

This member is used only in init_device_caps function, make it local.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum<address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 26fd869556bb9513bf82ad9573c906b2a631576e
      
https://github.com/qemu/qemu/commit/26fd869556bb9513bf82ad9573c906b2a631576e
  Author: Yuval Shaia <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M hw/rdma/rdma_backend.h
    M hw/rdma/vmw/pvrdma_qp_ops.c

  Log Message:
  -----------
  hw/pvrdma: Post CQE when receive invalid gid index

This error should propagate back to guest.

Spotted by Coverity: CID 1398595

Fixes: 2b05705dc8

Reported-by: Li Qiang <address@hidden>
Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>


  Commit: 5bb8b739879f255fb3587238611334584ddcd99b
      
https://github.com/qemu/qemu/commit/5bb8b739879f255fb3587238611334584ddcd99b
  Author: Yuval Shaia <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M hw/rdma/vmw/pvrdma_qp_ops.c
    M hw/rdma/vmw/pvrdma_qp_ops.h

  Log Message:
  -----------
  hw/pvrdma: Make function pvrdma_qp_send/recv return void.

The functions handles errors internaly, callers have nothing to do with
the return value.

Signed-off-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marcel Apfelbaum<address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: a1aa88b7dcac2b22d74908f9276d5d145d8e65a0
      
https://github.com/qemu/qemu/commit/a1aa88b7dcac2b22d74908f9276d5d145d8e65a0
  Author: Yuval Shaia <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_rm.c

  Log Message:
  -----------
  hw/rdma: Verify that ptr is not NULL before freeing

To cover the case where fini() was called even when init() fails make
sure objects are not NULL before calling to non-null-safe destructors.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: a5fe209d71f311afb0035ce39e9472f9b31445e9
      
https://github.com/qemu/qemu/commit/a5fe209d71f311afb0035ce39e9472f9b31445e9
  Author: Li Qiang <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M hw/rdma/rdma_rm.c

  Log Message:
  -----------
  hw: rdma: fix an off-by-one issue

In rdma_rm_get_backend_gid_index(), the 'sgid_idx' is used
to index the array 'dev_res->port.gid_tbl' which size is
MAX_PORT_GIDS. Current the 'sgid_idx' may be MAX_PORT_GIDS
thus cause an off-by-one issue.

Spotted by Coverity: CID 1398594

Signed-off-by: Li Qiang <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 4a3d55a097695e17a3a39efc0434db95501241b2
      
https://github.com/qemu/qemu/commit/4a3d55a097695e17a3a39efc0434db95501241b2
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M contrib/rdmacm-mux/Makefile.objs
    M contrib/rdmacm-mux/main.c

  Log Message:
  -----------
  contrib/rdmacm-mux: remove Wno-format-truncation flag

The flag is not recognized by some CLANG versions.
Add proper constraints in code instead.

Reviewed-by: Yuval Shaia <address@hidden>
Tested-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 555b3d67bc64bbcc3005f6619ab42552616bd383
      
https://github.com/qemu/qemu/commit/555b3d67bc64bbcc3005f6619ab42552616bd383
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M contrib/rdmacm-mux/main.c
    M hw/rdma/rdma_backend.c

  Log Message:
  -----------
  hw/rdma: modify struct initialization

Do not initialize structs with {0} since some
CLANG versions do not support it.

Use {} construct instead.

Reviewed-by: Yuval Shaia <address@hidden>
Tested-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: 0f645ba16c6b76ccf2076d38460aa998198893bc
      
https://github.com/qemu/qemu/commit/0f645ba16c6b76ccf2076d38460aa998198893bc
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2019-01-19 (Sat, 19 Jan 2019)

  Changed paths:
    M Makefile
    M contrib/rdmacm-mux/Makefile.objs

  Log Message:
  -----------
  contrib/rdmacm-mux: fix clang compilation

Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
                 of RDMA User MAD multiplexer).

The above commit introduces a new contrib target, adding a global dependency
to libumad library in case pvrdma configuration option is enabled.
Clang forbids it:
    clang-6.0: error: -libumad: 'linker' input unused
        [-Werror,-Wunused-command-line-argument]

Fix by limiting the scope to the rdmacm-mux target itself.

Reported-by: Cornelia Huck <address@hidden>
Reviewed-by: Yuval Shaia <address@hidden>
Tested-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>


  Commit: e56b86bc7735dd076939fa33a76e1ee9d5907e47
      
https://github.com/qemu/qemu/commit/e56b86bc7735dd076939fa33a76e1ee9d5907e47
  Author: Peter Maydell <address@hidden>
  Date:   2019-01-21 (Mon, 21 Jan 2019)

  Changed paths:
    M Makefile
    M contrib/rdmacm-mux/Makefile.objs
    M contrib/rdmacm-mux/main.c
    M docs/pvrdma.txt
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_backend.h
    M hw/rdma/rdma_backend_defs.h
    M hw/rdma/rdma_rm.c
    M hw/rdma/vmw/pvrdma_main.c
    M hw/rdma/vmw/pvrdma_qp_ops.c
    M hw/rdma/vmw/pvrdma_qp_ops.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into 
staging

RDMA queue
 * Clang compilation fix
 * Coverity fix
 * Various fixes for the pvrdma device

# gpg: Signature made Sat 19 Jan 2019 09:13:53 GMT
# gpg:                using RSA key 36D4C0F0CF2FE46D
# gpg: Good signature from "Marcel Apfelbaum <address@hidden>"
# gpg:                 aka "Marcel Apfelbaum <address@hidden>"
# gpg:                 aka "Marcel Apfelbaum <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: B1C6 3A57 F92E 08F2 640F  31F5 36D4 C0F0 CF2F E46D

* remotes/marcel/tags/rdma-pull-request:
  contrib/rdmacm-mux: fix clang compilation
  hw/rdma: modify struct initialization
  contrib/rdmacm-mux: remove Wno-format-truncation flag
  hw: rdma: fix an off-by-one issue
  hw/rdma: Verify that ptr is not NULL before freeing
  hw/pvrdma: Make function pvrdma_qp_send/recv return void.
  hw/pvrdma: Post CQE when receive invalid gid index
  hw/rdma: Delete unused struct member
  hw/pvrdma: Remove max-sge command-line param
  docs/pvrdma: Update rdmacm-mux documentation

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/166609e6070f...e56b86bc7735
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]